development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-08-25 03:56:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #209464 from microsoft/merogge/disposable-store

Browse source 
use disposableStore for listeners created in render
This commit is contained in:
Megan Rogge 2024-04-03 14:35:27 -07:00 committed by GitHub
parent 9c892dba6a 6b91b701d0
commit 0f13661a91
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/vs/workbench/contrib/chat/browser/codeBlockPart.ts
View file

@ -9,7 +9,7 @@ import * as dom from 'vs/base/browser/dom';
import { Button } from 'vs/base/browser/ui/button/button';
import { Codicon } from 'vs/base/common/codicons';
import { Emitter } from 'vs/base/common/event';
import { Disposable } from 'vs/base/common/lifecycle';
import { Disposable, DisposableStore } from 'vs/base/common/lifecycle';
import { Schemas } from 'vs/base/common/network';
import { URI, UriComponents } from 'vs/base/common/uri';
import { IEditorConstructionOptions } from 'vs/editor/browser/config/editorConfiguration';
@ -124,6 +124,8 @@ export class CodeBlockPart extends Disposable {
private currentCodeBlockData: ICodeBlockData | undefined;
private currentScrollWidth = 0;
private disposableStore = this._register(new DisposableStore());
constructor(
private readonly options: ChatEditorOptions,
readonly menuId: MenuId,
@ -336,8 +338,9 @@ export class CodeBlockPart extends Disposable {
this.layout(width);
if (editable) {
this._register(this.editor.onDidFocusEditorWidget(() => TabFocus.setTabFocusMode(true)));
this._register(this.editor.onDidBlurEditorWidget(() => TabFocus.setTabFocusMode(false)));
this.disposableStore.clear();
this.disposableStore.add(this.editor.onDidFocusEditorWidget(() => TabFocus.setTabFocusMode(true)));
this.disposableStore.add(this.editor.onDidBlurEditorWidget(() => TabFocus.setTabFocusMode(false)));
}
this.editor.updateOptions({ ariaLabel: localize('chat.codeBlockLabel', "Code block {0}", data.codeBlockIndex + 1), readOnly: !editable });