development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-10-05 19:02:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove unneeded check for disposed terminal (#184190)

Browse source 
Since #180018 is fixed
This commit is contained in:
Rob Lourens 2023-06-02 10:25:35 -07:00 committed by GitHub
parent 8bac540235
commit 0cf685c1da
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/vs/workbench/contrib/chat/browser/actions/chatCodeblockActions.ts
View file

@ -336,9 +336,8 @@ export function registerChatCodeBlockActions() {
let terminal = await terminalService.getActiveOrCreateInstance();
// Why does getActiveOrCreateInstance return a disposed terminal? #180018
// isFeatureTerminal = debug terminal
const unusableTerminal = terminal.isDisposed || terminal.xterm?.isStdinDisabled || terminal.shellLaunchConfig.isFeatureTerminal;
// isFeatureTerminal = debug terminal or task terminal
const unusableTerminal = terminal.xterm?.isStdinDisabled || terminal.shellLaunchConfig.isFeatureTerminal;
terminal = unusableTerminal ? await terminalService.createTerminal() : terminal;
terminalService.setActiveInstance(terminal);