development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-11-05 18:29:38 +00:00
Code Issues Projects Releases Packages Wiki Activity

Disable remote settings search, fixes #172411 (#172424)

Browse source
This commit is contained in:
Raymond Zhao 2023-01-25 11:52:41 -08:00 committed by GitHub
parent 460d602f28
commit 0c441a5d89
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
src/vs/workbench/contrib/preferences/browser/preferencesSearch.ts
View file

@ -35,6 +35,7 @@ export interface IEndpointDetails {
export class PreferencesSearchService extends Disposable implements IPreferencesSearchService {
declare readonly _serviceBrand: undefined;
// @ts-expect-error disable remote search for now, ref https://github.com/microsoft/vscode/issues/172411
private _installedExtensions: Promise<ILocalExtension[]>;
constructor(
@ -56,6 +57,7 @@ export class PreferencesSearchService extends Disposable implements IPreferences
});
}
// @ts-expect-error disable remote search for now, ref https://github.com/microsoft/vscode/issues/172411
private get remoteSearchAllowed(): boolean {
const workbenchSettings = this.configurationService.getValue<IWorkbenchSettingsConfiguration>().workbench.settings;
if (!workbenchSettings.enableNaturalLanguageSearch) {
@ -80,13 +82,9 @@ export class PreferencesSearchService extends Disposable implements IPreferences
}
getRemoteSearchProvider(filter: string, newExtensionsOnly = false): ISearchProvider | undefined {
const opts: IRemoteSearchProviderOptions = {
filter,
newExtensionsOnly,
endpoint: this._endpoint
};
return this.remoteSearchAllowed ? this.instantiationService.createInstance(RemoteSearchProvider, opts, this._installedExtensions) : undefined;
// Disable for now because Bing search isn't supported anymore.
// Ref https://github.com/microsoft/vscode/issues/172411
return undefined;
}
getLocalSearchProvider(filter: string): LocalSearchProvider {
@ -165,6 +163,7 @@ interface IBingRequestDetails {
extensions?: ILocalExtension[];
}
// @ts-expect-error disable remote search for now, ref https://github.com/microsoft/vscode/issues/172411
class RemoteSearchProvider implements ISearchProvider {
// Must keep extension filter size under 8kb. 42 filters puts us there.
private static readonly MAX_REQUEST_FILTERS = 42;