development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-09-18 01:58:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

inline chat stable scroll should ensure first line stays visible (#216705)

Browse source
This commit is contained in:
Johannes Rieken 2024-06-20 13:05:30 +02:00 committed by GitHub
parent 4795e48fb5
commit 07dcb7aff4
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 13 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
src/vs/workbench/contrib/inlineChat/browser/inlineChatZoneWidget.ts
View file

@ -184,12 +184,21 @@ export class InlineChatZoneWidget extends ZoneWidget {
const lineTop = this.editor.getTopForLineNumber(lineNumber);
const zoneTop = lineTop - height.pixelsValue;
// const spaceBelowLine = this.editor.getScrollHeight() - this.editor.getBottomForLineNumber(position.lineNumber);
// const minTop = this.editor.getScrollTop() - spaceBelowLine;
// const newTop = Math.max(zoneTop, minTop);
const newTop = zoneTop;
const editorHeight = this.editor.getLayoutInfo().height;
const newLineBottom = this.editor.getBottomForLineNumber(lineNumber);
let newTop: number;
if (newLineBottom > editorHeight) {
newTop = newLineBottom - editorHeight;
} else {
newTop = zoneTop;
}
const currentTop = this.editor.getScrollTop();
// console.log('REVEAL ZONE TOP', { zoneTop, newLineBottom, editorHeight, currentTop, newTop });
if (newTop < currentTop) {
this.editor.setScrollTop(newTop, ScrollType.Immediate);
}