development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-08-28 05:19:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

Try automatically adding .md file extension to new paths on rename

Browse source
This commit is contained in:
Matt Bierner 2022-04-20 16:46:30 -07:00
parent 0ac39e800d
commit 0610f195fb
No known key found for this signature in database
GPG key ID: 099C331567E11888
2 changed files with 31 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
extensions/markdown-language-features/src/languageFeatures/rename.ts
View file

@ -10,6 +10,7 @@ import { resolveDocumentLink } from '../util/openDocumentLink';
import { MdWorkspaceContents, SkinnyTextDocument } from '../workspaceContents';
import { InternalHref } from './documentLinkProvider';
import { MdHeaderReference, MdLinkReference, MdReference, MdReferencesProvider, tryFindMdDocumentForLink } from './references';
import * as URI from 'vscode-uri';
const localize = nls.loadMessageBundle();
@ -145,7 +146,17 @@ export class MdRenameProvider extends Disposable implements vscode.RenameProvide
const targetDoc = await tryFindMdDocumentForLink(triggerHref, this.workspaceContents);
const targetUri = targetDoc?.uri ?? triggerHref.path;
const newFilePath = resolveDocumentLink(newName, triggerHref.path);
let newFilePath = resolveDocumentLink(newName, triggerHref.path);
if (!URI.Utils.extname(newFilePath)) {
// If the newly entered path doesn't have a file extension but the original file did
// tack on a .md file extension
if (URI.Utils.extname(targetUri)) {
newFilePath = newFilePath.with({
path: newFilePath.path + '.md'
});
}
}
// First rename the file
fileRenames.push({ from: targetUri.toString(), to: newFilePath.toString() });

19
extensions/markdown-language-features/src/test/rename.test.ts
View file

@ -463,6 +463,25 @@ suite('markdown: rename', () => {
});
});
test('Path rename should use .md extension on extension-less link', async () => {
const uri = workspacePath('doc.md');
const doc = new InMemoryDocument(uri, joinLines(
`[text](/doc#header)`,
`[ref]: /doc#other`,
));
const edit = await getRenameEdits(doc, new vscode.Position(0, 10), '/new File', new InMemoryWorkspaceMarkdownDocuments([doc]));
assertEditsEqual(edit!, {
originalUri: uri,
newUri: workspacePath('new File.md'),
}, {
uri: uri, edits: [
new vscode.TextEdit(new vscode.Range(0, 7, 0, 11), '/new%20File'),
new vscode.TextEdit(new vscode.Range(1, 7, 1, 11), '/new%20File'),
]
});
});
test('Rename on link should use header text as placeholder', async () => {
const uri = workspacePath('doc.md');
const doc = new InMemoryDocument(uri, joinLines(