development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-08-28 05:19:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

Normalize markdown links in notebooks (#148827)

Browse source 
Fixes #146352

This ensures we pass links in markdown cells through the same normalization function we use to assign headers ids
This commit is contained in:
Matt Bierner 2022-05-05 11:33:38 -07:00 committed by GitHub
parent 3316555e3f
commit 04ecb1d42f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 22 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

26
extensions/markdown-language-features/notebook/index.ts
View file

@ -26,6 +26,7 @@ export const activate: ActivationFunction<void> = (ctx) => {
markdownIt.linkify.set({ fuzzyLink: false });
addNamedHeaderRendering(markdownIt);
addLinkRenderer(markdownIt);
const style = document.createElement('style');
style.textContent = `
@ -225,12 +226,12 @@ function addNamedHeaderRendering(md: InstanceType<typeof MarkdownIt>): void {
const originalHeaderOpen = md.renderer.rules.heading_open;
md.renderer.rules.heading_open = (tokens: MarkdownItToken[], idx: number, options, env, self) => {
const title = tokens[idx + 1].children!.reduce<string>((acc, t) => acc + t.content, '');
let slug = slugFromHeading(title);
let slug = slugify(title);
if (slugCounter.has(slug)) {
const count = slugCounter.get(slug)!;
slugCounter.set(slug, count + 1);
slug = slugFromHeading(slug + '-' + (count + 1));
slug = slugify(slug + '-' + (count + 1));
} else {
slugCounter.set(slug, 0);
}
@ -251,9 +252,26 @@ function addNamedHeaderRendering(md: InstanceType<typeof MarkdownIt>): void {
};
}
function slugFromHeading(heading: string): string {
function addLinkRenderer(md: MarkdownIt): void {
const original = md.renderer.rules.link_open;
md.renderer.rules.link_open = (tokens: MarkdownItToken[], idx: number, options, env, self) => {
const token = tokens[idx];
const href = token.attrGet('href');
if (typeof href === 'string' && href.startsWith('#')) {
token.attrSet('href', '#' + slugify(href.slice(1)));
}
if (original) {
return original(tokens, idx, options, env, self);
} else {
return self.renderToken(tokens, idx, options);
}
};
}
function slugify(text: string): string {
const slugifiedHeading = encodeURI(
heading.trim()
text.trim()
.toLowerCase()
.replace(/\s+/g, '-') // Replace whitespace with -
// allow-any-unicode-next-line