development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-08-28 13:29:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

notificationFilter.ERROR

Browse source
This commit is contained in:
isidor 2019-10-18 10:41:27 +02:00
parent 671fc8f654
commit 00de15d765
5 changed files with 15 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/vs/platform/notification/common/notification.ts
View file

@ -238,7 +238,12 @@ export enum NotificationsFilter {
* All notifications are configured as silent. See
* `INotificationProperties.silent` for more info.
*/
SILENT
SILENT,
/**
* All notifications are silent except error notifications.
*/
ERROR
}
/**

2
src/vs/workbench/browser/layout.ts
View file

@ -685,7 +685,7 @@ export abstract class Layout extends Disposable implements IWorkbenchLayoutServi
this.state.zenMode.setNotificationsFilter = config.silentNotifications;
if (config.silentNotifications) {
this.notificationService.setFilter(NotificationsFilter.SILENT);
this.notificationService.setFilter(NotificationsFilter.ERROR);
}
if (config.centerLayout) {

2
src/vs/workbench/browser/parts/notifications/notificationsToasts.ts
View file

@ -95,7 +95,7 @@ export class NotificationsToasts extends Themable {
// Filter
this._register(this.model.onDidFilterChange(filter => {
if (filter === NotificationsFilter.SILENT) {
if (filter === NotificationsFilter.SILENT || filter === NotificationsFilter.ERROR) {
this.hide();
}
}));

2
src/vs/workbench/common/notifications.ts
View file

@ -438,7 +438,7 @@ export class NotificationViewItem extends Disposable implements INotificationVie
actions = { primary: notification.message.actions };
}
return new NotificationViewItem(severity, notification.sticky, notification.silent || filter === NotificationsFilter.SILENT, message, notification.source, actions);
return new NotificationViewItem(severity, notification.sticky, notification.silent || filter === NotificationsFilter.SILENT || (filter === NotificationsFilter.ERROR && notification.severity !== Severity.Error), message, notification.source, actions);
}
private static parseNotificationMessage(input: NotificationMessage): INotificationMessage | undefined {

6
src/vs/workbench/test/common/notifications.test.ts
View file

@ -134,6 +134,12 @@ suite('Notifications', () => {
let item9 = NotificationViewItem.create({ severity: Severity.Error, message: 'Error Message' }, NotificationsFilter.OFF)!;
assert.equal(item9.silent, false);
let item10 = NotificationViewItem.create({ severity: Severity.Error, message: 'Error Message' }, NotificationsFilter.ERROR)!;
assert.equal(item10.silent, false);
let item11 = NotificationViewItem.create({ severity: Severity.Warning, message: 'Error Message' }, NotificationsFilter.ERROR)!;
assert.equal(item11.silent, true);
});
test('Model', () => {