development/github-desktop
development/github-desktop
1
0
Fork 0
mirror of https://github.com/desktop/desktop synced 2024-10-31 11:07:25 +00:00
Code Issues Projects Releases Packages Wiki Activity
35031 commits 304 branches 713 tags 371 MiB
Commit graph

313 commits

Author SHA1 Message Date
Kendall Pinto
60806f5d9a
Update .github/pull_request_template.md 
Co-authored-by: Markus Olsson <j.markus.olsson@gmail.com>
 2021-12-08 15:02:59 +05:30
Kendall Pinto
bad051ecff
Update pull_request_template.md 2021-12-07 23:46:20 +05:30
Markus Olsson
fe486adfac Read-only GITHUB_TOKEN for CI jobs 2021-09-21 10:15:56 +02:00
Markus Olsson
8cbd5bb2f1 🎨 Update comments from template 2021-09-21 09:58:37 +02:00
Markus Olsson
d1b2c720e7 Remove unnecessary head checkout 
See 7112cdaa06/src/actions-util.ts (L186)
 2021-09-21 09:58:10 +02:00
Markus Olsson
d4b0266803 Tighten up permissions 
https://github.com/github/codeql-action#usage
 2021-09-21 09:57:26 +02:00
Markus Olsson
d4734a7625 Fix mismatched branches 
7112cdaa06/src/actions-util.ts (L182)
 2021-09-21 09:56:33 +02:00
Markus Olsson
8619511ebd
Update CONTRIBUTING.md 2021-09-06 18:08:33 +02:00
tidy-dev
f21fde08ee Remove S3 bucket refs 2021-08-30 09:29:27 -04:00
tidy-dev
0584759cf3
Add Azure secrets to env 2021-08-03 12:29:54 -04:00
Billy Griffin
f8be19e673 Minor consistency updates 2021-07-26 16:20:35 -06:00
Ed L
c7a871b8dc fix grammar for issue templates 
fix grammar for feature req template

fix grammar for bug report template

fix: add commas
 2021-07-18 17:53:16 +01:00
tidy-dev
0eeecfd0e6
Update build timeout 2021-04-23 13:02:09 -04:00
Sergio Padrino
d4cde0066d Use npm_config_arch to publish the new builds 2021-04-08 16:12:09 +02:00
Dennis Ameling
9c6094b5b8 Fix typo in GH Actions workflow 2021-02-19 11:41:28 +01:00
Dennis Ameling
4ab0f99370 Fix GH Actions matrix 2021-02-19 11:15:17 +01:00
Dennis Ameling
08400717c0 Also build macOS arm64 2021-02-19 11:07:39 +01:00
Dennis Ameling
20f7b65c85 Fix NodeJS version to 14.15.4 to prevent future regressions in the arm64 download 2021-02-11 14:57:01 +01:00
Dennis Ameling
ba6891c945 Fix Windows arm64 NodeJS version to 14.15.4 2021-02-11 14:46:01 +01:00
Dennis Ameling
a452402fd1 Merge remote-tracking branch 'upstream/development' into windows-arm-support 2021-02-11 14:40:07 +01:00
Markus Olsson
644ff015a7 Revert to macos-10.15 runners 2021-01-12 15:47:47 +01:00
Dennis Ameling
dcc597c0e3 Update Spectron, re-enable integration tests 2020-12-22 12:04:49 +01:00
Dennis Ameling
840ea703ba Fix typo in MacOS version 2020-12-22 12:04:49 +01:00
Dennis Ameling
a04c7b0a14 Bump NodeJS version to v14 2020-12-22 12:04:49 +01:00
Dennis Ameling
75e6ed9e91 Update keytar for Windows, temp disable integration tests 2020-12-22 12:04:49 +01:00
Dennis Ameling
45e8d526a1 Cleanup & optimizations 2020-11-19 10:48:13 +01:00
Dennis Ameling
c348ceadba Skip tests in CI on arm64 2020-11-19 10:29:56 +01:00
Dennis Ameling
001426dd08 Fix linting 2020-11-19 10:29:56 +01:00
Dennis Ameling
3172a87f58 Download Windows arm64 node lib in CI 2020-11-19 10:29:56 +01:00
Dennis Ameling
f703db4785 Add friendly name for Windows arm64 2020-11-19 10:29:56 +01:00
Dennis Ameling
312f20ac28 Tweak CI config 2020-11-19 10:29:56 +01:00
Dennis Ameling
a36241d5a0 Try to fix CI config 2020-11-19 10:29:55 +01:00
Dennis Ameling
fb8306d33a Another attempt to fix CI config 2020-11-19 10:29:55 +01:00
Dennis Ameling
c70d60e31f Fix mistake in CI config 2020-11-19 10:29:55 +01:00
Dennis Ameling
a65219e79d Add Windows arm64 to CI 2020-11-19 10:29:55 +01:00
Billy Griffin
1c00fbc2cf Update issue templates 2020-10-27 08:43:48 -06:00
Billy Griffin
b76812fd28 Update issue templates 2020-10-27 08:43:00 -06:00
Markus Olsson
bdcd174936
Merge pull request #10878 from desktop/fill-out-the-template 
Require that users fill out the issue template
 2020-10-20 18:18:54 +02:00
Steve Ward
090c5d11c4
Add a period 2020-10-20 11:50:45 -04:00
Markus Olsson
c9f18eceaa Require that users fill out the issue template 2020-10-20 17:11:38 +02:00
Steve Ward
6f81fef572
Update label and reduce daysUntilClose time 2020-10-19 11:43:10 -04:00
Markus Olsson
361bfd81b4 Split the pre build checks step into three individual steps 2020-09-10 22:04:41 +02:00
Markus Olsson
8702d0619d Give us a little bit more room to play with 2020-08-25 12:36:24 +02:00
Markus Olsson
31d08ba091 Don't limit execution time for publish step 
Windows takes forever for some reason
 2020-08-25 12:36:14 +02:00
Markus Olsson
3ae2720cfa Give it a little bit more generous timeouts 
See if that'll do it
 2020-08-17 13:36:10 +02:00
Markus Olsson
dcb4293244 Include node version in matrix 2020-08-13 14:11:53 +02:00
rafeca
bb29135587
Merge remote-tracking branch 'upstream/development' into node-12.14.1 2020-08-13 11:02:37 +02:00
Markus Olsson
ac3b9e8b87 Just the OS is enough I think 2020-08-11 18:07:06 +02:00
Markus Olsson
99d00c9b74 Use exact cache match if it exists 2020-08-11 17:52:40 +02:00
rafeca
9323e09c4c
Merge branch 'spike/actions-win32' into node-12.14.1 2020-08-11 17:41:54 +02:00
rafeca
7f20b8e1ec
Remove branches filtering from pull_requests event 
I don't know if this is causing PRs from forks to not run...
 2020-08-11 17:40:28 +02:00
rafeca
280d432bf3
Update nodejs version to v12.14.1 
This is the same version as used by electron v9
 2020-08-11 17:29:35 +02:00
Markus Olsson
14465f976c INDENTATION THOUGH 2020-08-11 17:15:45 +02:00
Markus Olsson
95ad1ff387 is rafael cleverer than a fox? 2020-08-11 17:14:53 +02:00
Markus Olsson
53c5422b5d This is how I would like it to work 2020-08-11 17:10:42 +02:00
Markus Olsson
bc7377dd8f
Update .github/workflows/ci.yml 
Co-authored-by: Rafael Oleza <rafeca@github.com>
 2020-08-11 16:45:05 +02:00
rafeca
e92783ddf8
Revert "Disable core.symlinks on windows" 
This reverts commit 1d6b7e9048.
 2020-08-11 11:54:14 +02:00
Rafael Oleza
79bcf7cfa0
Execute tests before publishing the production app 2020-07-23 10:03:49 +02:00
Rafael Oleza
4011001110
Add some secrets to the build step 
Some secrets are needed in the build step for macOS
 2020-07-22 20:16:17 +02:00
Rafael Oleza
1d6b7e9048
Disable core.symlinks on windows 2020-07-22 17:24:39 +02:00
Rafael Oleza
853dfea451
Pin to major versions for OS images 2020-07-22 17:24:39 +02:00
Rafael Oleza
9398db9e80
Add missing secrets 2020-07-22 17:24:39 +02:00
Rafael Oleza
ce6228ba09
Run the GitHub Actions workflow on release branches 2020-07-22 17:24:38 +02:00
Markus Olsson
522a1fb134 Try splitting it out even further to see if we can get windows builds to fail 2020-07-09 22:47:53 +02:00
Markus Olsson
10e880bc9b I guess not? 2020-07-09 19:29:30 +02:00
Markus Olsson
ee5c0b435e Try a nicer job name 2020-07-09 17:01:11 +02:00
Markus Olsson
48fe311d7f Whoops 2020-07-09 16:56:11 +02:00
Markus Olsson
53705838d4 Rename action to ci 2020-07-09 16:25:53 +02:00
Markus Olsson
fe4902d1bb Maybe it's time to stop referring to this as win32 only 2020-07-09 16:25:20 +02:00
Markus Olsson
fd3936ffdd How hard could it possibly be? 2020-07-09 16:13:44 +02:00
Markus Olsson
f4aace4b30 Split up unit and integration tests 
Temporarily so that we can debug integration tests on their own
 2020-07-09 16:01:43 +02:00
Markus Olsson
110fd8dd69 Add an initial publish step (don't worry, it doesn't have the creds to publish yet) 2020-07-09 15:54:03 +02:00
Markus Olsson
86f432b18b Add some secrets 2020-07-09 15:53:46 +02:00
Markus Olsson
b57a6c3f09 Oh wait, I'm at fault, as per usual 2020-07-09 15:43:03 +02:00
Markus Olsson
347a3548b5 Try inspecting what's changed 2020-07-09 15:42:05 +02:00
Markus Olsson
2bbc9b5444 Give it a little bit more time 2020-07-09 15:31:04 +02:00
Markus Olsson
c16ce787a4 Lint it 2020-07-09 15:30:33 +02:00
Markus Olsson
2dfa2d09dd Build it 2020-07-09 15:30:20 +02:00
Markus Olsson
423a91d56c Limit the run time 2020-07-09 15:14:34 +02:00
Markus Olsson
a483c9282f Don't know how I managed to duplicate that 2020-07-09 14:49:12 +02:00
Markus Olsson
f80301f59a Cache yarn packages 2020-07-09 14:30:14 +02:00
Markus Olsson
f7bc91ce98 More apt description 2020-07-09 14:30:06 +02:00
Markus Olsson
0bbbcf3360 We're on Node 12 now 2020-07-09 14:20:38 +02:00
Markus Olsson
0e52ceeba6 This is already set by default 
See https://docs.github.com/en/actions/configuring-and-managing-workflows/using-environment-variables
 2020-07-09 14:12:17 +02:00
Markus Olsson
c426945b79 Set CI env var for all steps 
See https://docs.github.com/en/actions/configuring-and-managing-workflows/using-environment-variables
 2020-07-09 14:08:36 +02:00
Markus Olsson
4f880903b2 Merge branch 'development' into spike/actions-win32 2020-07-09 14:03:15 +02:00
Markus Olsson
7fe0666772 Last attempt before I toss this all out the window 2020-06-24 15:29:08 +02:00
Markus Olsson
fe7f66de7d How about this then? 2020-06-24 15:19:11 +02:00
Markus Olsson
270400ceac Only run on pushes to development 
We enforce all changes going through PRs so the current approach means we'll always run it twice
 2020-06-24 14:51:43 +02:00
Markus Olsson
b01022858e Face, meet palm 2020-06-24 14:41:11 +02:00
Markus Olsson
0a9bdb9949
Update .github/codeql/codeql-config.yml 2020-06-24 14:37:36 +02:00
Markus Olsson
a2cb4d1831 Exclude the vendor directory from code scanning 2020-06-24 12:46:51 +02:00
Justin Hutchings
913c399cc5 Update codeQL action to run on PRs from forks 2020-06-03 20:53:08 -07:00
Justin Hutchings
9b58cbe814 Run prettier on codeql.yml 
Fix linting issues
 2020-06-03 20:50:06 -07:00
Justin Hutchings
ca23638ca0
Rename .github/workflows/workflows/codeql.yml to .github/workflows/codeql.yml 2020-05-04 17:48:07 -07:00
evelyn masso
28242cb4e2 checkout with submodules recursively 2020-04-30 16:59:34 -07:00
evelyn masso
bc108761e6 maybe we don't need this 2020-04-30 16:56:17 -07:00
evelyn masso
aaeb138524 first try 2020-04-30 16:50:14 -07:00
Justin Hutchings
57b9707b39 Add CodeQL Analysis workflow 2020-04-28 12:25:07 -07:00
Tiernan L
2d05d3ed0d
Merge branch 'development' into shorten-issues 2019-10-04 18:06:39 -07:00
Billy Griffin
a7cf202313
Update .github/ISSUE_TEMPLATE/problem-to-raise.md 2019-10-04 12:38:00 -06:00
Billy Griffin
672138b81d
Update .github/ISSUE_TEMPLATE/bug_report.md 2019-10-04 12:37:54 -06:00
Tiernan L
c1c824ed39
swap emoji 2019-10-03 13:46:57 -10:00
Tiernan L
eb864919c3
typo 2019-10-03 13:41:54 -10:00
Tiernan L
d5eb68b30a
simplify the template 2019-10-03 13:41:09 -10:00
Tiernan L
1a29d28117
simplify the template 2019-10-03 13:38:33 -10:00
evelyn masso
d38f2be855 move screenshots under description 
Co-Authored-By: Billy Griffin <billygriffin@users.noreply.github.com>
 2019-10-03 11:36:51 -07:00
evelyn masso
5c5b3d2fb2
Apply suggestions from code review 
Co-Authored-By: Billy Griffin <5091167+billygriffin@users.noreply.github.com>
 2019-10-03 11:34:56 -07:00
evelyn masso
5a8e802d10 Update pull_request_template.md 2019-10-02 12:44:17 -07:00
evelyn masso
a08e57ca77
Update .github/CONTRIBUTING.md 
Co-Authored-By: Billy Griffin <5091167+billygriffin@users.noreply.github.com>
 2019-09-06 09:57:32 -07:00
evelyn masso
fe34d8f689
fix link and reduce snark 2019-09-06 08:52:14 -07:00
Tiernan L
4865b76cbc
swap label to new one 2019-07-24 15:00:09 -10:00
Tiernan L
d276354c32
add intro section 2019-06-26 15:23:48 -10:00
Tiernan L
842abf293d
adding easier way to access log files 2019-06-26 15:17:11 -10:00
Jed Fox
bf8bf8d481
Apply suggestions from code review 
Co-Authored-By: shiftkey <brendan@github.com>
 2018-12-28 13:39:51 -04:00
Brendan Forster
78ed98e7e4 tweak and organize PR template details 2018-12-28 13:08:32 -04:00
evelyn masso
d4be778adf remove references to master in docs 2018-12-27 15:38:17 -08:00
Brendan Forster
6f61a65128 add section for interesting process docs 2018-11-02 12:02:19 -03:00
Brendan Forster
e097d24fba add bullet points to these sections 2018-11-02 12:02:08 -03:00
Brendan Forster
1ac6b7fccd move labels into own doc 2018-10-26 17:01:45 -03:00
William Shepherd
388ccd0993
Merge pull request #5994 from desktop/shiftkey-patch-2 
help improve our release notes by writing them earlier
 2018-10-25 15:50:02 -05:00
William Shepherd
d5ed7c9220
Merge pull request #5899 from desktop/shiftkey-patch-1 
refreshed screenshots and instructions for timeline doc
 2018-10-25 11:50:56 -05:00
Brendan Forster
e849533b97
add some examples to guide contributors 2018-10-25 12:50:51 -03:00
Billy Griffin
e6c087384e
Update .github/pull_request_template.md 
Co-Authored-By: shiftkey <brendan@github.com>
 2018-10-25 12:13:57 -03:00
Brendan Forster
6e66377866
tweak comment 2018-10-25 10:07:38 -03:00
Brendan Forster
f4d6cefa27
help us improve our release notes by writing them earlier 2018-10-25 09:58:47 -03:00
evelyn masso
b1dbaa19db curly braces 2018-10-24 11:25:49 -07:00
Billy Griffin
70becdd49e
less abbreves 
Co-Authored-By: outofambit <outofambit@github.com>
 2018-10-24 11:24:48 -07:00
evelyn masso
42ce01de22 links 2018-10-24 11:06:46 -07:00
evelyn masso
6285b79000 closes 2018-10-24 11:03:39 -07:00
evelyn masso
696b6d6553 Update .github/pull_request_template.md 
Co-Authored-By: William Shepherd <iamwillshepherd@users.noreply.github.com>
Co-Authored-By: Billy Griffin <billygriffin@users.noreply.github.com>
 2018-10-24 11:03:11 -07:00
William Shepherd
3af297fc09
Update .github/pull_request_template.md 
Co-Authored-By: outofambit <outofambit@github.com>
 2018-10-24 10:52:35 -07:00
Billy Griffin
09deec49fd
Update .github/pull_request_template.md 
Co-Authored-By: outofambit <outofambit@github.com>
 2018-10-24 10:51:28 -07:00
evelyn masso
d96d10dc39 simple pr template draft 2018-10-23 16:36:18 -07:00
Brendan Forster
6bace95173
rename mention of Timeline in bug report template 2018-10-15 11:20:15 -03:00
Brendan Forster
aa170a11b4
Delete lock.yml 2018-09-26 12:14:32 -03:00
Christine Hu
9e98d55cf7
Update template links 2018-09-16 07:33:15 -04:00
Christine Hu
976625430f
Update CONTRIBUTING.md 2018-09-16 07:29:45 -04:00
Christine Hu
6236c9bf9d
Update CONTRIBUTING.md 2018-09-16 07:29:08 -04:00
Jed Fox
15c4019a55 Merge branch 'master' into prettier-1.14 2018-08-08 19:41:25 -04:00
Brendan Forster
f39e962c5a
renamed the file to drop the preceding dashes 2018-08-07 11:02:44 -03:00
Sungwon Ma
10d5573a01 clarify setup instructions on doc 2018-08-03 13:18:16 -04:00
Billy Griffin
2c34af36f7 Remove feature request issue template 
We're replacing this with "Problem to raise" to reframe the types of issues we'd like to get more as problem statements that impact users, and less as feature requests.
 2018-08-01 10:26:30 -06:00
Billy Griffin
4b04497eb1 Update issue template 2018-08-01 10:25:01 -06:00
Jed Fox
fa1f3b1655 Upgrade Prettier to 1.14 (beta) 2018-07-18 06:42:46 -04:00
Brendan Forster
56b1fe71f5
ensure future proposals aren't locked automatically 2018-07-17 15:23:49 -03:00
Brendan Forster
e1f606db4c
Update lock.yml 2018-07-17 14:19:24 -03:00
Brendan Forster
2df44293a8
add the rules for the lock extension 2018-07-17 14:10:04 -03:00
Brendan Forster
33e39216dc
add label to track integration-related issues 2018-07-03 15:08:14 -03:00
Billy Griffin
537a9401cf
Add user research label 
Some issues are more usability-related than others and would benefit from user research. This could take the form of interviews, observation, usability testing, or other methods, but I think it'll be helpful to organize them so we know areas of potential focus for UX research. This doesn't mean we'll necessarily incorporate every one into our upcoming user research plans, but rather that they've been identified as reasonable to include and will be available for inclusion in those efforts.
 2018-06-29 09:23:25 -06:00