development/github-desktop
development/github-desktop
1
0
Fork 0
mirror of https://github.com/desktop/desktop synced 2024-10-02 22:34:41 +00:00
Code Issues Packages Projects Releases Wiki Activity
34615 commits 302 branches 698 tags 366 MiB
Commit graph

27642 commits

Author SHA1 Message Date
Markus Olsson 4fa845d7c3 Don't traverse the same path more than once 2023-06-13 11:45:00 +02:00
Sergio Padrino cdf08b0a1e Remove enableStackedPopups 2023-06-13 10:14:10 +02:00
Sergio Padrino d577533356 Remove enableStartingPullRequests 2023-06-13 10:09:04 +02:00
Sergio Padrino 11ee0fdcc9 Remove enableMultiCommitDiffs 2023-06-13 10:07:38 +02:00
Sergio Padrino bfd43225c1 Remove enableSubmoduleDiff 2023-06-13 10:05:45 +02:00
Sergio Padrino 17c2a414ab Remove enablePreventClosingWhileUpdating 2023-06-13 10:04:54 +02:00
Sergio Padrino 636fe00e7d Remove enablePushPullFetchDropdown 2023-06-13 10:04:15 +02:00
Sergio Padrino 67b4349c8f Remove enablePullRequestCommentNotifications 2023-06-13 10:02:59 +02:00
Sergio Padrino 05519aec06 Check if selection.rangeCount > 0 before checking getRangeAt 2023-06-12 18:37:05 +02:00
Markus Olsson 603058e209 Merge pull request #16772 from desktop/lets-get-these-crashes-started 
Send uncaught errors to the non-fatal bucket
 2023-06-12 18:20:47 +02:00
tidy-dev 9c63ef1949 Apply to add-existing-repository errors 2023-06-07 09:09:53 -04:00
tidy-dev e8bfd189fe Add some input-description styles 2023-06-06 12:51:51 -04:00
tidy-dev e72ecaace3 Make sure aria-live doesn't announce one to many times 2023-06-06 12:51:29 -04:00
tidy-dev f8fdb6ead7 Create input description types 2023-06-06 12:51:03 -04:00
tidy-dev d55fe93723 Create input-description.tsx 2023-06-06 12:50:44 -04:00
tidy-dev 844a18d5ac Add aria labeling to toolbar dropdown "caret" button 2023-06-05 13:19:05 -04:00
Sergio Padrino e6dc80b320 Bump changelog and version to 3.2.4 2023-06-05 18:17:41 +02:00
tidy-dev e6f2095a80 Merge pull request #16566 from desktop/one-windows-version-ought-to-be-enough-for-anybody 
Disable automatic updates on Windows 7 / 8.1
 2023-06-05 17:56:34 +02:00
Sergio Padrino ecb899efb5 Merge pull request #16684 from desktop/misattribued-avatar-using-position-fixed 
Use `position: fixed` to position the Misattributed Commit Popover
 2023-06-05 17:55:36 +02:00
Sergio Padrino ede6492668 Merge pull request #16651 from desktop/autocomplete-popup-portal 
Use `position: fixed` to render autocomplete popups
 2023-06-05 17:55:36 +02:00
Sergio Padrino e4ea5bbc8f Merge pull request #16667 from desktop/fix-shortcut-key-warning 
Fix React warning about missing `key` for `KeyboardShortcut` children
 2023-06-05 17:55:36 +02:00
tidy-dev 6db43d263d Merge pull request #16632 from desktop/Fix-erroneous-squash-dialog 
Close commit message dialog on squash start
 2023-06-05 17:54:20 +02:00
tidy-dev ae3d272001 Merge pull request #16631 from desktop/fix-multi-commit-selection-to-be-bi-directional 
Order commits by history for multi-commit diffing
 2023-06-05 17:54:20 +02:00
kitswas 0ec847f0db
Added screen reader support 
Co-authored-by: tidy-dev <75402236+tidy-dev@users.noreply.github.com>
 2023-06-02 07:32:18 +05:30
tidy-dev b3012fac79 Reuse checkout logic 2023-06-01 12:13:05 -04:00
tidy-dev 443e04ba86
Merge pull request #16808 from desktop/releases/3.2.4-beta1 
Release 3.2.4-beta1
 2023-05-31 12:42:35 -04:00
tidy-dev f9c122977a
Merge pull request #16809 from desktop/dialog-error-banner-role-alert 
Dialog error banner has role of alert
 2023-05-31 11:13:06 -04:00
tidy-dev dc8f162f1b Remove file-loader dependency 2023-05-31 08:55:33 -04:00
tidy-dev 8f8245a32a Update es lint rules 2023-05-31 08:29:19 -04:00
Sergio Padrino b090278316
Merge pull request #16562 from digitalmaster/addDoubleClickToOpenInDefaultEditor 
Add Double Click to Open in Default Editor
 2023-05-31 11:51:07 +02:00
tidy-dev 4d94a8b33f Merge branch 'development' into Electron-24 2023-05-31 05:36:03 -04:00
digitalmaster 6b597e4ea9 PR Feedback: Fix typo round II 2023-05-30 18:22:25 -05:00
digitalmaster f6be832186 Bug Fix: "Right click to open" argument path should be relative 2023-05-30 18:18:38 -05:00
tidy-dev 03a471721c Merge branch 'development' into dialog-error-banner-role-alert 2023-05-30 10:12:01 -04:00
tidy-dev 079b1e7b4e Release 3.2.4-beta1 2023-05-30 07:32:52 -04:00
tidy-dev 8690395e55
Merge pull request #16566 from desktop/one-windows-version-ought-to-be-enough-for-anybody 
Disable automatic updates on Windows 7 / 8.1
 2023-05-30 07:18:36 -04:00
tidy-dev 9e26397fbe
Merge pull request #16802 from desktop/alias-a11y 
Improve accessibility of "Create Alias" dialog
 2023-05-30 06:57:05 -04:00
tidy-dev 462d198578
Merge pull request #16792 from desktop/more-welcome-flow-transition-tweaks 
More welcome flow transition tweaks
 2023-05-30 05:50:48 -04:00
digitalmaster cf3a402119 PR Feedback: Stop onRowDoubleClick hoisting @ changes-list 2023-05-29 13:55:53 -05:00
digitalmaster eb79b82e74 PR Feedback: Remove unnecessary error handling 2023-05-29 13:51:40 -05:00
digitalmaster 2eab558081 PR Feedback: Typo 2023-05-29 13:50:43 -05:00
Sergio Padrino 6886a9f2d9
Merge pull request #16633 from IgnazioGul/fix-clone-repo-path 
Clone Directory Messes Up When Changing URL
 2023-05-29 19:39:07 +02:00
Sergio Padrino 7c0ff3a5ea Improve accessibility of create alias dialog 2023-05-29 11:05:34 +02:00
digitalmaster 42c0b8c440 Remove "Go to specific line" feature 2023-05-27 16:45:43 -04:00
IgnazioGul 56bf2c5e75 add test for invalid URLs parsing 2023-05-27 20:46:16 +02:00
tidy-dev 45bbf609fe Use aria-described by for the "what is github blurb" 2023-05-26 14:05:17 -04:00
tidy-dev b18e42b952 Add "what is github blurb" to region title? 2023-05-26 13:30:59 -04:00
tidy-dev ee79e4bb11 Add loading state for async retrieval of git config 2023-05-26 13:30:41 -04:00
tidy-dev 43ae9ffb6c Move link below buttons so button is first focusable element 2023-05-26 13:29:54 -04:00
tidy-dev 696a6f4e92 Auto-focus sign in button 2023-05-26 13:25:49 -04:00
tidy-dev a2f8eeffed
Update app/src/ui/lib/filter-list.tsx 
Co-authored-by: Sergio Padrino <sergio.padrino@gmail.com>
 2023-05-26 11:37:45 -04:00
tidy-dev 82e924d6b3
Don't need filterValue initialized anymore 
Co-authored-by: Sergio Padrino <sergio.padrino@gmail.com>
 2023-05-26 11:31:58 -04:00
tidy-dev dbc1a40334 Use AriaLiveContainer for git email not found warning 2023-05-26 10:46:25 -04:00
tidy-dev 2fa08af651 Linter 2023-05-26 10:30:53 -04:00
tidy-dev a21a03f392 Update filterValue state at same time as row state is updated 2023-05-26 10:28:02 -04:00
tidy-dev 47ed1c8780 Use autocomplete range text for aria live possible announcement events 2023-05-26 09:22:56 -04:00
tidy-dev f7488d09c6 Debounce forcing of change in aria live container 2023-05-26 08:14:13 -04:00
tidy-dev d47ee700d9 Add forcing of change on filter list announcements 2023-05-26 05:52:08 -04:00
tidy-dev 3a7956c2ae Add role alert to dialog error 2023-05-26 05:51:15 -04:00
tidy-dev 003a1b4090
Merge pull request #16779 from desktop/filter-list-aria-live 
Add aria-live message to `FilterList`
 2023-05-25 16:30:52 +00:00
tidy-dev ba40b2b255
Merge pull request #16773 from desktop/readonly-text-box 
Improve accessibility of the username textbox in "Configure Git" screen
 2023-05-25 16:30:40 +00:00
Sergio Padrino 44b24b9918
Merge pull request #16781 from desktop/repository-list-expanded 
Add `aria-expanded` to dropdowns and "Add repository" button
 2023-05-25 16:48:14 +02:00
tidy-dev cadfc10489
Merge pull request #16774 from desktop/Announce-let-gets-started-when-not-signed-in 
Announce "Let's get started!" when not signed in
 2023-05-25 12:32:29 +00:00
Sergio Padrino 60c49e60a0 For "multi-option" dropdowns, set aria-expanded in the arrow button 2023-05-25 11:43:35 +02:00
Sergio Padrino e10e35a3cb Add ariaExpanded to "Add" button in repository list 2023-05-25 11:34:31 +02:00
Sergio Padrino 5db5095827 Set ariaExpanded attribute to toolbar dropdown button instead of container 2023-05-25 11:34:03 +02:00
Sergio Padrino b619016b28 Add aria-live message to FilterList 2023-05-25 10:46:52 +02:00
Markus Olsson d0de9dfb24
Update app/src/ui/about/about.tsx 
Co-authored-by: Sergio Padrino <sergio.padrino@gmail.com>
 2023-05-25 10:38:28 +02:00
Markus Olsson e2a70001b0
Merge pull request #16772 from desktop/lets-get-these-crashes-started 
Send uncaught errors to the non-fatal bucket
 2023-05-25 10:05:51 +02:00
kitswas 5cd3ff302e Linting 2023-05-25 00:07:17 +05:30
Sergio Padrino f726f74ba8 Make sure readonly textboxes look like disabled ones 2023-05-24 17:23:08 +02:00
Sergio Padrino 0182d0c9cb Turn "Configure Git" username's textbox readonly instead of disabled 2023-05-24 17:22:52 +02:00
Sergio Padrino 1dfaa01654 Add explicit type="text" attribute to textboxes 
This will prevent some issues/reports from accessibility tools.
 2023-05-24 17:22:31 +02:00
tidy-dev 08afa55216 Remove buttons from list that prevents section announcement 2023-05-24 10:59:26 -04:00
tidy-dev 2858790930 Auto focus first button when no repo list 2023-05-24 10:59:08 -04:00
Markus Olsson 758360de96 Send uncaught errors to the non fatal bucket 2023-05-24 15:54:43 +02:00
tidy-dev e9900ad8bb
Merge pull request #16765 from desktop/aria-label-fix 
Fix aria label that was messed up in merge conflict resolution
 2023-05-24 13:53:30 +00:00
Sergio Padrino 2f8710e448
Merge pull request #16759 from desktop/refactor-popover-dropdown 
Refactor `PopoverDropdown` to rely on the new `Popover` to calculate the available height
 2023-05-24 15:22:09 +02:00
tidy-dev 6b100b328b Fix aria label that was messed up in merge conflict resoltionflict r 2023-05-24 05:34:52 -04:00
kitswas b0cc409261 Display short SHA 
See https://github.com/desktop/desktop/pull/16120#discussion_r1201914428
 2023-05-24 08:06:07 +05:30
kitswas 49707e3271 Bugfix 
See https://github.com/desktop/desktop/pull/16120#discussion_r1201738594
 2023-05-24 08:04:02 +05:30
tidy-dev 7cab24e356 Refactor branch list context menu callback to the list item 2023-05-23 11:37:07 -04:00
Sergio Padrino 7ccdb16f45 Remove height logic from popover dropdown 2023-05-23 16:41:17 +02:00
tidy-dev 6b7dfb3a38 Move context menu invokation to out list container 2023-05-23 10:17:57 -04:00
kitswas 62e6909629 Better messages and common logic 2023-05-23 17:36:38 +05:30
kitswas 99ba3f5fa7
Update app/src/ui/history/commit-list-item.tsx 
Co-authored-by: tidy-dev <75402236+tidy-dev@users.noreply.github.com>
 2023-05-23 16:27:12 +05:30
kitswas 2e9ac84dc9 Minor changes 2023-05-23 16:26:12 +05:30
kitswas b770552d0b Removed CheckoutCommitErrorContext 2023-05-23 16:25:45 +05:30
Sergio Padrino d1016cd03c
Merge pull request #16717 from desktop/floating-ui-autocomplete 
Reimplement Popover with floating-ui
 2023-05-23 11:09:41 +02:00
tidy-dev 636118cf16 Remove jumpiness of Git and Repo Git settings when misattributed warning is present 2023-05-22 14:19:33 -04:00
tidy-dev 3be0f6818d Pass loader in on repo settings too 2023-05-22 14:02:12 -04:00
tidy-dev 3aff9ae232 Don't default to showing "Other" while loading in git configs to lessen chance of jumpy screen 2023-05-22 13:53:58 -04:00
Sergio Padrino 186e4784a3 Popover cleanup 2023-05-22 19:27:18 +02:00
Sergio Padrino 4dee7e7971 Remove diff noise 2023-05-22 19:27:07 +02:00
Sergio Padrino c168323265 Allow setting a min height to Popovers 2023-05-22 19:16:32 +02:00
Sergio Padrino 106c9dc884 Use maxHeight in favor of defaultHeight 2023-05-22 19:02:54 +02:00
Sergio Padrino 2dff192299 Make popover point to the warning badge in avatars 2023-05-22 18:44:22 +02:00
kitswas 10f673f392 Use commitish for refreshAfterCheckout and ICheckoutProgress 2023-05-22 22:10:22 +05:30
Sergio Padrino fb54eaee72 Merge branch 'avatar-git-settings-popover' into floating-ui-autocomplete 2023-05-22 18:39:19 +02:00
tidy-dev 90c6c533a0 Fix merge error 2023-05-22 11:59:05 -04:00
kitswas 2dc77cb9dc Pinned the commit checkout feature behind a flag 2023-05-22 21:14:18 +05:30
Sergio Padrino 4a94e9e8ac Fix layout issues with autocomplete popups 2023-05-22 16:57:52 +02:00
Sergio Padrino d32fc10eb8 Replace caret height with constant used previously 2023-05-22 16:26:32 +02:00
tidy-dev 94f44ad5a4 Merge branch 'development' into pr/16120 2023-05-22 10:25:18 -04:00
tidy-dev 06843c0578 Different default for different popover sizes 2023-05-22 10:20:29 -04:00
tidy-dev bd1d2e86a4 Fix default height 2023-05-22 10:11:50 -04:00
Sergio Padrino 0cce0e66a8 Fix branch dropdown popover padding 2023-05-22 16:08:47 +02:00
Sergio Padrino 3ec94e65eb Fix other popover layout issues 2023-05-22 11:43:58 +02:00
Sergio Padrino 61749c7747 Fix overflow issue with CI popover 2023-05-22 11:34:26 +02:00
tidy-dev 119fa4e6e4 Position tweaking between misattributed and regular popover 2023-05-19 13:26:25 -04:00
tidy-dev ca8f48fe76 Remove double header 2023-05-19 13:09:13 -04:00
tidy-dev 0fa7f7d41c Merge branch 'development' into avatar-git-settings-popover 2023-05-19 12:49:35 -04:00
tidy-dev 1e3df9608a
Merge pull request #16714 from desktop/password-text-box 
Password Text Box Component
 2023-05-19 16:38:01 +00:00
tidy-dev 0ec45f04ea
Merge pull request #16698 from desktop/Announcing-login-page-transitions 
Welcome Flow Screens As Sections
 2023-05-19 16:35:27 +00:00
Sergio Padrino f000aa1f25 Use "no decoration" popover for autocomplete popup 2023-05-19 16:15:28 +02:00
Sergio Padrino 7561f25f5e Add new popover decoration prop 2023-05-19 15:53:45 +02:00
Sergio Padrino 0c2862ee4a Use a better zIndex value for popovers 2023-05-19 15:53:17 +02:00
Sergio Padrino 0720b6d3d4 Clean up popover.tsx 2023-05-18 19:07:40 +02:00
Sergio Padrino e53d283fd4 Remove stuff from intro popovers (which aren't a thing anymore) 2023-05-18 18:47:57 +02:00
Sergio Padrino 93d10dcfa7 Remove unnecessary lines 2023-05-18 18:45:26 +02:00
Sergio Padrino ef7254dd45 Improve documentation 2023-05-18 18:40:53 +02:00
Sergio Padrino a558400b88 Revert changes in AutocompletingTextInput 2023-05-18 18:30:08 +02:00
Sergio Padrino 0ee1406e72 Improve popover positioning 2023-05-18 18:13:34 +02:00
Sergio Padrino 56657994c3 Make popover dropdown use the new floating stuff too 2023-05-18 18:13:34 +02:00
Sergio Padrino f7ae32eec1 Clean Popover component up and rename things (use tip instead of caret) 2023-05-18 18:13:34 +02:00
Sergio Padrino 4058ccc1e7 Create custom middleware for proper caret/popover position 2023-05-18 18:13:34 +02:00
Sergio Padrino 91fdb22e3c Improve caret positioning 2023-05-18 18:13:34 +02:00
Sergio Padrino 1573db8160 Clean side-by-side-diff-row up 2023-05-18 18:13:34 +02:00
Sergio Padrino f6a877332c Fix whitespace hint popover in unified diff with CodeMirror 2023-05-18 18:13:34 +02:00
Sergio Padrino 6a346417a0 Fix popover issues in unified diff with side-by-side renderer 2023-05-18 18:13:34 +02:00
Sergio Padrino 7bed65b225 Fix popover layout glitches 2023-05-18 18:13:34 +02:00
Sergio Padrino 8f38d817ad More fixes for whitespace hint popover 2023-05-18 18:13:34 +02:00
Sergio Padrino 0bffb67da5 (WIP) Attempt to show whitespace hint popover with new floating implementation 2023-05-18 18:13:34 +02:00
Sergio Padrino c84b3231d7 Show diff-options popup from center of gear icon 2023-05-18 18:13:34 +02:00
Sergio Padrino cc862b47b7 Remove logs 2023-05-18 18:13:34 +02:00
Sergio Padrino 2969714fb2 Fix popover caret 2023-05-18 18:13:34 +02:00
Sergio Padrino ab3b313356 Dimension the commit avatar component correctly for proper popover positioning 2023-05-18 18:13:34 +02:00
Sergio Padrino 37b3fa94a3 Get the CI popover to position correctly 2023-05-18 18:13:34 +02:00
Sergio Padrino a60906cd3f (WIP) More work… 2023-05-18 18:13:34 +02:00
Sergio Padrino 3347414bb2 (WIP) Try to refactor Popover to be generic and use floating-ui 2023-05-18 18:13:34 +02:00
Sergio Padrino 9fe6f01226 (WIP) Use floating-ui to anchor the popup to the invisible caret 2023-05-18 18:13:34 +02:00
Sergio Padrino 5272b570f7 Render invisible caret we can anchor the popup to 2023-05-18 18:13:34 +02:00
Sergio Padrino d74049fddf Position autocomplete popup fixed 2023-05-18 18:13:34 +02:00
tidy-dev 93f9f1a1e8 Apply to commit-message-avatar 2023-05-18 18:13:34 +02:00
tidy-dev 0d926444c3 Import 2023-05-18 18:12:47 +02:00
tidy-dev 3be9a0ab51 Install package 2023-05-18 18:11:29 +02:00
tidy-dev 9117b3979e Merge branch 'development' into password-text-box 2023-05-18 09:02:16 -04:00
tidy-dev 55a7a3d4e2 Making so text doesn't overlap it. 2023-05-18 08:34:48 -04:00
tidy-dev 54df1a0fb2 Replace other password text boxes 2023-05-17 10:53:11 -04:00
tidy-dev a05f352af8 Use secondary text 2023-05-17 10:52:13 -04:00
tidy-dev 02c3dfa496 Add to Sign in dialog 2023-05-17 10:42:19 -04:00
tidy-dev e1f922a5a7 Use in authentication form 2023-05-17 10:29:15 -04:00
tidy-dev 8cba60c447 Add aria pressed 2023-05-17 10:29:00 -04:00
tidy-dev 738221a89d Use eye icon for button 2023-05-17 10:22:00 -04:00
tidy-dev de99ecdc5c Add password text box 2023-05-17 08:47:07 -04:00
tidy-dev a9fc363e08 Remove disables 2023-05-17 08:01:54 -04:00
tidy-dev f999db89d1 Merge branch 'development' into Announcing-login-page-transitions 2023-05-17 08:00:19 -04:00
tidy-dev 6f6b684398 Update configure-git-user.tsx 2023-05-17 08:00:16 -04:00
tidy-dev 3b178e1df7 Use autofocus on radio button 2023-05-17 07:59:40 -04:00
tidy-dev 10c3a76c53 Revert "Reuse first focusable element logic to focus an element on the configure git screen" 
This reverts commit 0b6a7e6a10.

more
 2023-05-17 07:58:30 -04:00
tidy-dev 9038512487 Focus sign in button first 2023-05-16 14:02:32 -04:00
tidy-dev 5ddaea898d Turn off/remove disables for jsx-a11y/no-autofocus 2023-05-16 13:11:07 -04:00
tidy-dev 0b6a7e6a10 Reuse first focusable element logic to focus an element on the configure git screen 2023-05-16 06:49:25 -04:00
tidy-dev 9404b26c57 Make each welcome flow page a section 2023-05-16 06:45:24 -04:00
tidy-dev 904187dd92 Remove document title as aria-live 2023-05-15 14:11:13 -04:00
tidy-dev a9e032328b Use Assertive 2023-05-15 10:08:10 -04:00
tidy-dev 05e6f3b66a Update document title and screen read title element 2023-05-15 09:47:53 -04:00
Markus Olsson 7ed2464fd4 Present unsupported OS banner once every 90 days 2023-05-12 13:20:44 +02:00
Markus Olsson fde09e42b9 Merge branch 'development' into one-windows-version-ought-to-be-enough-for-anybody 2023-05-12 10:04:04 +02:00
Sergio Padrino 09ef4f6f1b
Merge pull request #16684 from desktop/misattribued-avatar-using-position-fixed 
Use `position: fixed` to position the Misattributed Commit Popover
 2023-05-12 09:28:21 +02:00
Sergio Padrino 0f848d535c
Merge pull request #16651 from desktop/autocomplete-popup-portal 
Use `position: fixed` to render autocomplete popups
 2023-05-12 09:02:08 +02:00
tidy-dev bdef4af930 Position the misattributed avatar with position:fixed 2023-05-11 13:45:33 -04:00
tidy-dev cb4e5516df Reduce times this runs 
Evidently the user object gets replaced frequently so this is running many times based on the object reference changing. This reduces it to just on user name or email change
 2023-05-11 09:16:20 -04:00
tidy-dev 7e07ca862c Move git location check into avatar component 2023-05-11 09:05:25 -04:00
Sergio Padrino 5306569ebc Give the app a title 
Fixes a11y issue where focusable elements (document in this case) are supposed to have a name
 2023-05-10 12:21:21 +02:00
Sergio Padrino 44429be2eb
Merge pull request #16667 from desktop/fix-shortcut-key-warning 
Fix React warning about missing `key` for `KeyboardShortcut` children
 2023-05-10 09:50:13 +02:00
Sergio Padrino d50d5cab00
Merge pull request #16594 from samuelko123/bugfix-for-issue-13591 
Show remote branch name if it does not match local
 2023-05-09 13:17:55 +02:00
Sergio Padrino 39d2146e9c Add key to shortcut wrapper element 2023-05-09 12:37:50 +02:00
Sergio Padrino ba47423348 Use position: fixed to position the autocomplete popup 2023-05-09 10:59:05 +02:00
Sergio Padrino fc632bf3b5 Revert "Use portals to render autocomplete popups inside of the document's body" 
This reverts commit 1dc870e993.
 2023-05-09 10:58:26 +02:00
Sergio Padrino 202519544c Revert "Render autocomplete popup inside dialogs when needed" 
This reverts commit bff4d637d5.
 2023-05-09 10:58:22 +02:00
Sergio Padrino bff4d637d5 Render autocomplete popup inside dialogs when needed 2023-05-08 12:46:53 +02:00
Markus Olsson f37fd6b682 Fixed height dialog for repository preferencea 2023-05-08 09:38:24 +02:00
Markus Olsson 3a8fd7ba27
Merge pull request #16592 from desktop/ghes-avatars-is-the-bane-of-my-existence 
Reduce retries of avatars that fail to load
 2023-05-08 07:57:42 +02:00
digitalmaster cc690a649f Refactor files list to use shared onOpenInExternalEditor fn 
This refactor ensures that all double click event handlers bubble up to the same `onOpenInExternalEditor` fn in app.tsx.

This is where we prefix the repository path to the relative path which fixes a bug we caught where wrong files would open the opened project had a file at the same relative path (ie. README.md).
 2023-05-06 14:26:38 -07:00
Sergio Padrino 1dc870e993 Use portals to render autocomplete popups inside of the document's body 2023-05-05 18:11:35 +02:00
Sergio Padrino 36840c46a9
Merge pull request #16585 from samuelko123/bugfix-for-issue-16502 
Fix: Bottom controls do not stay inside window
 2023-05-05 11:42:52 +02:00
kitswas 2a7e80761e Formatted using prettier 
Ran `yarn prettier --write app/`.
 2023-05-05 10:01:40 +05:30
kitswas a44f4c502f Update app-state.ts 2023-05-05 09:12:50 +05:30
kitswas 21abac4ea1 Confirm before commit checkout 2023-05-05 01:01:14 +05:30
Sergio Padrino e9eaf23ab6
Merge pull request #16608 from desktop/autocomplete-a11y-fixes 
More Autocomplete accessibility improvements
 2023-05-04 13:57:07 +02:00
Jose Browne 477cd6c175 Wire up remaining views 2023-05-03 21:57:27 -04:00
Jose Browne 15bb130db8 Wire up commit history changes diff line numbers 2023-05-03 15:27:48 -04:00
tidy-dev 1eac35ec27 Fix property readonlyness 2023-05-03 15:15:28 -04:00
Jose Browne 944dcb6486 Add to changes diff line number 2023-05-03 14:55:57 -04:00
tidy-dev 23ced4a311 Update button text to be more accurate 2023-05-03 14:35:27 -04:00
tidy-dev 9eb7e47076 Aria label depending on if commit is misattributed 2023-05-03 14:34:25 -04:00
tidy-dev 19cb92e8c7 Add checking local/global config and buttons instead of links 2023-05-03 14:30:45 -04:00
tidy-dev 116f51f73c
Merge pull request #16638 from IgnazioGul/issue-16636 
Link to editor settings on the tutorial screen
 2023-05-03 17:42:05 +00:00
Sergio Padrino 6378888f30 Use createUniqueId instead of uuid 2023-05-03 18:18:06 +02:00