Commit graph

27397 commits

Author SHA1 Message Date
tidy-dev ba40b2b255
Merge pull request #16773 from desktop/readonly-text-box
Improve accessibility of the username textbox in "Configure Git" screen
2023-05-25 16:30:40 +00:00
Sergio Padrino 44b24b9918
Merge pull request #16781 from desktop/repository-list-expanded
Add `aria-expanded` to dropdowns and "Add repository" button
2023-05-25 16:48:14 +02:00
tidy-dev cadfc10489
Merge pull request #16774 from desktop/Announce-let-gets-started-when-not-signed-in
Announce "Let's get started!" when not signed in
2023-05-25 12:32:29 +00:00
Sergio Padrino 60c49e60a0 For "multi-option" dropdowns, set aria-expanded in the arrow button 2023-05-25 11:43:35 +02:00
Sergio Padrino e10e35a3cb Add ariaExpanded to "Add" button in repository list 2023-05-25 11:34:31 +02:00
Sergio Padrino 5db5095827 Set ariaExpanded attribute to toolbar dropdown button instead of container 2023-05-25 11:34:03 +02:00
Markus Olsson e2a70001b0
Merge pull request #16772 from desktop/lets-get-these-crashes-started
Send uncaught errors to the non-fatal bucket
2023-05-25 10:05:51 +02:00
Sergio Padrino f726f74ba8 Make sure readonly textboxes look like disabled ones 2023-05-24 17:23:08 +02:00
Sergio Padrino 0182d0c9cb Turn "Configure Git" username's textbox readonly instead of disabled 2023-05-24 17:22:52 +02:00
Sergio Padrino 1dfaa01654 Add explicit type="text" attribute to textboxes
This will prevent some issues/reports from accessibility tools.
2023-05-24 17:22:31 +02:00
tidy-dev 08afa55216 Remove buttons from list that prevents section announcement 2023-05-24 10:59:26 -04:00
tidy-dev 2858790930 Auto focus first button when no repo list 2023-05-24 10:59:08 -04:00
Markus Olsson 758360de96 Send uncaught errors to the non fatal bucket 2023-05-24 15:54:43 +02:00
tidy-dev e9900ad8bb
Merge pull request #16765 from desktop/aria-label-fix
Fix aria label that was messed up in merge conflict resolution
2023-05-24 13:53:30 +00:00
Sergio Padrino 2f8710e448
Merge pull request #16759 from desktop/refactor-popover-dropdown
Refactor `PopoverDropdown` to rely on the new `Popover` to calculate the available height
2023-05-24 15:22:09 +02:00
tidy-dev 6b100b328b Fix aria label that was messed up in merge conflict resoltionflict r 2023-05-24 05:34:52 -04:00
tidy-dev 7cab24e356 Refactor branch list context menu callback to the list item 2023-05-23 11:37:07 -04:00
Sergio Padrino 7ccdb16f45 Remove height logic from popover dropdown 2023-05-23 16:41:17 +02:00
tidy-dev 6b7dfb3a38 Move context menu invokation to out list container 2023-05-23 10:17:57 -04:00
Sergio Padrino d1016cd03c
Merge pull request #16717 from desktop/floating-ui-autocomplete
Reimplement Popover with floating-ui
2023-05-23 11:09:41 +02:00
tidy-dev 636118cf16 Remove jumpiness of Git and Repo Git settings when misattributed warning is present 2023-05-22 14:19:33 -04:00
tidy-dev 3be0f6818d Pass loader in on repo settings too 2023-05-22 14:02:12 -04:00
tidy-dev 3aff9ae232 Don't default to showing "Other" while loading in git configs to lessen chance of jumpy screen 2023-05-22 13:53:58 -04:00
Sergio Padrino 186e4784a3 Popover cleanup 2023-05-22 19:27:18 +02:00
Sergio Padrino 4dee7e7971 Remove diff noise 2023-05-22 19:27:07 +02:00
Sergio Padrino c168323265 Allow setting a min height to Popovers 2023-05-22 19:16:32 +02:00
Sergio Padrino 106c9dc884 Use maxHeight in favor of defaultHeight 2023-05-22 19:02:54 +02:00
Sergio Padrino 2dff192299 Make popover point to the warning badge in avatars 2023-05-22 18:44:22 +02:00
Sergio Padrino fb54eaee72 Merge branch 'avatar-git-settings-popover' into floating-ui-autocomplete 2023-05-22 18:39:19 +02:00
Sergio Padrino 4a94e9e8ac Fix layout issues with autocomplete popups 2023-05-22 16:57:52 +02:00
Sergio Padrino d32fc10eb8 Replace caret height with constant used previously 2023-05-22 16:26:32 +02:00
tidy-dev 06843c0578 Different default for different popover sizes 2023-05-22 10:20:29 -04:00
tidy-dev bd1d2e86a4 Fix default height 2023-05-22 10:11:50 -04:00
Sergio Padrino 0cce0e66a8 Fix branch dropdown popover padding 2023-05-22 16:08:47 +02:00
Sergio Padrino 3ec94e65eb Fix other popover layout issues 2023-05-22 11:43:58 +02:00
Sergio Padrino 61749c7747 Fix overflow issue with CI popover 2023-05-22 11:34:26 +02:00
tidy-dev 119fa4e6e4 Position tweaking between misattributed and regular popover 2023-05-19 13:26:25 -04:00
tidy-dev ca8f48fe76 Remove double header 2023-05-19 13:09:13 -04:00
tidy-dev 0fa7f7d41c Merge branch 'development' into avatar-git-settings-popover 2023-05-19 12:49:35 -04:00
tidy-dev 1e3df9608a
Merge pull request #16714 from desktop/password-text-box
Password Text Box Component
2023-05-19 16:38:01 +00:00
tidy-dev 0ec45f04ea
Merge pull request #16698 from desktop/Announcing-login-page-transitions
Welcome Flow Screens As Sections
2023-05-19 16:35:27 +00:00
Sergio Padrino f000aa1f25 Use "no decoration" popover for autocomplete popup 2023-05-19 16:15:28 +02:00
Sergio Padrino 7561f25f5e Add new popover decoration prop 2023-05-19 15:53:45 +02:00
Sergio Padrino 0c2862ee4a Use a better zIndex value for popovers 2023-05-19 15:53:17 +02:00
Sergio Padrino 0720b6d3d4 Clean up popover.tsx 2023-05-18 19:07:40 +02:00
Sergio Padrino e53d283fd4 Remove stuff from intro popovers (which aren't a thing anymore) 2023-05-18 18:47:57 +02:00
Sergio Padrino 93d10dcfa7 Remove unnecessary lines 2023-05-18 18:45:26 +02:00
Sergio Padrino ef7254dd45 Improve documentation 2023-05-18 18:40:53 +02:00
Sergio Padrino a558400b88 Revert changes in AutocompletingTextInput 2023-05-18 18:30:08 +02:00
Sergio Padrino 0ee1406e72 Improve popover positioning 2023-05-18 18:13:34 +02:00