development/github-desktop
development/github-desktop
1
0
Fork 0
mirror of https://github.com/desktop/desktop synced 2024-09-18 07:32:01 +00:00
Code Issues Packages Projects Releases Wiki Activity
36191 commits 301 branches 696 tags 363 MiB
Commit graph

28928 commits

Author SHA1 Message Date
Sergio Padrino 43a30b211d Replace br with margin-top for force-push warning in push/pull/fetch dropdown 2024-04-10 13:35:40 +02:00
Sergio Padrino f0ec33f5b7 Use p instead of br for large text diffs 2024-04-10 13:31:05 +02:00
tidy-dev c355c442bb Switch to overflow on the dialog content 2024-04-09 11:56:49 -04:00
Sergio Padrino 6811a64d61 Replace br with paragraphs in "delete branch" dialog 2024-04-09 16:02:45 +02:00
Sergio Padrino 0ba1e7210e Replace br with paragraphs in "delete remote branch" dialog 2024-04-09 16:02:38 +02:00
Sergio Padrino b7a83e908b Replace br with paragraphs 2024-04-09 14:57:32 +02:00
tidy-dev 1ad27493d9
Gap next to avatar 
Co-authored-by: Sergio Padrino <sergio.padrino@gmail.com>
 2024-04-09 07:14:48 -04:00
tidy-dev 66e18dc4d5 Release 3.3.14-beta2 2024-04-05 09:51:15 -04:00
tidy-dev 1a151c9347
Merge pull request #18414 from desktop/releases/3.3.14-beta1 
Release 3.3.14-beta1
 2024-04-05 13:42:16 +00:00
tidy-dev 2509580a7d
Merge pull request #18408 from desktop/tab-semantics- 
Tab semantics of Publish and Clone Dialogs
 2024-04-05 13:41:55 +00:00
tidy-dev 3f63e4796f
Merge pull request #18415 from desktop/force-push-warning-contrast 
Make force push toolbar button warning have 4.5:1 contrast
 2024-04-05 13:33:59 +00:00
tidy-dev df5a4b1161 Clear cache when text diff changes 2024-04-05 08:34:02 -04:00
tidy-dev df685a8b47 Update _dark.scss 2024-04-05 08:03:41 -04:00
tidy-dev 880cc6534c Update tool bar warning color to meet 4.5:1 contrast 2024-04-04 15:22:45 -04:00
tidy-dev b2983b9fa1 Release 3.3.14-beta1 2024-04-04 12:06:50 -04:00
tidy-dev 08a51bca19 Better manage accounts tab in settings when zoomed 2024-04-04 11:54:20 -04:00
tidy-dev 35d1b05566 Update _open-pull-request.scss 
Tweak Pull Request Dialog when zoomed
 2024-04-04 11:27:07 -04:00
tidy-dev 06e956f368 Make it important to ensure overriding regular screen size width/heights 2024-04-04 10:20:00 -04:00
Sergio Padrino 1baf14d122 Removed unnecessary reference to FilterList in BranchList 2024-04-04 15:53:22 +02:00
tidy-dev 29d5fd5d77
Merge pull request #18404 from desktop/warning-message-announcements 
Create Branch and Create Repository warning message announcements
 2024-04-04 13:20:17 +00:00
tidy-dev 578634b7f3 Apply zoom overflow media queries to all dialogs 2024-04-04 09:09:37 -04:00
tidy-dev 6fcadb0504
Merge pull request #18406 from desktop/small-images-shouldn't-be-too-small 
Only don't use max size on two-up for small images
 2024-04-04 12:24:44 +00:00
Sergio Padrino 9a7290f446
Merge pull request #18397 from desktop/pr-section-filter-list 
Use `SectionFilterList` for the Pull Request list
 2024-04-03 22:27:05 +02:00
tidy-dev 2a6afe57e8 Add tab semantics to clone repository dialog 2024-04-03 16:03:15 -04:00
tidy-dev 20e2499622 Add tab semantics to publish repository repo 2024-04-03 15:55:13 -04:00
tidy-dev 48e1229cf3 Only don't use max size on two-up for small images 2024-04-03 13:18:35 -04:00
tidy-dev 1132ae0f12
Merge pull request #18394 from desktop/releases/3.3.13 
Release 3.3.13
 2024-04-03 17:13:18 +00:00
tidy-dev 23f21442a8 Make the announcement between aria-live and aria-describedby consistent 2024-04-03 12:44:12 -04:00
tidy-dev 8884ed3f1f No console logs pls 2024-04-03 10:59:27 -04:00
tidy-dev da84c5cc30 Use input warning for repository sanitized name 2024-04-03 10:49:09 -04:00
tidy-dev 807eab41ac Use error for invalid branch name input and associate with aria-describedby 2024-04-03 10:41:05 -04:00
Markus Olsson 3f72f7482d
Merge pull request #18364 from couleurm/patch-1 
add VapourSynth script files (.vpy) to test/x-python
 2024-04-03 15:58:46 +02:00
Kyle 7be2c352a2
Merge branch 'development' into development 2024-04-02 14:53:08 -04:00
Sergio Padrino 5243a4a97b
Merge pull request #18333 from say25/isOSNoLongerSupportedByElectron 
Create Function to Unify isOSNoLongerSupportedByElectron
 2024-04-02 18:51:31 +02:00
Sergio Padrino c6e159a785 Remove enableSectionList 2024-04-02 18:30:26 +02:00
Sergio Padrino 946c49076e Remove enableSectionList usage from RepositoriesList 2024-04-02 18:30:19 +02:00
Sergio Padrino ec61149978 Remove enableSectionList usage from CloneableRepositoryFilterList 2024-04-02 18:29:58 +02:00
Sergio Padrino 054beaf29e Remove enableSectionList usage from BranchList 2024-04-02 18:29:43 +02:00
Sergio Padrino 18ef628a36 Use SectionFilterList for the Pull Request list 2024-04-02 17:44:38 +02:00
tidy-dev 097ad25aa3 Release 3.3.13 2024-04-01 12:11:34 -04:00
Sergio Padrino 778ab78ea5 Turn DiscardChanges into an alertdialog 2024-03-27 13:50:01 +01:00
Sergio Padrino 9ead1f4dc4 Turn WarnForcePushDialog into an alertdialog 2024-03-27 13:43:53 +01:00
Couleur c9811024fd
add VapourSynth script files (.vpy) to test/x-python 
it is common practice to use .vpy instead of .py scripts when making scripts with the module https://github.com/vapoursynth/vapoursynth
 2024-03-26 10:34:25 +01:00
Steven Yeh b7fac1ce5b
Update app/src/lib/get-os.ts 
Co-authored-by: Sergio Padrino <sergiou87@github.com>
 2024-03-24 22:05:37 -05:00
tidy-dev aab5b5599a
Merge pull request #18341 from desktop/fix-input-focus-grap-in-configure-git-form 
Refactor welcome flow configure git from so that autofocus doesn't interrupt the screenreader
 2024-03-22 17:34:27 +00:00
tidy-dev c4ffafa1e7 Use text colors not opacity for tutorial steps to ensure proper contrast 2024-03-22 10:42:44 -04:00
tidy-dev 245d511383 Refactor so that autofocus input is always present 2024-03-22 10:18:39 -04:00
Sergio Padrino 9744b90f5b
Merge pull request #18335 from desktop/dialog-close-a11y-improvements 
Dialog closing accessibility improvements
 2024-03-22 14:30:56 +01:00
Steven Yeh 1c27790ef1 Update get-os.ts 2024-03-21 10:47:49 -05:00
Sergio Padrino 6457bddb23 Improve DialogHeader documentation 2024-03-21 16:44:34 +01:00
Sergio Padrino d1586aa6a4 Update DiscardSelection dialog to use dismissDisabled instead 2024-03-21 16:38:22 +01:00
Sergio Padrino c20619c8ce Update DiscardChanges dialog to use dismissDisabled instead 2024-03-21 16:38:13 +01:00
Sergio Padrino 825fd3045e Clean up OpenPullRequestDialogHeader 2024-03-21 16:38:01 +01:00
Sergio Padrino d20fbf6591 Update ConflictsDialog dialog to use dismissDisabled instead 2024-03-21 16:37:31 +01:00
Sergio Padrino 1860a82b32 Update CreateForkDialog dialog to use dismissDisabled instead 2024-03-21 16:37:19 +01:00
Sergio Padrino e928f428bf Update ProgressDialog dialog to use dismissDisabled instead 2024-03-21 16:36:06 +01:00
Sergio Padrino 0b654639c7 Update WarnForcePushDialog dialog to use backdropDismissable instead 2024-03-21 16:35:48 +01:00
Sergio Padrino ff2cf31e7d Update CreateTutorialRepositoryDialog dialog to use dismissDisabled instead 2024-03-21 16:35:31 +01:00
Sergio Padrino 26cf2bacd9 Update PushNeedsPullWarning dialog to use dismissDisabled instead 2024-03-21 16:35:09 +01:00
Sergio Padrino 4a2fd09be4 Update ConfirmForcePush dialog to use dismissDisabled instead 2024-03-21 16:34:40 +01:00
Sergio Padrino a779bc7e9f Update ConfirmRemoveRepository dialog to use dismissDisabled instead 2024-03-21 16:34:27 +01:00
Sergio Padrino a20f28fe7b Fix layout issue in PullRequestChecksFailed dialog 2024-03-21 16:15:43 +01:00
Sergio Padrino cb16d73600 Clean up TestNotifications dialog 2024-03-21 16:15:29 +01:00
Sergio Padrino 31645c4ad3 Update SSHUserPassword dialog to use backdropDismissable instead 2024-03-21 16:15:15 +01:00
Sergio Padrino 8245f2ed93 Update AddSSHHost dialog to use backdropDismissable instead 2024-03-21 16:14:49 +01:00
Sergio Padrino 1c4fcf1570 Update SSHKeyPassphrase dialog to use backdropDismissable instead 2024-03-21 16:12:26 +01:00
Sergio Padrino 120c410dfe Update PullRequestCommentLike dialog to use backdropDismissable instead 2024-03-21 16:07:09 +01:00
Sergio Padrino d9514b6c12 Update PullRequestChecksFailed dialog to use backdropDismissable instead 2024-03-21 16:06:04 +01:00
Sergio Padrino 10137dc182 Update MoveToApplicationsFolder dialog to use backdropDismissable instead 2024-03-21 16:04:34 +01:00
Sergio Padrino af4273c262 Update InitializeLFS dialog to use backdropDismissable instead 2024-03-21 16:03:59 +01:00
Sergio Padrino 8f460f5985 Update InstallingUpdate dialog to use backdropDismissable instead 2024-03-21 16:03:00 +01:00
Sergio Padrino ba4a71ce93 Update AppError dialog to use backdropDismissable instead 2024-03-21 16:02:18 +01:00
Sergio Padrino bc6c2b1778 Refactor Dialog and DialogHeader to increase control over how dialogs can be dismissed 2024-03-21 16:00:38 +01:00
Sergio Padrino 57aca943c6 Remove unnecessary props 2024-03-21 14:39:03 +01:00
Steven Yeh 666c5b56c8
CR Feedback 2024-03-20 16:00:00 -05:00
Steven Yeh f1fac89098 Linter 2024-03-20 12:02:00 -05:00
Steven Yeh 0223334896 Create Function to Unify isOSNoLongerSupportedByElectron 2024-03-20 11:49:13 -05:00
tidy-dev 58d5450360 Release 3.3.13-beta1 2024-03-20 09:23:14 -04:00
Sergio Padrino a4c55c6487
Merge pull request #18313 from desktop/fix-small-image-diff 
Fix image diff when images are too small
 2024-03-20 12:48:46 +01:00
Sergio Padrino bdfc887dac
Merge pull request #18314 from desktop/fix-popover-escape 
Close "Show whitespace changes?" popover when pressing Escape
 2024-03-20 12:48:27 +01:00
tidy-dev 2ac5f72c51 Merge branch 'development' into releases/3.3.12 2024-03-20 07:29:58 -04:00
tidy-dev a21e55b38e Release 3.3.12 2024-03-19 15:15:26 -04:00
Sergio Padrino 1d06670fd5 Merge pull request #18320 from desktop/prevent-upgrade-on-old-macos 
Prevent upgrading from macOS 10.13 and 10.14
 2024-03-19 14:57:47 -04:00
tidy-dev cbf184fed2 Merge pull request #18319 from desktop/banners-sticky-by-default 
Make banners sticky by default.
 2024-03-19 14:57:47 -04:00
Sergio Padrino 7b99fc73b9 Bump changelog and version to 3.3.12-beta3 2024-03-19 15:42:07 +01:00
Sergio Padrino 2e6e91b511
Merge pull request #18320 from desktop/prevent-upgrade-on-old-macos 
Prevent upgrading from macOS 10.13 and 10.14
 2024-03-19 13:40:28 +01:00
tidy-dev df7513c45e don't timeout if not provided 2024-03-19 08:13:36 -04:00
Sergio Padrino cbe70b8069 Check for unsupported macOS versions 2024-03-19 12:14:47 +01:00
Sergio Padrino bdb7ecb1a9 Rename unsupported OS banner/dialog 2024-03-19 12:14:10 +01:00
Jose Cortinas 0a97e3d5f2
Merge pull request #18306 from desktop/jc-diff-search-voiceover 
Add voiceover support for diff search
 2024-03-18 14:24:36 -05:00
Sergio Padrino 5d47974740 In Popovers, also use onMousedownOutside as onDeactivate for the Focus Trap 2024-03-18 16:02:42 +01:00
Sergio Padrino 97372b72e3 Don't set a max-width for very small images in diffs 2024-03-18 15:13:14 +01:00
Jose Cortinas 8c52cd4c4f Use a better name 2024-03-15 13:07:58 -05:00
Jose Cortinas 6cdbde9e75 A little bit cleaner 2024-03-15 12:36:58 -05:00
Jose Cortinas 0a01bddc1f Add Aria live container and refactor search 2024-03-15 12:32:36 -05:00
Sergio Padrino 97ae1d2600 Use width of checkmark as padding 2024-03-15 16:19:33 +01:00
tidy-dev 0cc10035d1 Release 3.3.12-beta2 2024-03-14 12:58:28 -04:00
Sergio Padrino 0bd0fe5a1c
Merge pull request #18292 from desktop/bump-dugite-to-2.6.0 
Bump git to 2.43.x and git LFS to 3.5.1
 2024-03-14 17:46:28 +01:00
Sergio Padrino 2c55f926ae Leverage new API from dugite v2.6.1 2024-03-14 17:23:08 +01:00
Sergio Padrino 69ec9a47a1 Bump dugite to v2.6.1 2024-03-14 17:22:50 +01:00
tidy-dev 222600b7f0
Merge pull request #18276 from desktop/pull-request-list-keyboard-accessible 
Make  the pull request check runs popover list keyboard accessible
 2024-03-14 15:54:06 +00:00
tidy-dev f1bfabce12 Button hover styles to indicate it is clickable 2024-03-13 16:42:05 -04:00
tidy-dev 3436897054 Keep selected state styling for failed dialog 2024-03-13 16:12:16 -04:00
tidy-dev 9e613d3a9a Make step list header reusable for failed checks dialog 2024-03-13 16:03:03 -04:00
tidy-dev 9d236a0cbf Make reusable component for no steps 2024-03-13 15:27:59 -04:00
tidy-dev 87349453c9 Tidying up css/html of ci checks popover 2024-03-13 14:58:00 -04:00
tidy-dev 00abd76bf0 Make the checks and steps summary use same logic 
Fixes the sentence logic so that no comma between two statuses
 2024-03-13 12:13:16 -04:00
Sergio Padrino 329b6c2e93
Merge pull request #18096 from lhvy/alacritty 
Add support for multiple macOS shell bundle IDs
 2024-03-13 15:37:50 +01:00
tidy-dev 109e514608 Use secondary color for steps header 2024-03-12 17:18:48 -04:00
tidy-dev 87d4013dc6 Tidying: Moved region rendering into method for easier reading 2024-03-12 17:17:19 -04:00
tidy-dev 54ed6f7d47 Tidying: Removing unused stuff from other iterations 2024-03-12 17:15:13 -04:00
tidy-dev 6ed6dcf13e No steps message 2024-03-12 17:10:15 -04:00
tidy-dev 17d4a3e353 Use a summary for the header 2024-03-12 17:04:31 -04:00
tidy-dev 9741fcd2ff Show the chevron on the right end 2024-03-12 17:03:48 -04:00
tidy-dev 75078fe051 No more disabled buttons 2024-03-12 17:03:31 -04:00
tidy-dev db972d7abd Add expanded area header 2024-03-12 16:08:09 -04:00
tidy-dev edc5d2610f Stop using list item since not a navigable list 2024-03-12 16:07:55 -04:00
tidy-dev 4482d6d5a7 Remove job step toggle placeholder 2024-03-12 16:06:32 -04:00
Sergio Padrino 29f5038ac5 Don't use ! with nullable numeric values 2024-03-12 16:39:50 +01:00
Sergio Padrino 5510f30310 Show a human error description for dugite's BadConfigValue 2024-03-12 16:39:23 +01:00
Sergio Padrino 28e46d08b0 Bump dugite to v2.6.0 2024-03-11 18:09:19 +01:00
tidy-dev 752a5d4a0b Semantically associate the controls for screen reader users 2024-03-11 08:48:35 -04:00
tidy-dev 40a704d1ea Make rerun dialog headers semantics accurate 2024-03-11 08:34:14 -04:00
tidy-dev ac84234a3c Update pr checks failed dialog match 2024-03-11 08:19:42 -04:00
tidy-dev 9acdbbd15d Make row buttons labels specific 2024-03-11 07:13:05 -04:00
tidy-dev 84fceb2911 Only use button for clickable rows 2024-03-11 07:12:50 -04:00
tidy-dev 73edaec737 Add view externally icon to jobs steps 2024-03-11 07:04:16 -04:00
Lucas bdb2195e49
Refactor macOS shell integration and update docs 2024-03-09 12:13:23 +11:00
tidy-dev 04e95323fb Fix "commented your pr" to "commented on your pr" 2024-03-08 20:04:53 -05:00
tidy-dev 78fa283e35 Add aria labeling to our markdown iframes 2024-03-08 20:04:37 -05:00
tidy-dev 848cf40296 Make the steps be links 2024-03-08 13:26:48 -05:00
tidy-dev 86e95f7176 Make check run headers semantic headers 2024-03-08 13:26:48 -05:00
tidy-dev 3b8ca658a5 Make check runs keyboard accessible 2024-03-08 12:52:03 -05:00
tidy-dev 2084ffb529 Make group headers semantic headers 2024-03-08 10:56:51 -05:00
tidy-dev 7dbcde8de6 Make header an H1 semantically 2024-03-08 10:48:47 -05:00
tidy-dev f97aced2ba
Merge pull request #18268 from desktop/pull-request-checks-keyboard-accessible 
Make the PR Badge into a button component
 2024-03-08 07:42:41 -05:00
tidy-dev d73f874563 Make the pr-badge into a button component 2024-03-07 12:05:44 -05:00
tidy-dev dac4732eff Release 3.3.12-beta1 2024-03-07 10:37:09 -05:00
tidy-dev a286b76eea Update package.json 2024-03-07 10:16:32 -05:00
tidy-dev d56de65796 Merge branch 'development' into releases/3.3.11 2024-03-07 10:15:37 -05:00
tidy-dev 1aa5f70ede
Merge pull request #18232 from desktop/diff-checkall-logic-iteration 
Diff check all logic iteration.
 2024-03-07 09:51:31 -05:00
tidy-dev edef39b81b Release 3.3.11 2024-03-07 09:24:53 -05:00
tidy-dev 7c3bd1af59 Hidden elements like hunk handle labeling and checkbox inputs should not be text selectable 
Update _side-by-side-diff.scss
 2024-03-07 09:24:53 -05:00
tidy-dev e47db33b13 Anything sr-only should not be selectable in the diff 2024-03-07 09:21:29 -05:00
tidy-dev 26b0bd8523 Make hunk handle and children not part of the selection 2024-03-07 09:08:15 -05:00
tidy-dev e508c4f096 Hidden checkbox inputs should not be text selectable 2024-03-07 07:56:49 -05:00
tidy-dev d312af7503 Make hunk handle and children always use cursor pointer 2024-03-07 07:37:02 -05:00
tidy-dev 11fc806ec8
Update app/src/ui/diff/diff-helpers.tsx 
Co-authored-by: Sergio Padrino <sergio.padrino@gmail.com>
 2024-03-06 11:10:08 -05:00
Jose Cortinas ff7237082b
Merge pull request #18207 from desktop/jc-icon-preview-dialog 
Icon preview dialog
 2024-03-05 10:42:38 -06:00
Jose Cortinas ca5b9ac880
Merge pull request #18245 from desktop/jc-tutorial-button-role 
Add link role to the "Open pull request" button in tutorial sidebar
 2024-03-05 10:27:09 -06:00