Commit graph

35685 commits

Author SHA1 Message Date
tidy-dev
1a25e3d701 Tweaking for non desriptions views 2023-11-28 12:14:13 -05:00
tidy-dev
6092dfa7ad Merge branch 'development' into niik/commit-message-scroll-all-the-time 2023-11-28 11:46:55 -05:00
tidy-dev
51ec6c266f
Merge pull request #17741 from desktop/address-17687-feedback
Conflicts Resolutions Banner: Explain Null vs 0
2023-11-28 09:19:09 -05:00
tidy-dev
deff7250ba
Merge pull request #17748 from desktop/releases/3.3.6-beta3
Release 3.3.6-beta3
2023-11-22 15:09:03 +00:00
tidy-dev
1019dd9f9b Merge branch 'development' into releases/3.3.6-beta3 2023-11-20 09:29:50 -05:00
tidy-dev
43cc52ab50
Merge pull request #17733 from desktop/improve-reorder-commits-hint
Improve reorder commits hint
2023-11-20 14:28:45 +00:00
tidy-dev
ed35b6d64c Update changelog.json 2023-11-20 08:44:51 -05:00
tidy-dev
93af2389b1 Merge branch 'development' into releases/3.3.6-beta3 2023-11-20 08:42:52 -05:00
Jose Cortinas
b964c200eb
Merge pull request #17705 from desktop/jc-banner-improvements
Improve NVDA screen reader support for banners
2023-11-20 07:40:26 -06:00
tidy-dev
7a9d51fca5 Release 3.3.6-beta3 2023-11-20 08:21:49 -05:00
Markus Olsson
bfd116b492
Merge pull request #17698 from desktop/preferences-tweaks
Preferences tweaks
2023-11-20 13:46:40 +01:00
tidy-dev
a912ffcb16 Explain Null vs 0 2023-11-17 07:18:20 -05:00
tidy-dev
dbd02dedab
Merge pull request #17687 from desktop/conflict-resolution-announcements
Conflict resolution announcements
2023-11-17 12:13:28 +00:00
Markus Olsson
8a60f18669
Merge pull request #17660 from desktop/seleeeeeeeeect
Make text selectable in all child elements of diff
2023-11-17 11:04:31 +01:00
Markus Olsson
c477e523a2
Merge pull request #17734 from desktop/kind-kindness
Strongly typed exception kinds
2023-11-17 11:03:46 +01:00
Sergio Padrino
a8d4bf71e2 Merge branch 'development' into improve-reorder-commits-hint 2023-11-16 15:50:44 +01:00
Sergio Padrino
5200f1ab7c
Merge pull request #17671 from desktop/reorder-with-keyboard
Make commit reordering keyboard accessible
2023-11-16 15:50:00 +01:00
Markus Olsson
06ea679a9d Strongly type existing exception kinds 2023-11-16 14:18:47 +01:00
Markus Olsson
7720b2416c Fix free-form exception kind 2023-11-16 14:18:16 +01:00
Sergio Padrino
05e8517f02 Extract hint to a function and improve verbiage
Co-Authored-By: tidy-dev <75402236+tidy-dev@users.noreply.github.com>
2023-11-16 13:13:33 +01:00
Sergio Padrino
3bb37beea8 Improve styling of reorder commits hint
Co-Authored-By: tidy-dev <75402236+tidy-dev@users.noreply.github.com>
2023-11-16 13:13:07 +01:00
Sergio Padrino
4d5c419a5d Allow removing dialog semantics from popovers 2023-11-16 12:52:47 +01:00
Sergio Padrino
f99f93988c Allow setting an anchor offset to popovers 2023-11-16 12:47:53 +01:00
tidy-dev
59aebeae8e Update commit-list.tsx 2023-11-13 09:51:45 -05:00
Sergio Padrino
c3594db2d7 Show popover with usage hint in keyboard reordering mode 2023-11-10 09:16:56 +01:00
Sergio Padrino
3e441579f3 Reuse one of our well-known z-index constants
Co-Authored-By: Markus Olsson <634063+niik@users.noreply.github.com>
2023-11-10 09:16:25 +01:00
Sergio Padrino
ad7003a91f
Update app/src/ui/lib/list/list.tsx
Co-authored-by: Markus Olsson <j.markus.olsson@gmail.com>
2023-11-10 09:14:28 +01:00
Sergio Padrino
8130c85848
Update app/src/ui/lib/list/list.tsx
Co-authored-by: Markus Olsson <j.markus.olsson@gmail.com>
2023-11-10 09:14:20 +01:00
Sergio Padrino
9d30cddb79
Update app/src/ui/history/commit-list.tsx
Co-authored-by: Markus Olsson <j.markus.olsson@gmail.com>
2023-11-10 09:13:55 +01:00
tidy-dev
eddb95470b Make zoomed in mode work 2023-11-09 14:03:50 -05:00
Jose Cortinas
488650b156 Run prettier 2023-11-09 12:28:28 -06:00
tidy-dev
67569b9a97
Merge pull request #17706 from desktop/commit-expansion-tweaks
Remove duplicate aria announcement of button labelling
2023-11-09 18:22:43 +00:00
tidy-dev
5414da1483 Remove duplicate aria announcement of button labelling 2023-11-09 12:52:50 -05:00
Markus Olsson
e075b7d975 Don't make the expander selectable 2023-11-09 15:22:46 +01:00
Markus Olsson
d9d3814cdd Show the description and have it be scrollable all the time 2023-11-09 15:21:09 +01:00
Markus Olsson
e323f80bd3 Fix jumpiness thanks to show commit message warning height 2023-11-08 15:11:11 +01:00
Markus Olsson
182a1e8d31 p elements can't be nested 2023-11-08 15:10:15 +01:00
Markus Olsson
1062d02193 🎨 Typo 2023-11-08 15:09:57 +01:00
Markus Olsson
92aa935481
Merge pull request #17697 from WilliamDavidHarrison/patch-1
feat: `Github` -> `GitHub`
2023-11-08 15:03:32 +01:00
William Harrison
a0c2a12e4e
feat: Github -> GitHub 2023-11-08 18:42:37 +08:00
Jose Cortinas
5321e0cc12 Move role and aria-atomic attributes higher in DOM 2023-11-07 15:34:52 -06:00
Jose Cortinas
89f26a8009 Add menu item for merge successful banner 2023-11-07 15:34:52 -06:00
Sergio Padrino
13ed8d57dd Always render aria live container for reordering message
For some reason, NVDA doesn't like "optional rendering" for this element, otherwise it doesn't read the message when the element is added
2023-11-07 11:26:30 +01:00
tidy-dev
36aa3a045f No conflicted files message 2023-11-06 11:50:45 -05:00
tidy-dev
f90e6f536d Remove unused css 2023-11-06 11:43:27 -05:00
tidy-dev
d85f11bf80 Remove console log 2023-11-06 11:42:28 -05:00
tidy-dev
6475d6b12c better banner function name 2023-11-06 11:41:43 -05:00
tidy-dev
926227fa29 Delete info.tsx 2023-11-06 11:38:54 -05:00
tidy-dev
c29fe78483 Make a DialogSuccess like our DialogError component 2023-11-06 11:35:03 -05:00
Markus Olsson
914dfd009c Align select-all copy with .com
Include hunk headers when selecting entire diff
2023-11-06 14:43:51 +01:00