development/github-desktop
development/github-desktop
1
0
Fork 0
mirror of https://github.com/desktop/desktop synced 2024-10-31 11:07:25 +00:00
Code Issues Projects Releases Packages Wiki Activity
35020 commits 304 branches 713 tags 371 MiB
Commit graph

817 commits

Author SHA1 Message Date
Markus Olsson
573ae7b61f Try getting the actual failure position 2020-07-09 22:43:11 +02:00
Markus Olsson
29c3dcd195 Get rid of debug log 2020-07-09 20:39:38 +02:00
Markus Olsson
ac0eb1d166 omg 2020-07-09 20:31:57 +02:00
Markus Olsson
b01b903adb Debug forever 2020-07-09 20:15:20 +02:00
Markus Olsson
a5a409f9f7 We don't have jest-unit any more 2020-07-09 20:10:43 +02:00
Markus Olsson
d652608f35 Test reporting test errors 2020-07-09 19:28:28 +02:00
Markus Olsson
c30863134f GitHub Actions can build on darwin as well 2020-07-09 14:17:24 +02:00
Markus Olsson
4d10b0d0df We can build on Windows on GH actions as well 2020-07-09 14:09:09 +02:00
Markus Olsson
cc9e4b2adb Get whether we're on a fork in an action 
See https://docs.github.com/en/actions/configuring-and-managing-workflows/using-environment-variables
 2020-07-09 14:09:00 +02:00
Markus Olsson
134beecda3 Get SHA on GitHub Actions 2020-07-09 14:08:49 +02:00
Rafael Oleza
1a9848af7f
Enable importHelpers TypeScript compiler option 
This avoids inlining the TypeScript helpers and instead imports them from tslib, saving bundle size
 2020-07-08 17:40:20 +02:00
Rafael Oleza
a3f21ac29b
Enable esModuleInterop in TypeScript configuration 2020-07-08 17:40:20 +02:00
Markus Olsson
5374f9330a This no longer exists in eslint core 2020-07-02 16:45:49 +02:00
Andrew Casey
3c541dc92d Fix lint and prettier issues 2020-06-24 18:28:06 +00:00
Rafael Oleza
71d3945b6e
Merge pull request #10025 from amcasey/TS39 
Upgrade to TypeScript 3.9.5
 2020-06-24 17:11:33 +02:00
Markus Olsson
b221a8c434 Notarization is complaining about syntax error on line 8, this is the only thing I can think of 2020-06-23 14:03:26 +02:00
Andrew Casey
b6d92328ef Update script/post-install.ts 
Co-authored-by: Rafael Oleza <rafeca@gmail.com>
 2020-06-22 19:36:29 +00:00
Andrew Casey
6da50096de Update script/post-install.ts 
Co-authored-by: Rafael Oleza <rafeca@gmail.com>
 2020-06-22 19:36:29 +00:00
Andrew Casey
a781f20afd Update script/post-install.ts 
Co-authored-by: Rafael Oleza <rafeca@gmail.com>
 2020-06-22 19:36:29 +00:00
Andrew Casey
398bd28d21 Update script/post-install.ts 
Better default exit status.

Co-authored-by: Rafael Oleza <rafeca@gmail.com>
 2020-06-22 19:36:29 +00:00
Andrew Casey
6de4d61e85 Upgrade @types/node to 12.12.24 to match electron 2020-06-22 19:36:29 +00:00
Andrew Casey
964697201c Fix TypeScript 3.9 errors 
Mostly, code flow analysis improvements have made `assertNever`s
unnecessary.
 2020-06-22 19:36:29 +00:00
Bill Cole
64b5c66efd
Added key per Issue #9050 2020-05-31 23:21:31 -04:00
Bill Cole
1a99b50afb
Update entitlements.plist 2020-05-31 23:13:56 -04:00
Bill Cole
660e0edc75
Add entitlement for BBEdit. See Issue #9050 2020-05-31 23:13:31 -04:00
evelyn masso
a39c3cfe10 restructure to allow option to add "blank" release 2020-03-25 17:02:29 -07:00
evelyn masso
a50f4c4fae add more console output 2020-03-25 16:36:07 -07:00
evelyn masso
6823bc6833 explicitly check for beta 2020-03-25 16:25:00 -07:00
evelyn masso
e9982eab0a fix up types, obj construction 2020-03-02 09:23:24 -08:00
evelyn masso
4ecf850e31 move log 2020-03-02 09:23:24 -08:00
evelyn masso
4c2c139c44 inline logic 2020-03-02 09:23:24 -08:00
evelyn masso
3a4e44636f more cleanup 2020-03-02 09:23:24 -08:00
evelyn masso
54ce5e92a4 comments! 2020-03-02 09:23:24 -08:00
evelyn masso
25e1b055ed cleanup 2020-03-02 09:23:24 -08:00
evelyn masso
cb5f3f99cb Update run.ts 2020-03-02 09:23:24 -08:00
evelyn masso
950d3e2dea cleanup steps 2020-03-02 09:23:24 -08:00
evelyn masso
f4c77ba953 clean up makeNewChangelog 2020-03-02 09:23:24 -08:00
evelyn masso
10fc3b49c9 add catchers 2020-03-02 09:23:24 -08:00
evelyn masso
642ef70cbe rewrite draft-release task 2020-03-02 09:23:23 -08:00
evelyn masso
68de54f4db fix changelog updating 2020-03-02 09:23:23 -08:00
evelyn masso
8ad2911520 trying this out 2020-03-02 09:23:23 -08:00
Katrina Uychaco
8edf26f14c
Merge branch 'development' into chore/cleanup-draft-notes-task 2020-02-07 10:27:05 -08:00
Katrina Uychaco
cab5d14ce3
Merge branch 'development' into format-notes-yarn-task 2020-02-06 15:08:48 -08:00
evelyn masso
9c7705a0c1 no need to stringify a string 2020-02-04 14:40:41 -08:00
evelyn masso
521423b950 code comments 2020-02-04 14:40:41 -08:00
evelyn masso
4c843171d7 clarify filters 2020-02-04 14:40:41 -08:00
evelyn masso
63ca4324fb remove duplicate-ish changelog task 2020-01-31 15:21:30 -05:00
evelyn masso
6efd97e8e6 Revert "remove old changelog validate script" 
This reverts commit 58d41f6789.
 2020-01-31 15:21:30 -05:00
evelyn masso
58d41f6789 remove old changelog validate script 2020-01-29 15:58:58 -05:00
evelyn masso
7e4e08cd2c extract release note tag order docs 2020-01-29 10:19:21 -05:00
Markus Olsson
7b92e178d2 Use SHA256 as the file digest algorithm 2020-01-13 08:43:26 +01:00
evelyn masso
347853d565 refactor icon path into helper function 2019-12-05 16:14:19 -08:00
Ed Luff
f56d478173
Merge branch 'development' into patch-1 2019-11-06 20:17:20 +00:00
evelyn masso
4305dc38fa preserve previous logic under a clearer name 2019-11-05 10:01:34 -08:00
evelyn masso
5b3a9953a4 wow, that's in important ! 2019-11-04 10:59:13 -08:00
evelyn masso
87465683d5 refactor release channel + publishing logic 2019-11-04 10:41:06 -08:00
evelyn masso
ab8fb64f36 Revert "don't fall back to NODE_ENV for determining release channel" 
This reverts commit e06f29662d.
 2019-11-04 10:40:21 -08:00
evelyn masso
e06f29662d don't fall back to NODE_ENV for determining release channel 
if it's not a release branch we should fall back to 'development'
 2019-11-04 09:56:30 -08:00
Ed Luff
e9d567971c
Merge branch 'development' into patch-1 2019-11-04 16:39:21 +00:00
evelyn masso
eb00ee4f42 remove unneeded identity config field 2019-11-04 08:30:49 -08:00
evelyn masso
3b8675f5cb override type to avoid @ts-ignore 2019-11-04 08:08:54 -08:00
evelyn masso
ecae21ac24 Update build.ts 2019-11-03 15:09:59 -08:00
evelyn masso
4f48267003 don't need these native entitlements 2019-11-03 15:08:54 -08:00
evelyn masso
86aae6ab77 unneeded entitlement 2019-11-03 15:04:29 -08:00
evelyn masso
c7467b1420 remove sub-entitlement 
com.apple.security.cs.allow-unsigned-executable-memory includes com.apple.security.cs.allow-jit and more
 2019-11-03 15:01:38 -08:00
evelyn masso
39d336e50e remove dyld entitlement 2019-11-03 14:53:36 -08:00
evelyn masso
59e745fef0 remove media entitlements 2019-11-03 14:53:23 -08:00
evelyn masso
f027c4fbcd this version opt is ignored 2019-11-03 14:48:14 -08:00
evelyn masso
6ae40a5d87 customize signing type and specify electron version 2019-11-03 14:03:25 -08:00
evelyn masso
831efce4cd always use hardenedRuntime 2019-11-03 14:01:59 -08:00
evelyn masso
8d19d844bb add entitlements 2019-11-03 14:01:44 -08:00
evelyn masso
ed0a147314 only notarize when distributing 2019-11-03 13:59:36 -08:00
evelyn masso
4a6e05e43b disable hardenedRuntime 2019-11-01 16:42:20 -07:00
evelyn masso
1b4e7f95a0
Merge branch 'development' into chore/macos-notarize 2019-11-01 11:01:33 -07:00
evelyn masso
ad89cbfb42 add notarization for publishable macOS builds 2019-10-30 10:46:38 -07:00
Ed Luff
2a1b1b4497
consistency 2019-10-29 22:27:10 +00:00
Ed Luff
4fe83838ae
nor allowUnused 2019-10-28 20:48:02 +00:00
evelyn masso
cc8ed4fa69 Revert "Revert "new octicons package"" 
This reverts commit f3ce77a5ba.
 2019-09-25 11:24:58 -07:00
evelyn masso
f3ce77a5ba Revert "new octicons package" 
This reverts commit 19fb0cac27.
 2019-09-25 11:23:53 -07:00
evelyn masso
19fb0cac27 new octicons package 
see https://github.com/primer/octicons/pull/311
 2019-09-24 13:39:31 -07:00
Brendan Forster
62fbe90e8f format some json files 2019-05-03 09:24:59 -03:00
Brendan Forster
cf1b085702 at build time, ensure licenses include trailing newline 
Co-Authored-By: jamesgeorge007 <jamesgeorge998001@gmail.com>
 2019-03-26 20:29:22 -03:00
Brendan Forster
1ba7e36c6a
Merge pull request #7119 from JB1905/development 
Enable darwinDarkModeSupport when packaging for macOS
 2019-03-25 14:54:37 -03:00
Jakub Biesiada
fd964a65f7 Update build.ts 2019-03-18 22:12:44 +01:00
Brendan Forster
ec08a240b6 update explicit exclusions to new plugin name 2019-03-07 11:03:58 -04:00
Brendan Forster
3f2084e1cb
Merge pull request #6647 from desktop/add-test-for-node-sass-migration 
add regression test for node-sass migration
 2019-02-17 16:07:40 -04:00
Brendan Forster
5415f2d492 tighten up copy 2019-01-25 09:03:12 -04:00
Brendan Forster
f9e80ae345 liiint 2019-01-25 09:03:12 -04:00
Brendan Forster
0078189470 add build step for release builds to catch SASS regressions 2019-01-25 09:03:12 -04:00
Brendan Forster
68d26b50a4 Merge branch 'development' into no-prettier-script 2019-01-22 18:14:45 -04:00
evelyn masso
1f84edfcfb
Merge pull request #6640 from desktop/use-promises-theyre-pretty-neat 
extract updateLicenseDump and promisify it
 2019-01-17 09:11:44 -08:00
Brendan Forster
d2be1c4d5b
Merge pull request #6516 from desktop/refresh-octicons 
update octicons package to v8.x
 2019-01-16 14:47:31 -04:00
Brendan Forster
1b93fd4df4
Merge pull request #6517 from desktop/port-script-tests-to-jest 
port script tests from mocha to jest
 2019-01-16 13:17:33 -04:00
Brendan Forster
5649486538 only promisify once 2019-01-16 12:16:15 -04:00
Brendan Forster
3d005298b9 leverage promise-based API in fs-extra 2019-01-16 10:51:14 -04:00
Brendan Forster
3f2be3ba32 promisify these APIs to simplify control flow 2019-01-16 10:46:42 -04:00
Brendan Forster
0bb73478e5 there is no upset 2019-01-16 09:05:09 -04:00
Brendan Forster
aa6606b045 move license overrides closer to module 2019-01-16 09:01:06 -04:00
Brendan Forster
2a858eceec extract updateLicenseDump to separate module and promisify it 2019-01-16 08:50:41 -04:00
Brendan Forster
862e0922df
update a couple of mentions of master to development 2019-01-09 14:02:04 -04:00
Brendan Forster
8ceef71712 ensure jest-junit generates distinct files before uploading 2019-01-03 13:08:19 -04:00
Brendan Forster
4005ff8720 don't apply rule to jest config 2019-01-03 13:08:19 -04:00
Brendan Forster
a0b9185a43 remove chai assertions 2019-01-03 13:08:19 -04:00
Brendan Forster
c8f60558c2 port script tests to jest 2019-01-03 13:08:19 -04:00
Brendan Forster
2ddaab868b ensure octicons are generated in predictable order 2018-12-31 13:48:02 -04:00
Brendan Forster
cf99e9555c
Merge pull request #6260 from desktop/upstream-fix-for-install-scripts 
spaces in filenames are problematic for profile scripts
 2018-12-19 13:25:59 -04:00
evelyn masso
f1604561cf pull prettier into yarn scripts 2018-11-30 12:16:43 -08:00
Brendan Forster
dc775fa11f corrected formatting of emitted profile script 2018-11-21 14:59:16 -04:00
Brendan Forster
0fa2a184b4 wrap path in quote marks as sanity check 2018-11-21 14:58:58 -04:00
Brendan Forster
51c9efec11 rename profile script to avoid spaces 2018-11-21 14:58:21 -04:00
evelyn masso
1b6bc7cfcd pull eslint into yarn scripts 2018-11-19 12:11:53 -08:00
Jed Fox
b39f201453
Run Prettier on HTML files 2018-11-07 11:05:07 -05:00
Brendan Forster
9854b24239 revert this tracing as it affect local production builds 2018-10-26 08:11:24 -03:00
evelyn masso
3756bc9ece comment 2018-10-25 14:52:36 -07:00
evelyn masso
e1425f1dfc don't getSha locally 2018-10-25 14:51:10 -07:00
William Shepherd
ba3194c1e0
Merge pull request #5663 from desktop/extract-ci-logic 
extract CI logic to make scripts more friendly
 2018-10-25 13:25:47 -05:00
Brendan Forster
d4713a175b add install hooks to deb package 
Co-Authored-By: bb441db <jelle.keeris@gmail.com>
 2018-10-23 11:26:06 -03:00
Brendan Forster
8cc232f42d add snap package to build 
Co-Authored-By: Martin Wimpress <flexiondotorg@users.noreply.github.com>
Co-Authored-By: bb441db <jelle.keeris@gmail.com>
 2018-10-23 11:26:06 -03:00
Brendan Forster
8258acb70d
Update info.plist 2018-10-11 11:11:54 -03:00
Brendan Forster
4f8ea9079e clarified the circleci checks 2018-09-17 08:40:12 -03:00
Brendan Forster
5431018d16 extract platform-specific checks for building and packaging into new build 2018-09-16 20:47:32 -03:00
Brendan Forster
a07604db65 update build script to provide a base info.plist with folder drop enabled 2018-09-10 14:23:43 -03:00
evelyn masso
42c5b3fa18
Merge pull request #5478 from desktop/add-curl-dependencies 
add explicit dependencies to libcurl and libsecret when packaging for deb and RPM
 2018-09-10 08:50:28 -07:00
Brendan Forster
a52c8f4d1d
add libscret shared library dependencies 2018-08-31 10:26:47 -03:00
Brendan Forster
7295b2b447 add explicit dependencies for deb and RPM installers 2018-08-26 12:09:40 -03:00
evelyn masso
2e6c4372f7 reintegrate extra env for unit tests 2018-08-17 14:49:46 -05:00
Brendan Forster
e5831a9ac3
s/module/mode 2018-08-13 19:12:34 -03:00
Brendan Forster
b346ced1c6 we use yarn now 2018-08-13 17:25:58 -03:00
Brendan Forster
e75a35451a set a flag when running unit tests that pass through ts-node 2018-08-13 16:54:29 -03:00
Brendan Forster
9d70a77468 Merge branch 'master' into upgrade-to-local-yarn-usage 2018-08-09 12:51:46 -03:00
Jed Fox
15c4019a55 Merge branch 'master' into prettier-1.14 2018-08-08 19:41:25 -04:00
Brendan Forster
49b1f14b45 add some notes 2018-08-03 15:08:17 -03:00
Brendan Forster
33ba8972af first pass at a postinstall script that loads the right version of yarn 2018-08-03 14:07:22 -03:00
Brendan Forster
8abd3dacf1 Merge branch 'master' into migrate-to-circle-ci-2.0 2018-08-02 12:40:15 -03:00
Brendan Forster
02d80738bf
less ceremony 2018-08-01 18:51:59 -03:00
Vanessa Yuen
4a4cd04f96 newline 2018-07-27 17:43:34 -07:00
Vanessa Yuen
77a054ded8 add deploy steps 2018-07-27 17:28:19 -07:00
Vanessa Yuen
ad820c1c9a improve use of yarn caching 2018-07-26 22:08:30 -07:00
Vanessa Yuen
29f31ce098 travis 2018-07-26 21:26:10 -07:00
Vanessa Yuen
33cf7fcf24 Set key partition list 2018-07-26 21:23:51 -07:00
Brendan Forster
98ba69a86c liiiint 2018-07-26 17:31:57 -03:00
Brendan Forster
233e2ec5b9 the zeroth beta should be skipped 2018-07-26 15:40:01 -03:00
Brendan Forster
96271d101f ignore entries from test deployments 2018-07-26 15:35:24 -03:00
Brendan Forster
aaf7ee17d0 ignore new merges on master for production releases 
This avoids two different kinds of confusion:
 - we edit the changelog entries when publish, so older merges can reappear
 - we assume that these merges have already been published to beta, so they
   should be already in the changelog
 2018-07-26 15:30:00 -03:00
Jed Fox
fa1f3b1655 Upgrade Prettier to 1.14 (beta) 2018-07-18 06:42:46 -04:00
Brendan Forster
39e28a5125 use await to discourage from further callback usage 2018-07-16 16:57:16 -03:00
Brendan Forster
7b2733cd22 switch over to use new endpoint 2018-07-16 16:57:16 -03:00
Jed Fox
0cabb14df7 Address review comments 2018-07-04 14:29:29 -04:00
Brendan Forster
7d1dee546a Merge branch 'master' into pr/3675 2018-07-03 14:44:55 -03:00
Brendan Forster
b740f69783 make control flow more explicit 2018-06-26 09:26:55 -03:00
Brendan Forster
8110a3bb19 fix the compiler warnings 2018-06-22 10:44:22 -03:00
Brendan Forster
bbab6f36e5 ensure scripts are strictly typed 2018-06-22 10:41:04 -03:00
Brendan Forster
87cc7b99d3 Merge branch 'master' into pr/3675 2018-06-18 13:32:48 -03:00
Brendan Forster
2660d93cde add support for spawing the dev tools when running renderer tests 2018-06-07 13:23:49 +09:30
Brendan Forster
a4b8d23ea8 Merge branch 'master' into pr/3675 2018-06-06 17:44:42 +09:30
Brendan Forster
b9386be0d1 ensure prettier looks at all these files 2018-05-28 22:44:40 +10:00
Brendan Forster
b0c34b1059 Revert "lift this up to the file header" 
This reverts commit f9d4740b7b.
 2018-05-24 11:24:45 +10:00
Brendan Forster
e7b85143ae tidy up this bit of type annotation 2018-05-24 11:12:05 +10:00
Brendan Forster
f9d4740b7b lift this up to the file header 2018-05-24 11:07:47 +10:00
Brendan Forster
e5652d3f70 fixing up some T Y P E S 2018-05-23 15:42:47 +10:00
Brendan Forster
3540ed76fa report these warnings 2018-05-21 16:29:48 +10:00
Brendan Forster
2578dc6022 actually we should watch these sync methods 2018-05-21 16:28:17 +10:00
Brendan Forster
9ff56aa3d0 cleanup unnecessary globals 2018-05-21 15:49:06 +10:00
Brendan Forster
5c57361f36 lint on new TS files at the root of the repository 2018-05-21 15:40:40 +10:00
Brendan Forster
e9ee7cc27d extract getPortOrDefault function to be defensive 2018-05-14 14:31:32 +10:00
Brendan Forster
7a8fcd1203 some additional guard checks 2018-05-14 14:30:39 +10:00
Brendan Forster
317d3fb03f defensive work around the deployment secret 2018-05-14 14:22:06 +10:00
Brendan Forster
57c65b17c3 defensive lookup of getSHA using environment variables 2018-05-14 14:18:32 +10:00
Brendan Forster
cfff3094dc validate input to electron-packager 2018-05-14 14:13:57 +10:00
Jed Fox
87e9529977
Merge branch 'master' into my-hands-are-typing 2018-05-13 18:42:34 -04:00
Jed Fox
9dab65aa29 Revert logic changes 2018-05-05 17:10:55 -04:00
Jed Fox
43466fc645 🔥 script/debug 2018-05-05 17:09:39 -04:00
Jed Fox
3b05ffabbf No more JS 2018-05-05 16:16:26 -04:00
Brendan Forster
dafdb2b9f7 Merge branch 'master' into upgrade-fs-extra 2018-05-04 15:08:33 +10:00
Brendan Forster
78d36a105a remove unused debug script 2018-04-30 13:28:47 -05:00
Brendan Forster
a6ca6926e3 Merge branch 'master' into my-hands-are-typing 2018-04-20 11:24:22 -05:00
Brendan Forster
ba54497f43 Merge branch 'master' into upgrade-fs-extra 2018-04-19 10:58:15 -05:00
Brendan Forster
c036e11bef fixed naming for things 2018-04-11 13:41:54 +10:00
Brendan Forster
66b0c75fd1 Merge branch 'master' into upgrade-yarn-time 2018-04-08 15:25:26 +10:00
Brendan Forster
27c191c623 Merge branch 'master' into my-hands-are-typing 2018-04-08 14:25:11 +10:00
Markus Olsson
768dc010f1
Merge branch 'master' into we-dont-need-to-ship-a-yaml-parser 2018-04-04 14:45:18 +02:00
Markus Olsson
985bf1c23d
Merge pull request #4355 from desktop/investigate-slimming-things 
generate an analysis of the renderer bundle when building for prod
 2018-04-03 15:36:38 +02:00
Brendan Forster
42f536bb0b Merge branch 'master' into we-dont-need-to-ship-a-yaml-parser 2018-04-03 14:47:26 +10:00
Brendan Forster
2bebf74be3 embed the choosealicense license alongside the license payload 2018-04-03 14:47:22 +10:00
Brendan Forster
63c199877d Merge branch 'master' into pr/3675 2018-04-02 17:54:33 +10:00
Brendan Forster
71caf015c2
Merge branch 'master' into upgrade-yarn-time 2018-03-31 16:30:05 +11:00
Markus Olsson
614f848985
Merge pull request #4198 from jkleinsc/arm64 
Add the ability to build arm64 builds
 2018-03-29 21:49:29 +02:00
Brendan Forster
835aeb7702 tidy up the things 2018-03-29 18:56:34 +11:00
Brendan Forster
542b8bde84 perform license parsing as part of build proces 2018-03-29 16:51:14 +11:00
Brendan Forster
6c1fadfe76 move the analysis file into dist so that it isn't part of the packaged app 2018-03-29 15:49:33 +11:00
Brendan Forster
a76185792d
Merge branch 'master' into upgrade-yarn-time 2018-03-29 12:29:46 +11:00
William Shepherd
289ae93745
Merge pull request #4336 from desktop/validate-all-the-things 
validate the changelog to catch errors before it's time to release
 2018-03-28 20:14:29 -05:00
William Shepherd
33162baccf
Merge pull request #4288 from desktop/relax-regex-for-fixed-issue 
relax regex rule to catch more merged PRs when generating changelog
 2018-03-28 20:13:59 -05:00
Brendan Forster
15bf7e3d0d forgive me padre for i have TYPES 2018-03-28 08:01:23 +11:00
Brendan Forster
4e34d4a870 this message here refers to a non-existant command 2018-03-27 12:39:46 +11:00
Brendan Forster
32d0cea27a lint the changelog file to catch syntax errors 2018-03-27 12:21:02 +11:00
Brendan Forster
2fd937430a update error message 2018-03-27 12:03:08 +11:00
Brendan Forster
c926876209 improve error output 2018-03-27 11:53:14 +11:00
Brendan Forster
cf7f361f34 format the errors from ajv rather than relying on their infrastructure, which loses some context 2018-03-27 11:43:05 +11:00
Brendan Forster
42c187799b work with the object, not just the text 2018-03-27 11:41:59 +11:00