development/github-desktop
development/github-desktop
1
0
Fork 0
mirror of https://github.com/desktop/desktop synced 2024-09-20 00:21:23 +00:00
Code Issues Packages Projects Releases Wiki Activity
35708 commits 303 branches 696 tags 363 MiB
Commit graph

28532 commits

Author SHA1 Message Date
Markus Olsson cb802f30dd Polyfill setImmediate in tests 2023-11-30 16:02:46 +01:00
Markus Olsson ee96f125f4 No such thing as async describe 2023-11-30 16:02:28 +01:00
Markus Olsson cde9c56c78 This doesn't have to be a mock 2023-11-30 16:02:21 +01:00
Markus Olsson 96c86b0427 Add a fake stats post method for tests 2023-11-30 16:02:13 +01:00
tidy-dev 49855fed2d Release 3.3.6-beta4 2023-11-30 09:53:24 -05:00
tidy-dev 8032b85419
Merge pull request #17708 from desktop/niik/commit-message-scroll-all-the-time 
Commit message scroll all the time
 2023-11-30 09:44:59 -05:00
Markus Olsson e765b0cb66 Add custom esm-transformer to work with jest 28+ 2023-11-30 14:41:17 +01:00
Markus Olsson f0c3add139 Get dexie and uuid dependent tests working again 2023-11-30 14:37:35 +01:00
tidy-dev 3bf16574b1 Add specificity to sign in buttons 2023-11-30 06:10:14 -05:00
tidy-dev 9fdbde2557 Update fork-settings.tsx 2023-11-29 13:02:31 -05:00
tidy-dev 2fa6bccee7 Use RadioGroup for git config options 2023-11-29 12:38:08 -05:00
tidy-dev 76e3dd2127 Add group to confirmation dialog check boxes 2023-11-29 12:16:07 -05:00
tidy-dev 83f843b198 Use radio group in prompts settings 2023-11-29 12:02:03 -05:00
tidy-dev 376d7d1690 Use aria-labelledby to describe other default branch text box 2023-11-29 11:36:05 -05:00
tidy-dev 5b1057e38c Use RadioGroup for default branch radio buttons in Git Preferences 2023-11-29 11:31:07 -05:00
tidy-dev dae230f6da Add aria-describedby 2023-11-29 10:19:39 -05:00
Markus Olsson 3d83c54189 Fix type constraint 2023-11-29 10:47:13 +01:00
tidy-dev f1f4b6083b Rest of that fix 2023-11-28 15:27:28 -05:00
tidy-dev 8ebc530892 Use merge base for deleted images 2023-11-28 15:15:53 -05:00
tidy-dev 1a25e3d701 Tweaking for non desriptions views 2023-11-28 12:14:13 -05:00
tidy-dev 6092dfa7ad Merge branch 'development' into niik/commit-message-scroll-all-the-time 2023-11-28 11:46:55 -05:00
tidy-dev 51ec6c266f
Merge pull request #17741 from desktop/address-17687-feedback 
Conflicts Resolutions Banner: Explain Null vs 0
 2023-11-28 09:19:09 -05:00
tidy-dev 1019dd9f9b Merge branch 'development' into releases/3.3.6-beta3 2023-11-20 09:29:50 -05:00
tidy-dev 43cc52ab50
Merge pull request #17733 from desktop/improve-reorder-commits-hint 
Improve reorder commits hint
 2023-11-20 14:28:45 +00:00
tidy-dev 93af2389b1 Merge branch 'development' into releases/3.3.6-beta3 2023-11-20 08:42:52 -05:00
Jose Cortinas b964c200eb
Merge pull request #17705 from desktop/jc-banner-improvements 
Improve NVDA screen reader support for banners
 2023-11-20 07:40:26 -06:00
tidy-dev 7a9d51fca5 Release 3.3.6-beta3 2023-11-20 08:21:49 -05:00
Markus Olsson bfd116b492
Merge pull request #17698 from desktop/preferences-tweaks 
Preferences tweaks
 2023-11-20 13:46:40 +01:00
tidy-dev a912ffcb16 Explain Null vs 0 2023-11-17 07:18:20 -05:00
tidy-dev dbd02dedab
Merge pull request #17687 from desktop/conflict-resolution-announcements 
Conflict resolution announcements
 2023-11-17 12:13:28 +00:00
Markus Olsson 8a60f18669
Merge pull request #17660 from desktop/seleeeeeeeeect 
Make text selectable in all child elements of diff
 2023-11-17 11:04:31 +01:00
Markus Olsson c477e523a2
Merge pull request #17734 from desktop/kind-kindness 
Strongly typed exception kinds
 2023-11-17 11:03:46 +01:00
Sergio Padrino a8d4bf71e2 Merge branch 'development' into improve-reorder-commits-hint 2023-11-16 15:50:44 +01:00
Sergio Padrino 5200f1ab7c
Merge pull request #17671 from desktop/reorder-with-keyboard 
Make commit reordering keyboard accessible
 2023-11-16 15:50:00 +01:00
Markus Olsson 06ea679a9d Strongly type existing exception kinds 2023-11-16 14:18:47 +01:00
Markus Olsson 7720b2416c Fix free-form exception kind 2023-11-16 14:18:16 +01:00
Sergio Padrino 05e8517f02 Extract hint to a function and improve verbiage 
Co-Authored-By: tidy-dev <75402236+tidy-dev@users.noreply.github.com>
 2023-11-16 13:13:33 +01:00
Sergio Padrino 3bb37beea8 Improve styling of reorder commits hint 
Co-Authored-By: tidy-dev <75402236+tidy-dev@users.noreply.github.com>
 2023-11-16 13:13:07 +01:00
Sergio Padrino 4d5c419a5d Allow removing dialog semantics from popovers 2023-11-16 12:52:47 +01:00
Sergio Padrino f99f93988c Allow setting an anchor offset to popovers 2023-11-16 12:47:53 +01:00
tidy-dev 59aebeae8e Update commit-list.tsx 2023-11-13 09:51:45 -05:00
Sergio Padrino 5f3a2bb6c7 More cleanup 2023-11-12 23:24:47 +01:00
Sergio Padrino d6bdd5b57a Cleanup changes for easier review 2023-11-12 23:21:37 +01:00
Sergio Padrino dbdf79daa8 Update selection based on diff line number 2023-11-12 23:15:01 +01:00
Sergio Padrino bb79bcbe14 (WIP) Refactor to use diff line numbers instead of (row, column) 2023-11-11 18:59:01 +01:00
Sergio Padrino c3594db2d7 Show popover with usage hint in keyboard reordering mode 2023-11-10 09:16:56 +01:00
Sergio Padrino 3e441579f3 Reuse one of our well-known z-index constants 
Co-Authored-By: Markus Olsson <634063+niik@users.noreply.github.com>
 2023-11-10 09:16:25 +01:00
Sergio Padrino ad7003a91f
Update app/src/ui/lib/list/list.tsx 
Co-authored-by: Markus Olsson <j.markus.olsson@gmail.com>
 2023-11-10 09:14:28 +01:00
Sergio Padrino 8130c85848
Update app/src/ui/lib/list/list.tsx 
Co-authored-by: Markus Olsson <j.markus.olsson@gmail.com>
 2023-11-10 09:14:20 +01:00
Sergio Padrino 9d30cddb79
Update app/src/ui/history/commit-list.tsx 
Co-authored-by: Markus Olsson <j.markus.olsson@gmail.com>
 2023-11-10 09:13:55 +01:00
tidy-dev eddb95470b Make zoomed in mode work 2023-11-09 14:03:50 -05:00
Jose Cortinas 488650b156 Run prettier 2023-11-09 12:28:28 -06:00
tidy-dev 5414da1483 Remove duplicate aria announcement of button labelling 2023-11-09 12:52:50 -05:00
Markus Olsson e075b7d975 Don't make the expander selectable 2023-11-09 15:22:46 +01:00
Markus Olsson d9d3814cdd Show the description and have it be scrollable all the time 2023-11-09 15:21:09 +01:00
Markus Olsson e323f80bd3 Fix jumpiness thanks to show commit message warning height 2023-11-08 15:11:11 +01:00
Markus Olsson 182a1e8d31 p elements can't be nested 2023-11-08 15:10:15 +01:00
Markus Olsson 1062d02193 🎨 Typo 2023-11-08 15:09:57 +01:00
William Harrison a0c2a12e4e
feat: Github -> GitHub 2023-11-08 18:42:37 +08:00
Jose Cortinas 5321e0cc12 Move role and aria-atomic attributes higher in DOM 2023-11-07 15:34:52 -06:00
Jose Cortinas 89f26a8009 Add menu item for merge successful banner 2023-11-07 15:34:52 -06:00
Sergio Padrino 13ed8d57dd Always render aria live container for reordering message 
For some reason, NVDA doesn't like "optional rendering" for this element, otherwise it doesn't read the message when the element is added
 2023-11-07 11:26:30 +01:00
Sergio Padrino b68665472a Update "range selection" based on the mouse position 2023-11-06 19:24:56 +01:00
tidy-dev 36aa3a045f No conflicted files message 2023-11-06 11:50:45 -05:00
tidy-dev f90e6f536d Remove unused css 2023-11-06 11:43:27 -05:00
tidy-dev d85f11bf80 Remove console log 2023-11-06 11:42:28 -05:00
tidy-dev 6475d6b12c better banner function name 2023-11-06 11:41:43 -05:00
tidy-dev 926227fa29 Delete info.tsx 2023-11-06 11:38:54 -05:00
tidy-dev c29fe78483 Make a DialogSuccess like our DialogError component 2023-11-06 11:35:03 -05:00
Markus Olsson 914dfd009c Align select-all copy with .com 
Include hunk headers when selecting entire diff
 2023-11-06 14:43:51 +01:00
Sergio Padrino 13618926ba Fix drag-based selection on unified diffs for added lines 2023-11-06 11:53:25 +01:00
Sergio Padrino 566455e2ed Also ignore clicks in that mode… 2023-11-03 17:49:57 +01:00
Sergio Padrino fe8760c6d4 Revert ability to use mouse during keyboard-based insertion 
It was too annoying specially with screen readers 😞
 2023-11-03 17:46:15 +01:00
Sergio Padrino 6832d69def Fix margin in commit drag element 2023-11-03 17:33:53 +01:00
Sergio Padrino 28564ec3cc Revert logic for aria-selected attribute in ListRows 2023-11-03 16:56:31 +01:00
Sergio Padrino 5d1a2fa9de Improve ListRow component documentation 2023-11-03 16:54:06 +01:00
Sergio Padrino 0be384d3e7 Remove unnecessary prop from CommitList component 2023-11-03 16:44:42 +01:00
Sergio Padrino 4c36eeb63f Clean up the Compare component 2023-11-03 16:26:46 +01:00
Sergio Padrino 7b643895f0 More documentation improvements, now on the List component 2023-11-03 16:24:31 +01:00
Sergio Padrino a1efb3a89e Add documentation to updateKeyboardReorderingMessage 2023-11-03 16:15:14 +01:00
Sergio Padrino c506012934 Improve documentation and naming 2023-11-03 16:12:49 +01:00
Sergio Padrino 133787d8ce Remove unnecessary property 2023-11-03 16:05:14 +01:00
Sergio Padrino 71b244c3b0 Improve styling of commit list in keyboard insertion mode 2023-11-03 13:44:08 +01:00
Sergio Padrino 24af06c89a Fix scrolling & focus issue when pressing command/control in keyboard insertion mode 2023-11-03 13:43:43 +01:00
Sergio Padrino ddd791c666 Don't notify row selection changes while in keyboard insertion mode 2023-11-03 13:43:18 +01:00
Sergio Padrino f8c6573cce Keep track of items selected for keyboard insertion 2023-11-03 11:19:06 +01:00
Sergio Padrino 7c5b38a0ac Disable context menu in commit list while reordering with keyboard 2023-11-03 11:00:02 +01:00
Dylan Ravel 8ea2c4e1a5 Added CMake file install highlight 2023-11-02 16:33:58 -07:00
Sergio Padrino f93f89c99e Change commit focus as moving for reordering 2023-11-02 18:14:11 +01:00
Sergio Padrino c9874d3ff4 Announce reordering actions through screen readers 2023-11-02 16:55:07 +01:00
Markus Olsson afa536ee11 🎨 Cleanup, reduce specificity 2023-11-02 15:00:09 +01:00
tidy-dev 555274f881
Merge pull request #17619 from desktop/commit-details-overflow 
Commit Summary Expansion: Handle 200% zoom
 2023-11-02 07:50:33 -04:00
Sergio Padrino c691f89872
Merge pull request #17630 from desktop/close-stash-dialog 
Close squash dialog after submitting the commit message
 2023-11-02 12:47:59 +01:00
tidy-dev acc85fb2cc
Merge pull request #17645 from DylanDevelops/add-gitconfig-to-settings 
[Addition] Implementing the ability to open .gitconfig file in external editor from settings menu
 2023-11-02 06:38:05 -04:00
Markus Olsson 2fe68bdc0f Make everything, not just divs and spans selectable 
Without this chromium won't understand that the user is selecting a whole "line"
 2023-11-02 09:33:26 +01:00
Markus Olsson bd300dcf65 Not supported in Chromium 2023-11-02 09:31:25 +01:00
Markus Olsson d0ffc861ba Not recognized by chromium 2023-11-02 09:31:04 +01:00
Dylan Ravel 9137fa2f9b Pulling variable from props rather than state 2023-11-01 11:45:33 -07:00
Dylan Ravel 53f8374bd8 Possible Fix to rendering issue 2023-11-01 10:43:33 -07:00
tidy-dev 109c90b934 Wip 2023-11-01 11:31:38 -04:00
tidy-dev 0f4acef0ef Release 3.3.6-beta2 2023-11-01 11:16:26 -04:00
Markus Olsson f43f2702e3 Add br element for empty diff lines 2023-11-01 11:34:26 +01:00
Dylan Ravel 2211789ae2 Added new extensions to existing highlighting 2023-10-31 15:52:16 -07:00
Dylan Ravel abaa12ecff Successfully passed down prop 
- The function to open the file in an external editor has been successfully passed down and the new addition is working correctly I believe
 2023-10-31 11:31:42 -07:00
Dylan Ravel 5c9b1e46c9 Updated link shown condition 
- Added the check to see if a global config file path exists and an external editor has been selected
 2023-10-31 10:22:00 -07:00
Sergio Padrino b7bca120df Don't let "keyboard insertion element" to go beyond the boundaries of the list 2023-10-31 17:51:27 +01:00
Sergio Padrino 39aa9e563e Move some styling to CSS 2023-10-31 17:44:46 +01:00
Sergio Padrino 160732cd81 Allow using the mouse to reorder while in "keyboard insertion" mode 2023-10-31 17:02:53 +01:00
tidy-dev a3d0950357 allow similated alive events in test environment 2023-10-31 11:47:24 -04:00
Sergio Padrino 28619f2e68 Cancel "keyboard insertion" mode when the list loses focus 2023-10-31 16:04:15 +01:00
Sergio Padrino bd657201d7 (WIP) Add background overlay to reordering mode 2023-10-31 15:23:24 +01:00
tidy-dev e5fad20dff Merge branch 'development' into commit-details-overflow 2023-10-31 10:21:11 -04:00
tidy-dev c18d0eef84 Release 3.3.6-beta1 2023-10-31 10:05:14 -04:00
Sergio Padrino f62e53a47b
Merge pull request #17640 from desktop/releases/3.3.5 
Release 3.3.5
 2023-10-31 11:34:38 +01:00
Dylan Ravel 39cd2c4e40 Added Ternary operator and link button 
Still struggling to get open in external editor working correctly.
 2023-10-31 01:10:34 -07:00
Dylan Ravel bf576437b5 Gitconfig path now stored in git.tsx 
Moving onto opening it in an external editor
 2023-10-30 21:14:29 -07:00
tidy-dev 790fb88bf9 Release 3.3.5 2023-10-30 12:31:50 -04:00
Sergio Padrino 85fb0e58af Don't show the keyboard insertion element beyond the list boundaries 2023-10-30 12:58:39 +01:00
Sergio Padrino 68cc78c9c8 While reordering with keyboard, show selected items as when selected-but-unfocused 2023-10-30 12:15:06 +01:00
Sergio Padrino d27b6aa706 Fix focus issues after switching to reordering mode 2023-10-30 11:45:27 +01:00
Sergio Padrino d865e8c442 Show content being reordered as user moves around 2023-10-30 11:45:27 +01:00
Sergio Padrino 2afbe53f02 Start moving around the insertion indicator with keyboard 2023-10-30 11:45:27 +01:00
Sergio Padrino cd52fbc89b Initial work to provide keyboard-accessible way to insert/reorder items in a flat list 2023-10-30 11:45:27 +01:00
Sergio Padrino 8a3663d4ff Add new "reorder commit" context menu action 2023-10-30 11:45:27 +01:00
tidy-dev e3832a7c74 extend stable fade 2023-10-30 06:45:15 -04:00
tidy-dev e66cae9bf3 Shadows be 30px 2023-10-30 06:25:34 -04:00
tidy-dev 24797b5b26 Only use background on expanded. 2023-10-30 06:22:57 -04:00
tidy-dev 621b6e7eed Make transition to shadow less noticeable 2023-10-30 06:20:20 -04:00
tidy-dev a5cf091030 Use linear gradient for scroll shadow 2023-10-27 10:24:27 -04:00
tidy-dev fc16aaf7a6 Merge branch 'development' into commit-details-overflow 2023-10-27 08:31:12 -04:00
tidy-dev a243bc7fe3
Merge pull request #17618 from desktop/description-tweaks 
Commit Summary Expansion: Description tweaks
 2023-10-27 06:48:27 -04:00
tidy-dev 7f5a4c619f
Merge pull request #17631 from desktop/popover-dropdown-announcement 
Dialog headers needing announced.
 2023-10-27 06:47:50 -04:00
tidy-dev e94f143009 Alert dialogs work as expected 2023-10-26 11:27:06 -04:00
tidy-dev 39cc338407 Remove wierd level announcements happening 2023-10-26 11:26:57 -04:00
tidy-dev b0b26c2afa Only Sonoma 2023-10-26 10:58:19 -04:00
tidy-dev 53fc7a49c9 Fix popover announcement 
This adds a workaround for macOS Sonoma..
 2023-10-26 10:42:27 -04:00
tidy-dev b4c81e602d Use Popover ariaLabelledby prop 2023-10-26 09:01:46 -04:00
Sergio Padrino 9965910abf Rename state to just "stashing" to make it more "honest" 
Now this dialog will be dismissed right after stashing and before retrying.

This shouldn't be a problem because this dialog is shown for multi-commit operations, that have their own "in progress" dialogs.
 2023-10-26 13:12:02 +02:00
Sergio Padrino 587449a2a0 Close the "stash changes and continue" dialog after submitting, before retrying 
This prevents the dialog to show up right after retrying (when the other action's dialog is closed)
 2023-10-26 13:10:22 +02:00
Sergio Padrino 030343aa61 Close commit message dialog right after submitting 2023-10-26 13:06:44 +02:00
Sergio Padrino 49f0a71baa Rely first on upstream branch to create pull requests… 
…then fallback on the local branch name.

This will prevent issues when the local branch is renamed, because we still want to create the pull request using the remote branch name.
 2023-10-26 10:31:48 +02:00
tidy-dev 35037f4611 Handle 200% zoom 2023-10-24 16:24:38 -04:00
Jose Cortinas 19dfdcc9dd
Merge pull request #17542 from desktop/jc-reorder-alert 
Banner screen reader improvements
 2023-10-24 13:35:56 -05:00
Jose Cortinas 2042ce01a8 Ooops this was 15000 2023-10-24 12:58:56 -05:00
Jose Cortinas 586eb0666d Use distinct key props instead 2023-10-24 12:53:26 -05:00
Jose Cortinas 18924cc478 Revert "Move each type of banner into different components" 
This reverts commit fce2052af4.
 2023-10-24 12:50:23 -05:00
Jose Cortinas fce2052af4 Move each type of banner into different components 2023-10-24 11:17:34 -05:00
Jose Cortinas 095cd88d64 Cleaner banner functions 2023-10-24 11:17:12 -05:00
Jose Cortinas 0f6faa536e Show a fake undone banner when undone 2023-10-24 11:16:32 -05:00
tidy-dev b8def4c6ae description with alt background color 2023-10-24 08:30:00 -04:00
tidy-dev a46f2928da description as 2 lines 2023-10-24 08:29:48 -04:00
Jose Cortinas c897e4bab2
Merge branch 'development' into jc-reorder-alert 2023-10-23 12:39:26 -05:00
Jose Cortinas 0220b24505 Remove overflow hidden styles for focus outline 
Without removing some overflow styles, the focus outline for elements inside of the banner is cut off and difficult to see.
 2023-10-23 12:34:52 -05:00
Jose Cortinas 71fc7ddfe2 Add focus based dismissal 2023-10-23 12:31:42 -05:00
Jose Cortinas eb9ccdb5bc Missed a button tag 2023-10-23 12:19:13 -05:00
Sergio Padrino 38f0a7fe4f Enable commit summary expansion on Beta 2023-10-23 18:09:12 +02:00
Sergio Padrino 96c53b6f8b Bump changelog and version to 3.3.5-beta1 2023-10-23 18:05:36 +02:00
tidy-dev 2fbd27f77c
Merge pull request #17557 from desktop/commit-summary-expansion-spacing-css-tweaks 
Commit Summary Expansion: CSS tweaks
 2023-10-23 11:38:53 -04:00
tidy-dev e2505a2d1c Avatar margin right slighting different between expand/collapse 2023-10-23 11:15:42 -04:00
tidy-dev 7aa639bfe9 Added +/- icon for expanded view of added/removed lines 2023-10-23 11:08:39 -04:00
tidy-dev 3206fcb019 Consistent margin for avatar line 2023-10-23 11:02:53 -04:00
tidy-dev 2b4d9bd630
Merge pull request #17581 from desktop/update-testing 
Add way to test update banners and thank you UI
 2023-10-23 08:36:59 -04:00
tidy-dev 889284b227 Merge branch 'development' into commit-summary-expansion-spacing-css-tweaks 2023-10-23 08:07:09 -04:00
tidy-dev 91a3cdcfef undefined isn't boolean 2023-10-23 08:06:29 -04:00
tidy-dev 6407083b94
Update app/src/ui/app.tsx 
Co-authored-by: Markus Olsson <j.markus.olsson@gmail.com>
 2023-10-23 07:07:08 -04:00
Sergio Padrino 9f89fac4c3
Merge pull request #17606 from DylanDevelops/add-cc-file-syntax-highlight 
[fix] Add support for .cc files in the highlighter module.
 2023-10-23 11:51:22 +02:00
Sergio Padrino d2f5149545
Merge pull request #17596 from desktop/fix-conflicts-width-issue 
Fix width issue with conflicts dialog
 2023-10-23 11:44:43 +02:00
Dylan Ravel 2f6b27161c Add support for .cc files in the highlighter module. 2023-10-21 16:01:00 -07:00
Sergio Padrino 1719fafd0c Make sure conflicted file paths take as much space as possible… but not more than they should 2023-10-20 16:29:12 +02:00
tidy-dev 368776cf30
Merge pull request #17556 from desktop/commit-summary-expansion-description-below-summary-faded-lines 
Commit Summary Expansion: Move description under summary title
 2023-10-20 07:17:36 -04:00
tidy-dev 3b9c334ff5
Merge pull request #17577 from desktop/notifications-test-build 
Notifications test build improvements
 2023-10-19 11:28:28 -04:00
Sergio Padrino 588683803e
Merge pull request #17567 from desktop/voice-over-plz-read-group-headers 
Improve/fix VoiceOver support for grouped lists
 2023-10-19 17:25:11 +02:00
Markus Olsson b6f5de494a
Merge pull request #17500 from desktop/stats-cleanup 
Allow StatsStore consumers to increment metrics directly
 2023-10-19 14:06:25 +02:00
Sergio Padrino ef704cfa4d Always wrap list-item contents to simplify code 
Co-Authored-By: tidy-dev <75402236+tidy-dev@users.noreply.github.com>
 2023-10-19 11:51:00 +02:00
Sergio Padrino b1b38b6604 Remove list-item mixin and just include it inline 2023-10-19 11:50:21 +02:00
tidy-dev c17e4af954 Make so test releases can still update 2023-10-18 13:33:59 -04:00
tidy-dev abd327dcad Update build-default-menu.ts 2023-10-18 13:26:20 -04:00
tidy-dev 4186b2805b Add way to test update banners and thank you UI 2023-10-18 13:24:54 -04:00
tidy-dev cc3a9315e7 Merge branch 'development' into commit-summary-expansion-tags 2023-10-18 08:13:09 -04:00
tidy-dev c819d98db5 Merge branch 'development' into commit-summary-expansion-lines-changed 2023-10-18 07:28:13 -04:00
tidy-dev d501e574ec Remove lines in collapsed form 
Co-Authored-By: Sergio Padrino <1083228+sergiou87@users.noreply.github.com>
 2023-10-18 07:28:03 -04:00
tidy-dev 6a88f9bf30
Merge pull request #17548 from desktop/commit-summary-expansion-sha 
Commit Summary Expansion: SHA
 2023-10-18 07:25:43 -04:00
Jose Cortinas 27bcb1e5eb Manually move focus to close or the first anchor 2023-10-17 17:23:27 -05:00
Jose Cortinas c9e9d3b21d Add fake cherry pick banner dev menu item 2023-10-17 17:22:52 -05:00
Jose Cortinas 7a81e5aa6a Revert test buttons to LinkButton components 2023-10-17 14:45:05 -05:00
Jose Cortinas e3b1b85930 Remove auto timeout and content suffix 2023-10-17 14:44:44 -05:00
tidy-dev 1738be5350 Making things a little easier to digest 2023-10-17 12:40:41 -04:00
tidy-dev 2364eb0d1d Continue is the one you are looking for 2023-10-17 12:13:00 -04:00
tidy-dev 5054d59113 Stop lots of individual fetching 2023-10-17 12:10:25 -04:00
tidy-dev ab83262900 Narrow results to PRs that have Reviews/Comments 2023-10-17 11:50:45 -04:00
tidy-dev 37fa407b02 docs 2023-10-17 11:03:24 -04:00
tidy-dev 8f9b1cf58e Move pull request checks failed testing into test notifications dialog 2023-10-17 10:58:01 -04:00
tidy-dev b7ff5c400b Warn if system setting needs changed 2023-10-17 09:25:37 -04:00
tidy-dev 7a2816f9b2
Merge pull request #17568 from desktop/releases/3.3.4 
Release 3.3.4
 2023-10-16 13:16:31 -04:00
tidy-dev 0abf3bac55 Merge branch 'development' into commit-summary-expansion-sha 2023-10-16 13:12:42 -04:00
tidy-dev 25990ad887
Merge pull request #17543 from desktop/commit-summary-expansion-authors 
Commit Summary Expansion: Authors
 2023-10-16 13:02:50 -04:00
tidy-dev 6bd0a63a07 More concise render author list code 
Co-Authored-By: Sergio Padrino <1083228+sergiou87@users.noreply.github.com>
 2023-10-16 12:37:19 -04:00
Sergio Padrino 9d64272ca0 Add improved aria-labels to the repository list 2023-10-16 16:26:15 +02:00
tidy-dev eae6648b9a Release 3.3.4 2023-10-16 10:21:34 -04:00
Sergio Padrino 4bdb24e197 Add aria-label for branches in branch lists 2023-10-16 09:32:36 +02:00
Sergio Padrino bf6d8051e4 Create a "default" aria label function for branches 2023-10-16 09:32:12 +02:00
Sergio Padrino 670a31a09b Extract RelativeTime logit to a reusable function 2023-10-16 09:31:58 +02:00
Sergio Padrino 8ed766d78d Add support for row aria-labels in our grouped lists 2023-10-16 09:31:41 +02:00
Sergio Padrino c3393fcddd Use role="presentation" for the container of a grouped list 2023-10-16 09:31:05 +02:00
tidy-dev 9ffe6683d9 Add aria-controls to expand button 2023-10-13 13:49:22 -04:00
tidy-dev 80485901ed Merge branch 'development' into commit-summary-expansion-authors 2023-10-13 12:21:23 -04:00
tidy-dev 25120603f5 Merge branch 'development' into remove-commit-summary-list-semantics 2023-10-13 10:24:56 -04:00
tidy-dev 21997fd5ac Merge branch 'development' into commit-summary-expansion-move-expander-to-title 2023-10-13 10:01:14 -04:00
tidy-dev 5705173c3b
Merge pull request #17537 from desktop/de-shortcut-commit-summary-css 
Commit Summary Expansion: Remove commit summary scss hack
 2023-10-13 10:00:45 -04:00
tidy-dev 3b4a850be2 CSS tweaks 2023-10-13 08:51:47 -04:00
tidy-dev 59d7a22536 Move description under summary title 2023-10-13 07:13:55 -04:00
tidy-dev 01c2df1733 Make tags clip on short and wrap on expanded 2023-10-13 06:40:49 -04:00
tidy-dev 8c96fa818e Expanded with more description of lines 2023-10-12 15:25:11 -04:00
tidy-dev 59335cd84b Replace added/deleted lines tooltip with plain text 2023-10-12 14:15:09 -04:00
tidy-dev 7c1d2210a0 Toggle tip is quite right, we want tooltip on keyboard focus and on click 2023-10-12 14:08:24 -04:00
tidy-dev 1b453607ff Make tooltip message be announced to screen reader users 2023-10-12 11:14:00 -04:00
tidy-dev 5a3f312ff3 Make copy button tooltip appear on click 2023-10-12 11:06:14 -04:00
tidy-dev 4787048bd1 Implement copy button in commit summary 2023-10-12 11:06:05 -04:00
tidy-dev a59ab27c87 Create copy-button.tsx 2023-10-12 10:56:36 -04:00
tidy-dev 693cd0f7ab Make author stack listed vertically on expand 2023-10-11 13:20:03 -04:00
Jose Cortinas 868a57db55 Convert links to button for autofocus 2023-10-11 12:01:03 -05:00
Jose Cortinas e650fc44f5 Try aria-atomic and modifying content 2023-10-11 12:00:46 -05:00
tidy-dev c40782a892 Changed needed do to summary becoming a flex box 2023-10-11 12:39:02 -04:00
tidy-dev 2b7853e475 Some class name changes missed 2023-10-11 12:38:51 -04:00
tidy-dev c4c9cbd975 Clean up list semantics - little bit of refactor for easier readability 2023-10-11 12:30:46 -04:00
tidy-dev 0856935ccb More details aria label to differentiate from aria expanded announcement 2023-10-11 12:14:44 -04:00
tidy-dev 162cd66746 Add aria label to button 2023-10-11 12:09:09 -04:00
tidy-dev 410e93378f Add aria-expanded attribute 2023-10-11 12:07:12 -04:00
tidy-dev 6402d7294b Remove expander from commit description 2023-10-11 12:02:03 -04:00
tidy-dev 043bc9f4d0 Expand meta data on expansion 2023-10-11 12:01:46 -04:00
tidy-dev 02a3316ec5 Adapt styles for expander in summary 2023-10-11 11:57:28 -04:00
tidy-dev 78b5327c58 Render expander in summary 2023-10-11 11:53:27 -04:00
tidy-dev 3963ccf042 Align header text center 
Co-Authored-By: Sergio Padrino <1083228+sergiou87@users.noreply.github.com>
 2023-10-11 11:41:23 -04:00
tidy-dev 5e21bb821f Removed unused class assignment 2023-10-11 11:27:00 -04:00
tidy-dev 48dd1a4620 Remove scss hypen hack 2023-10-11 10:58:46 -04:00
tidy-dev 6700c370ba Merge branch 'commit-expansion-file-diff-header' into commit-summary-expansion-history-file-list-header 2023-10-11 10:42:02 -04:00
tidy-dev b7e7f7acfa Merge branch 'development' into commit-expansion-file-diff-header 2023-10-11 10:40:37 -04:00
tidy-dev 4460015cdf Merge branch 'commit-expansion-feature-flag2' into de-shortcut-commit-summary-css 2023-10-11 10:22:53 -04:00
Markus Olsson c5ee3111a8
Sergio to the rescue 
Co-authored-by: Sergio Padrino <sergio.padrino@gmail.com>
 2023-10-11 16:16:38 +02:00
tidy-dev f4d2a809b1 Make copy of commit summary scss too 2023-10-11 10:14:21 -04:00
tidy-dev 1f5aea3859 Remove from ExpandableCommitSummary 2023-10-11 09:33:52 -04:00
tidy-dev b8db1cd237 Add File List header- matching changed file list header styles 2023-10-11 09:31:55 -04:00
tidy-dev a4936941a7 Remove diff settings from ExpandableCommitSummary 2023-10-11 08:56:40 -04:00
tidy-dev 31971aa590 Generalize changes view stiles to diff-container class 2023-10-11 08:53:17 -04:00
tidy-dev ce930e6ad4 Use DiffHeader in SelectedCommit (History view) 2023-10-11 08:52:54 -04:00
tidy-dev a381dc5d8c Change ChangedFileDetails component name to DiffHeader to be more descriptive of use 2023-10-11 08:47:06 -04:00
tidy-dev 44af54b404 Move diff header to diff directory 2023-10-11 08:44:52 -04:00
tidy-dev a927045758 Make copy of current commit summary 2023-10-11 08:17:28 -04:00
tidy-dev cf9364c8ee Add Expansion Header feature flag 2023-10-11 08:17:28 -04:00
Jose Cortinas a44fdba232 Add alert role to banner component 2023-10-10 14:37:20 -05:00