development/github-desktop
development/github-desktop
1
0
Fork 0
mirror of https://github.com/desktop/desktop synced 2024-10-31 05:19:03 +00:00
Code Issues Projects Releases Packages Wiki Activity
35176 commits 305 branches 713 tags 371 MiB
Commit graph

35176 commits

This branch
This branch
All branches
Author SHA1 Message Date
tidy-dev
4c306600f3 Remove getting/parsing check run jobs completely 2023-09-28 11:33:59 -04:00
tidy-dev
c27b88545b
Merge pull request #17441 from desktop/update-accessibiliyt-linter 
Update A11y Linter
 2023-09-28 09:45:15 -04:00
Sergio Padrino
f8a4db9290
Merge pull request #17454 from desktop/releases/3.3.4-beta1 
Release 3.3.4-beta1
 2023-09-28 08:25:27 +02:00
tidy-dev
377f145bed Mock DOMreact and ResizeObserver for app render test 2023-09-27 15:44:25 +00:00
tidy-dev
5a49354177
Already in 3.3.3-beta1 2023-09-27 11:12:47 -04:00
tidy-dev
a1cc26ae0d
Already in beta 3.3.3-beta1 2023-09-27 11:11:50 -04:00
tidy-dev
25fe486ee7
Already in beta 3.3.3-beta1 2023-09-27 11:09:30 -04:00
Sergio Padrino
7392ba1304
Remove changes from last beta 
Co-authored-by: tidy-dev <75402236+tidy-dev@users.noreply.github.com>
 2023-09-27 17:08:47 +02:00
tidy-dev
b5cf5ec9ee linter 2023-09-27 14:53:40 +00:00
tidy-dev
20cdf036e2 Make control button tooltips more visible 2023-09-27 14:51:54 +00:00
tidy-dev
ebc0033a52 Switch to our Button component to use tooltips 2023-09-27 14:49:23 +00:00
Sergio Padrino
856b12dc1c Bump changelog and version to 3.3.4-beta1 2023-09-27 16:35:15 +02:00
Sergio Padrino
71c6efa578
Merge pull request #17408 from desktop/electron-26-2-1 
Bump Electron to version 26.2.1
 2023-09-27 16:21:41 +02:00
Sergio Padrino
937a55e5dd Fix required Electron version for prod builds (24.8.3) 2023-09-27 14:03:22 +02:00
Sergio Padrino
3ad30a2702 Revert "Bump node version to v18.16.1" 
This reverts commit 1a4f3050ce.
 2023-09-27 13:59:17 +02:00
tidy-dev
e3d5dd81f3
Use valueMap variable 
Co-authored-by: Sergio Padrino <sergio.padrino@gmail.com>
 2023-09-27 06:23:28 -04:00
Markus Olsson
a101ccd1b8
Merge pull request #17442 from desktop/fancy-dialog-headers-take-one-thousand 
Clickable close button in release notes dialog and fall(ing confetti) cleanup
 2023-09-27 10:30:50 +02:00
Sergio Padrino
4a31dfe5ef Do not touch aria-describedby with tooltips unless strictly necessary 2023-09-27 08:26:10 +02:00
Sergio Padrino
6c6bd55fbe Make our tooltip a bit more aria-describedby friendly 😂 
Before this change, the tooltip would override (setting or removing) whatever the target element had set as `aria-describedby`.

This was evident when trying to set a custom `aria-describedby` to an element with a tooltip: the `aria-describedby` attribute wouldn't make it to the DOM 😑

With this change, the tooltip will add or remove itself, respecting whatever was in there before.
 2023-09-26 19:13:39 +02:00
Sergio Padrino
ee34681ed2 Add aria-describedby info to merge button 2023-09-26 19:04:21 +02:00
tidy-dev
f954662def Use new tooltips instead of titles 2023-09-26 11:33:43 -04:00
tidy-dev
a4585c7e99 Undo button should have tooltip 2023-09-26 11:30:03 -04:00
tidy-dev
31688e0294 Use tooltipped content for repository list 2023-09-26 11:20:19 -04:00
tidy-dev
c1adff5741 Make cloning tooltip use fancy tooltips 2023-09-26 11:09:55 -04:00
tidy-dev
10affdded1 Sentence case that button 2023-09-26 11:07:56 -04:00
tidy-dev
9f7a67946c Remove aria label to be removed by commit expansion work 2023-09-26 11:07:10 -04:00
tidy-dev
9de9c9c2ff Add aria label to ci checks completeness donut 2023-09-26 11:04:36 -04:00
tidy-dev
ae60888a1e Remove false-positives after update 2023-09-26 10:56:33 -04:00
tidy-dev
08cc6a26de Update to 4.10.1 2023-09-26 10:54:46 -04:00
tidy-dev
81a825e4da Make unpushed tooltip use new tooltips 2023-09-26 10:49:08 -04:00
Sergio Padrino
1a7374c4af Fix regular diff lines getting squashed when resizing the window 
Co-Authored-By: Thaddeus Crews <repiteo@outlook.com>
 2023-09-26 16:31:15 +02:00
tidy-dev
ff584e2f9a Will be removed with commit summary expansion work 2023-09-26 10:29:34 -04:00
tidy-dev
c73bbc2e05 Use logic from branch-list-item.tsx in compare branch list 2023-09-26 10:27:04 -04:00
tidy-dev
083dd9d520 Add a11y-role-supports-aria-props menu access key 2023-09-26 10:20:45 -04:00
tidy-dev
360452ed79 github/a11y-no-title-attribute disable - to circle back and add a better tooltip 2023-09-26 10:16:21 -04:00
tidy-dev
9707af9446 Remove old style tooltips -> Commit summary expansion will replace need. 2023-09-26 09:57:53 -04:00
Markus Olsson
2006afacc7 🎨 cleanup 2023-09-26 15:43:17 +02:00
Markus Olsson
9e6d157c2d Use the already rounded numbers 2023-09-26 15:42:31 +02:00
Markus Olsson
a21469a2a5 left/top 2023-09-26 15:37:43 +02:00
tidy-dev
b72fd2a56c Add a11y-role-supports-aria-props 2023-09-26 09:14:13 -04:00
tidy-dev
db6f32b5af Add disable for github/a11y-role-supports-aria-props 2023-09-26 09:05:27 -04:00
tidy-dev
c97ccde7ee [aria-label] text should be formatted the same as you would visual text. Use sentence case 2023-09-26 09:03:30 -04:00
tidy-dev
2ab059f1c7 <svg> must have an accessible name. Set aria-label or aria-labelledby, or nest a <title> element. However, if the <svg> is purely decorative, hide it with aria-hidden="true" or role="presentation" 2023-09-26 09:02:33 -04:00
tidy-dev
df97785386 Make choose branch to merge tooltip use new tooltip 2023-09-26 08:50:39 -04:00
tidy-dev
5ca23ec5e6 Add disable - flagging because role is in a variable 2023-09-26 08:49:58 -04:00
tidy-dev
fd68638dd0 Remove title from windows button 2023-09-26 08:49:39 -04:00
tidy-dev
c88e0c8e07 Upgrade eslint-plugin-github to latest 2023-09-26 08:49:27 -04:00
Markus Olsson
409ff43b55 Replace custom confetti logic with react-confetti 
And in the process we'll remove almost half of all generated CSS 🎉
 2023-09-26 14:30:59 +02:00
Markus Olsson
2c958162e9 Render graphics as background images and cleanup markup 2023-09-26 12:22:39 +02:00
Markus Olsson
aedc0ef557 Fake thank you dialog for testing 2023-09-26 12:22:20 +02:00