Commit graph

35616 commits

Author SHA1 Message Date
Markus Olsson 67f154c5d7 Add an operations cache to clean up duplicated logic 2023-12-20 12:13:50 +01:00
Markus Olsson eaf5d8fa66 📖
Co-Authored-By: Sergio Padrino <1083228+sergiou87@users.noreply.github.com>
2023-12-20 10:05:12 +01:00
Markus Olsson 9ee40ee2c3 Delete pending promise on error
Co-Authored-By: Sergio Padrino <1083228+sergiou87@users.noreply.github.com>
2023-12-20 10:05:04 +01:00
Markus Olsson 7b241f054c 📖
Co-Authored-By: Sergio Padrino <1083228+sergiou87@users.noreply.github.com>
2023-12-20 10:03:46 +01:00
Markus Olsson 70fb588805 📖
Co-Authored-By: Sergio Padrino <1083228+sergiou87@users.noreply.github.com>
2023-12-19 12:27:26 +01:00
Markus Olsson 00b5a9e8a4 🎨 cleanup
Co-Authored-By: Sergio Padrino <1083228+sergiou87@users.noreply.github.com>
2023-12-19 12:20:03 +01:00
Markus Olsson e7ebaa0d2e These happen to be the same but that's not a guarantee
Co-Authored-By: Sergio Padrino <1083228+sergiou87@users.noreply.github.com>
2023-12-19 12:19:53 +01:00
Markus Olsson 1547538a1c Display default avatar only when loading fails
Optimizing for success to avoid flickering

Co-Authored-By: Sergio Padrino <1083228+sergiou87@users.noreply.github.com>
2023-12-19 12:18:51 +01:00
Markus Olsson e6e1441710 Load ghe.com avatars with token
Co-Authored-By: Sergio Padrino <1083228+sergiou87@users.noreply.github.com>
2023-12-19 11:46:39 +01:00
Markus Olsson 01e952cdb5 Mandatory accounts
Co-Authored-By: Sergio Padrino <1083228+sergiou87@users.noreply.github.com>
2023-12-19 10:13:18 +01:00
Markus Olsson a2ba480399 Drill down accounts to all remaining avatars
Co-Authored-By: Sergio Padrino <1083228+sergiou87@users.noreply.github.com>
2023-12-19 10:11:17 +01:00
Markus Olsson bbb1af48cc Drill accounts down to commit message avatar
Co-Authored-By: Sergio Padrino <1083228+sergiou87@users.noreply.github.com>
2023-12-19 10:04:16 +01:00
dependabot[bot] 5bb579cf08
Bump github/codeql-action from 2 to 3
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2 to 3.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](https://github.com/github/codeql-action/compare/v2...v3)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-12-18 15:55:29 +00:00
dependabot[bot] 074d4c2837
Bump actions/upload-artifact from 3 to 4
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3 to 4.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](https://github.com/actions/upload-artifact/compare/v3...v4)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-12-18 15:55:16 +00:00
Sergio Padrino 2f8478ed24 Prevent co author input from being focused when amending 2023-12-15 11:04:49 +01:00
Sergio Padrino 4615fe53d8 Fix logic to replace commit message when amending 2023-12-15 11:04:32 +01:00
Sergio Padrino 85b86401a9 Reuse undo logic to restore co-authors of commit to amend 2023-12-15 11:04:08 +01:00
Markus Olsson 236f412b3f Drill down accounts to commit list item avatar component
Co-Authored-By: Sergio Padrino <1083228+sergiou87@users.noreply.github.com>
2023-12-14 09:43:11 +01:00
Markus Olsson 83625a0f0c Clean up avatar candidate generation and prepare for token-based avatars
Co-Authored-By: Sergio Padrino <1083228+sergiou87@users.noreply.github.com>
2023-12-14 09:42:53 +01:00
Markus Olsson 9035052e68 GHE uses dotcom stealth host
For now at least

Co-Authored-By: Sergio Padrino <1083228+sergiou87@users.noreply.github.com>
2023-12-13 15:51:59 +01:00
Markus Olsson 33d197f822 Remove AE, add GHE in endpoint capabilities 2023-12-13 15:51:05 +01:00
Markus Olsson 8a0ef93bfd Api method to grab an avatar token 2023-12-13 15:48:31 +01:00
Markus Olsson 6aa1e092c7
Merge pull request #17827 from desktop/unused-or-not
Re-enable no-unused-props rule
2023-12-13 15:15:41 +01:00
tidy-dev e96a22c630
Merge pull request #17866 from desktop/dashed-case
Clearer wording for branch name warning about spacing being replaced by hypens.
2023-12-13 07:26:13 -05:00
Markus Olsson e8063baed5 Re-enable eslint after config schema update
Co-Authored-By: Sergio Padrino <1083228+sergiou87@users.noreply.github.com>
2023-12-13 10:04:52 +01:00
Markus Olsson 04f6fd1e21 Explicitly reference props to satisfy no-unused-props eslint rule
Co-Authored-By: Sergio Padrino <1083228+sergiou87@users.noreply.github.com>
2023-12-13 10:03:06 +01:00
Markus Olsson 270c2a90bc Remove unused prop from AppMenuFoldout
Co-Authored-By: Sergio Padrino <1083228+sergiou87@users.noreply.github.com>
2023-12-13 09:55:21 +01:00
Markus Olsson 86e142f71b Remove unused props from AppMenuBarButton
Co-Authored-By: Sergio Padrino <1083228+sergiou87@users.noreply.github.com>
2023-12-13 09:53:29 +01:00
Markus Olsson 4243f920a8 Remove unused AppMenu props
Co-Authored-By: Sergio Padrino <1083228+sergiou87@users.noreply.github.com>
2023-12-13 09:52:54 +01:00
Sergio Padrino db057a8056
Merge pull request #17856 from desktop/dependabot/github_actions/actions/setup-python-5
Bump actions/setup-python from 4 to 5
2023-12-13 09:07:05 +01:00
tidy-dev c59e689363 Clearer wording 2023-12-12 15:56:10 -05:00
tidy-dev 500ead0aec
Merge pull request #17862 from desktop/releases/3.3.7-beta2
Release 3.3.7-beta2
2023-12-12 14:18:27 -05:00
tidy-dev c74d333679 Release 3.3.7-beta2 2023-12-12 06:39:46 -05:00
Markus Olsson ee79e3b8b5 Merge branch 'development' into unused-or-not 2023-12-12 09:57:53 +01:00
Markus Olsson d249cec318 Remove unused props in PullRequestList
Co-Authored-By: Sergio Padrino <1083228+sergiou87@users.noreply.github.com>
2023-12-12 09:56:27 +01:00
Markus Olsson 3854de571e Fix false positive linting errors
Co-Authored-By: Sergio Padrino <1083228+sergiou87@users.noreply.github.com>
2023-12-12 09:53:23 +01:00
Markus Olsson 7b60abd704 Remove unused props and remove logs loading state
See https://github.com/desktop/desktop/pull/17461, we're no longer loading logs

Co-Authored-By: Sergio Padrino <1083228+sergiou87@users.noreply.github.com>
2023-12-12 09:50:46 +01:00
Markus Olsson 1392fb6217 Reduce cleverness, increase lintingness
Co-Authored-By: Sergio Padrino <1083228+sergiou87@users.noreply.github.com>
2023-12-12 09:38:33 +01:00
Markus Olsson 5bdbca5ca0 Remove unused onOpenInExternalEditor prop
Co-Authored-By: Sergio Padrino <1083228+sergiou87@users.noreply.github.com>
2023-12-12 09:34:59 +01:00
Markus Olsson c8ea2b7b94 Ignore false positives
Co-Authored-By: Sergio Padrino <1083228+sergiou87@users.noreply.github.com>
2023-12-12 09:32:05 +01:00
Markus Olsson 7fd9c87946 Remove unused repository prop
Co-Authored-By: Sergio Padrino <1083228+sergiou87@users.noreply.github.com>
2023-12-12 09:24:23 +01:00
Markus Olsson 568634ed37 Remove unused repository prop
Co-Authored-By: Sergio Padrino <1083228+sergiou87@users.noreply.github.com>
2023-12-12 09:23:06 +01:00
Markus Olsson 06a4d6b527 remove unused isMultiCommitOperationInProgress prop
Co-Authored-By: Sergio Padrino <1083228+sergiou87@users.noreply.github.com>
2023-12-12 09:22:15 +01:00
dependabot[bot] b0de48f7d5
Bump actions/setup-python from 4 to 5
Bumps [actions/setup-python](https://github.com/actions/setup-python) from 4 to 5.
- [Release notes](https://github.com/actions/setup-python/releases)
- [Commits](https://github.com/actions/setup-python/compare/v4...v5)

---
updated-dependencies:
- dependency-name: actions/setup-python
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-12-11 16:00:48 +00:00
Sergio Padrino d2a579dc6d
Merge pull request #17855 from desktop/job-steps-screen-reader-fixes
Use list semantics in job step lists
2023-12-11 15:55:17 +01:00
Markus Olsson 11de9f178c
Merge pull request #17315 from desktop/ts5
Bump typescript to 5.3.2
2023-12-11 15:35:18 +01:00
Sergio Padrino a62942c3d3
Merge pull request #17848 from desktop/h1-h2-h3
Fix heading levels on dialogs
2023-12-11 14:55:41 +01:00
tidy-dev e2dc109a2e
Merge pull request #17844 from desktop/not-other
Use Text input box instead of radio buttons for default branch name selection
2023-12-11 07:36:57 -05:00
tidy-dev d2759f6c24
Merge pull request #17835 from desktop/tutorial-completion-announcment
Tutorial completion announcement
2023-12-11 07:34:57 -05:00
tidy-dev 5bd3ab8ca6
Merge pull request #17839 from desktop/Ensure-checkboxes-have-unique-id
Ensure checkboxes have unique ids
2023-12-11 07:34:09 -05:00