development/github-desktop
development/github-desktop
1
0
Fork 0
mirror of https://github.com/desktop/desktop synced 2024-10-31 05:19:03 +00:00
Code Issues Projects Releases Packages Wiki Activity
35219 commits 305 branches 713 tags 371 MiB
Commit graph

318 commits

Author SHA1 Message Date
Markus Olsson
dcb4293244 Include node version in matrix 2020-08-13 14:11:53 +02:00
rafeca
bb29135587
Merge remote-tracking branch 'upstream/development' into node-12.14.1 2020-08-13 11:02:37 +02:00
Markus Olsson
ac3b9e8b87 Just the OS is enough I think 2020-08-11 18:07:06 +02:00
Markus Olsson
99d00c9b74 Use exact cache match if it exists 2020-08-11 17:52:40 +02:00
rafeca
9323e09c4c
Merge branch 'spike/actions-win32' into node-12.14.1 2020-08-11 17:41:54 +02:00
rafeca
7f20b8e1ec
Remove branches filtering from pull_requests event 
I don't know if this is causing PRs from forks to not run...
 2020-08-11 17:40:28 +02:00
rafeca
280d432bf3
Update nodejs version to v12.14.1 
This is the same version as used by electron v9
 2020-08-11 17:29:35 +02:00
Markus Olsson
14465f976c INDENTATION THOUGH 2020-08-11 17:15:45 +02:00
Markus Olsson
95ad1ff387 is rafael cleverer than a fox? 2020-08-11 17:14:53 +02:00
Markus Olsson
53c5422b5d This is how I would like it to work 2020-08-11 17:10:42 +02:00
Markus Olsson
bc7377dd8f
Update .github/workflows/ci.yml 
Co-authored-by: Rafael Oleza <rafeca@github.com>
 2020-08-11 16:45:05 +02:00
rafeca
e92783ddf8
Revert "Disable core.symlinks on windows" 
This reverts commit 1d6b7e9048.
 2020-08-11 11:54:14 +02:00
Rafael Oleza
79bcf7cfa0
Execute tests before publishing the production app 2020-07-23 10:03:49 +02:00
Rafael Oleza
4011001110
Add some secrets to the build step 
Some secrets are needed in the build step for macOS
 2020-07-22 20:16:17 +02:00
Rafael Oleza
1d6b7e9048
Disable core.symlinks on windows 2020-07-22 17:24:39 +02:00
Rafael Oleza
853dfea451
Pin to major versions for OS images 2020-07-22 17:24:39 +02:00
Rafael Oleza
9398db9e80
Add missing secrets 2020-07-22 17:24:39 +02:00
Rafael Oleza
ce6228ba09
Run the GitHub Actions workflow on release branches 2020-07-22 17:24:38 +02:00
Markus Olsson
522a1fb134 Try splitting it out even further to see if we can get windows builds to fail 2020-07-09 22:47:53 +02:00
Markus Olsson
10e880bc9b I guess not? 2020-07-09 19:29:30 +02:00
Markus Olsson
ee5c0b435e Try a nicer job name 2020-07-09 17:01:11 +02:00
Markus Olsson
48fe311d7f Whoops 2020-07-09 16:56:11 +02:00
Markus Olsson
53705838d4 Rename action to ci 2020-07-09 16:25:53 +02:00
Markus Olsson
fe4902d1bb Maybe it's time to stop referring to this as win32 only 2020-07-09 16:25:20 +02:00
Markus Olsson
fd3936ffdd How hard could it possibly be? 2020-07-09 16:13:44 +02:00
Markus Olsson
f4aace4b30 Split up unit and integration tests 
Temporarily so that we can debug integration tests on their own
 2020-07-09 16:01:43 +02:00
Markus Olsson
110fd8dd69 Add an initial publish step (don't worry, it doesn't have the creds to publish yet) 2020-07-09 15:54:03 +02:00
Markus Olsson
86f432b18b Add some secrets 2020-07-09 15:53:46 +02:00
Markus Olsson
b57a6c3f09 Oh wait, I'm at fault, as per usual 2020-07-09 15:43:03 +02:00
Markus Olsson
347a3548b5 Try inspecting what's changed 2020-07-09 15:42:05 +02:00
Markus Olsson
2bbc9b5444 Give it a little bit more time 2020-07-09 15:31:04 +02:00
Markus Olsson
c16ce787a4 Lint it 2020-07-09 15:30:33 +02:00
Markus Olsson
2dfa2d09dd Build it 2020-07-09 15:30:20 +02:00
Markus Olsson
423a91d56c Limit the run time 2020-07-09 15:14:34 +02:00
Markus Olsson
a483c9282f Don't know how I managed to duplicate that 2020-07-09 14:49:12 +02:00
Markus Olsson
f80301f59a Cache yarn packages 2020-07-09 14:30:14 +02:00
Markus Olsson
f7bc91ce98 More apt description 2020-07-09 14:30:06 +02:00
Markus Olsson
0bbbcf3360 We're on Node 12 now 2020-07-09 14:20:38 +02:00
Markus Olsson
0e52ceeba6 This is already set by default 
See https://docs.github.com/en/actions/configuring-and-managing-workflows/using-environment-variables
 2020-07-09 14:12:17 +02:00
Markus Olsson
c426945b79 Set CI env var for all steps 
See https://docs.github.com/en/actions/configuring-and-managing-workflows/using-environment-variables
 2020-07-09 14:08:36 +02:00
Markus Olsson
4f880903b2 Merge branch 'development' into spike/actions-win32 2020-07-09 14:03:15 +02:00
Markus Olsson
7fe0666772 Last attempt before I toss this all out the window 2020-06-24 15:29:08 +02:00
Markus Olsson
fe7f66de7d How about this then? 2020-06-24 15:19:11 +02:00
Markus Olsson
270400ceac Only run on pushes to development 
We enforce all changes going through PRs so the current approach means we'll always run it twice
 2020-06-24 14:51:43 +02:00
Markus Olsson
b01022858e Face, meet palm 2020-06-24 14:41:11 +02:00
Markus Olsson
0a9bdb9949
Update .github/codeql/codeql-config.yml 2020-06-24 14:37:36 +02:00
Markus Olsson
a2cb4d1831 Exclude the vendor directory from code scanning 2020-06-24 12:46:51 +02:00
Justin Hutchings
913c399cc5 Update codeQL action to run on PRs from forks 2020-06-03 20:53:08 -07:00
Justin Hutchings
9b58cbe814 Run prettier on codeql.yml 
Fix linting issues
 2020-06-03 20:50:06 -07:00
Justin Hutchings
ca23638ca0
Rename .github/workflows/workflows/codeql.yml to .github/workflows/codeql.yml 2020-05-04 17:48:07 -07:00
evelyn masso
28242cb4e2 checkout with submodules recursively 2020-04-30 16:59:34 -07:00
evelyn masso
bc108761e6 maybe we don't need this 2020-04-30 16:56:17 -07:00
evelyn masso
aaeb138524 first try 2020-04-30 16:50:14 -07:00
Justin Hutchings
57b9707b39 Add CodeQL Analysis workflow 2020-04-28 12:25:07 -07:00
Tiernan L
2d05d3ed0d
Merge branch 'development' into shorten-issues 2019-10-04 18:06:39 -07:00
Billy Griffin
a7cf202313
Update .github/ISSUE_TEMPLATE/problem-to-raise.md 2019-10-04 12:38:00 -06:00
Billy Griffin
672138b81d
Update .github/ISSUE_TEMPLATE/bug_report.md 2019-10-04 12:37:54 -06:00
Tiernan L
c1c824ed39
swap emoji 2019-10-03 13:46:57 -10:00
Tiernan L
eb864919c3
typo 2019-10-03 13:41:54 -10:00
Tiernan L
d5eb68b30a
simplify the template 2019-10-03 13:41:09 -10:00
Tiernan L
1a29d28117
simplify the template 2019-10-03 13:38:33 -10:00
evelyn masso
d38f2be855 move screenshots under description 
Co-Authored-By: Billy Griffin <billygriffin@users.noreply.github.com>
 2019-10-03 11:36:51 -07:00
evelyn masso
5c5b3d2fb2
Apply suggestions from code review 
Co-Authored-By: Billy Griffin <5091167+billygriffin@users.noreply.github.com>
 2019-10-03 11:34:56 -07:00
evelyn masso
5a8e802d10 Update pull_request_template.md 2019-10-02 12:44:17 -07:00
evelyn masso
a08e57ca77
Update .github/CONTRIBUTING.md 
Co-Authored-By: Billy Griffin <5091167+billygriffin@users.noreply.github.com>
 2019-09-06 09:57:32 -07:00
evelyn masso
fe34d8f689
fix link and reduce snark 2019-09-06 08:52:14 -07:00
Tiernan L
4865b76cbc
swap label to new one 2019-07-24 15:00:09 -10:00
Tiernan L
d276354c32
add intro section 2019-06-26 15:23:48 -10:00
Tiernan L
842abf293d
adding easier way to access log files 2019-06-26 15:17:11 -10:00
Jed Fox
bf8bf8d481
Apply suggestions from code review 
Co-Authored-By: shiftkey <brendan@github.com>
 2018-12-28 13:39:51 -04:00
Brendan Forster
78ed98e7e4 tweak and organize PR template details 2018-12-28 13:08:32 -04:00
evelyn masso
d4be778adf remove references to master in docs 2018-12-27 15:38:17 -08:00
Brendan Forster
6f61a65128 add section for interesting process docs 2018-11-02 12:02:19 -03:00
Brendan Forster
e097d24fba add bullet points to these sections 2018-11-02 12:02:08 -03:00
Brendan Forster
1ac6b7fccd move labels into own doc 2018-10-26 17:01:45 -03:00
William Shepherd
388ccd0993
Merge pull request #5994 from desktop/shiftkey-patch-2 
help improve our release notes by writing them earlier
 2018-10-25 15:50:02 -05:00
William Shepherd
d5ed7c9220
Merge pull request #5899 from desktop/shiftkey-patch-1 
refreshed screenshots and instructions for timeline doc
 2018-10-25 11:50:56 -05:00
Brendan Forster
e849533b97
add some examples to guide contributors 2018-10-25 12:50:51 -03:00
Billy Griffin
e6c087384e
Update .github/pull_request_template.md 
Co-Authored-By: shiftkey <brendan@github.com>
 2018-10-25 12:13:57 -03:00
Brendan Forster
6e66377866
tweak comment 2018-10-25 10:07:38 -03:00
Brendan Forster
f4d6cefa27
help us improve our release notes by writing them earlier 2018-10-25 09:58:47 -03:00
evelyn masso
b1dbaa19db curly braces 2018-10-24 11:25:49 -07:00
Billy Griffin
70becdd49e
less abbreves 
Co-Authored-By: outofambit <outofambit@github.com>
 2018-10-24 11:24:48 -07:00
evelyn masso
42ce01de22 links 2018-10-24 11:06:46 -07:00
evelyn masso
6285b79000 closes 2018-10-24 11:03:39 -07:00
evelyn masso
696b6d6553 Update .github/pull_request_template.md 
Co-Authored-By: William Shepherd <iamwillshepherd@users.noreply.github.com>
Co-Authored-By: Billy Griffin <billygriffin@users.noreply.github.com>
 2018-10-24 11:03:11 -07:00
William Shepherd
3af297fc09
Update .github/pull_request_template.md 
Co-Authored-By: outofambit <outofambit@github.com>
 2018-10-24 10:52:35 -07:00
Billy Griffin
09deec49fd
Update .github/pull_request_template.md 
Co-Authored-By: outofambit <outofambit@github.com>
 2018-10-24 10:51:28 -07:00
evelyn masso
d96d10dc39 simple pr template draft 2018-10-23 16:36:18 -07:00
Brendan Forster
6bace95173
rename mention of Timeline in bug report template 2018-10-15 11:20:15 -03:00
Brendan Forster
aa170a11b4
Delete lock.yml 2018-09-26 12:14:32 -03:00
Christine Hu
9e98d55cf7
Update template links 2018-09-16 07:33:15 -04:00
Christine Hu
976625430f
Update CONTRIBUTING.md 2018-09-16 07:29:45 -04:00
Christine Hu
6236c9bf9d
Update CONTRIBUTING.md 2018-09-16 07:29:08 -04:00
Jed Fox
15c4019a55 Merge branch 'master' into prettier-1.14 2018-08-08 19:41:25 -04:00
Brendan Forster
f39e962c5a
renamed the file to drop the preceding dashes 2018-08-07 11:02:44 -03:00
Sungwon Ma
10d5573a01 clarify setup instructions on doc 2018-08-03 13:18:16 -04:00
Billy Griffin
2c34af36f7 Remove feature request issue template 
We're replacing this with "Problem to raise" to reframe the types of issues we'd like to get more as problem statements that impact users, and less as feature requests.
 2018-08-01 10:26:30 -06:00
Billy Griffin
4b04497eb1 Update issue template 2018-08-01 10:25:01 -06:00
Jed Fox
fa1f3b1655 Upgrade Prettier to 1.14 (beta) 2018-07-18 06:42:46 -04:00
Brendan Forster
56b1fe71f5
ensure future proposals aren't locked automatically 2018-07-17 15:23:49 -03:00
Brendan Forster
e1f606db4c
Update lock.yml 2018-07-17 14:19:24 -03:00
Brendan Forster
2df44293a8
add the rules for the lock extension 2018-07-17 14:10:04 -03:00
Brendan Forster
33e39216dc
add label to track integration-related issues 2018-07-03 15:08:14 -03:00
Billy Griffin
537a9401cf
Add user research label 
Some issues are more usability-related than others and would benefit from user research. This could take the form of interviews, observation, usability testing, or other methods, but I think it'll be helpful to organize them so we know areas of potential focus for UX research. This doesn't mean we'll necessarily incorporate every one into our upcoming user research plans, but rather that they've been identified as reasonable to include and will be available for inclusion in those efforts.
 2018-06-29 09:23:25 -06:00
Brendan Forster
a2d6aa6c5a introduce label to track theme-related reports 2018-06-25 16:07:47 -03:00
Jonah Moses
2dc9c7f4b4 use consistent sentence structure for bullet points and non full sentences by removing periods 2018-06-22 09:25:29 -06:00
Jonah Moses
fa1dd1a378 adjust wording for the reviewer-needs-to-reproduce label description 2018-06-22 09:24:31 -06:00
Neha Batra
1c86d0c1db
Merge pull request #4631 from desktop/update-issue-links 
use more granular links when documenting to open a new issue
 2018-05-14 19:15:40 -07:00
Neha Batra
c212ceec85 fix spelling error 2018-05-09 12:21:47 -07:00
Neha Batra
c168154ff7 add parallel syntax 
🎨
 2018-05-09 12:11:31 -07:00
Brendan Forster
44fe809fb1 use more granular links when opening a new issue 2018-05-08 10:59:39 +10:00
Brendan Forster
d2349aa289 revise issue template 2018-05-04 11:40:19 +10:00
Brendan Forster
6fe3ed19d6 emojiiii 2018-05-04 11:39:09 +10:00
Brendan Forster
091de8152c remove old template 2018-05-03 10:50:53 +10:00
Brendan Forster
d8fa049758 make these lowercase because it hurts my sensibilities 2018-05-03 10:50:34 +10:00
Brendan Forster
6cc753c18e introduce distinct issue templates 2018-05-03 10:38:42 +10:00
Eric Werner
82ec0394d0
fixed broken CONTRIBUTING.md-link in new issue 
I actually just filed it https://github.com/desktop/desktop/issues/4499
but remembered this was easy to fix ...
 2018-04-23 10:32:20 +02:00
Samuel D. Leslie
c741bcaf4b Fix several broken links in CONTRIBUTING.md 2018-04-02 14:29:16 +10:00
Brendan Forster
65301592a3
add note about infrastructure label 2018-03-23 13:05:38 +11:00
Brendan Forster
7f8faaac1f
Merge pull request #4112 from desktop/improve-issue-template 
Improve issue template
 2018-03-05 10:33:50 -08:00
iAmWillShepherd
5a9d712a02
Be a little less confusing 2018-03-05 12:08:29 -06:00
iAmWillShepherd
fa2492120f Address feedback 2018-03-02 10:53:48 -06:00
William Shepherd
c8d97de1fd
Try to give credit where it's due 
Co-Authored-By: Lee Dohm <1038121+lee-dohm@users.noreply.github.com>
 2018-02-28 00:25:37 -06:00
William Shepherd
cf658f6963
Fix typos 2018-02-28 00:23:43 -06:00
iAmWillShepherd
f11c2daf1d a line 2018-02-27 11:08:29 -06:00
iAmWillShepherd
014cdd823d Cleanup 2018-02-27 10:39:54 -06:00
iAmWillShepherd
643d2f525e Address feedback 2018-02-27 10:29:57 -06:00
say25
432ecfc8f1 Merge branch 'master' into the-magic-github-folder 2018-02-27 00:01:51 -06:00
William Shepherd
dbcd1a6df8
Add link to know issues doc 2018-02-26 18:11:42 -06:00
William Shepherd
443643db35
just one more 2018-02-26 18:09:43 -06:00
William Shepherd
be2b677589
Clarify that log should be added after the comment 2018-02-26 18:01:45 -06:00
William Shepherd
bd2fe23d4d
Replace missing backtick 2018-02-26 17:58:47 -06:00
William Shepherd
473a368f84
Update ISSUE_TEMPLATE.md 2018-02-26 16:19:32 -06:00
William Shepherd
2225c7f306
Improve issue template 
Now links to docs and uses HTML style comments so rendered issue's aren't polluted with unmodified contents.
 2018-02-26 16:12:50 -06:00
say25
8a522ddef0 Fix newest reference 2018-02-26 09:25:55 -06:00
say25
f6859f794b Merge branch 'master' into the-magic-github-folder 2018-02-26 09:25:33 -06:00
say25
ddee7431c9 Move Contributing to .github folder 2018-02-22 23:24:43 -06:00
William Shepherd
12b3fda849
Clean up more-info-needed probot response 
This adds a link to our contributing guide and make the messaging a little bit friendlier (see the emoji)
 2018-02-22 16:10:49 -06:00
Brendan Forster
3f5ad3013e drop unnecessary comments before issue template 2018-02-01 13:33:14 +11:00
Jed Fox
eb5a44a3fd
We are the maintainers! 
The fourth law of robotics:

4. Never say “I”
 2017-11-14 09:48:17 -05:00
Jed Fox
7055fde28e
Add the no-response config 2017-11-13 15:34:16 -05:00
Jed Fox
6dd3d5e6d9
Remove the stale bot 2017-11-13 15:24:21 -05:00
Brendan Forster
2690ff78bd
i think zero here means stale issues are never closed 2017-11-08 10:50:22 +11:00
Brendan Forster
b8a97a7bc8 disable request-info checks for PRs 2017-10-24 10:17:21 +10:00
Brendan Forster
7b1a3ce9f7 label the issue automagically 2017-10-16 14:17:22 +11:00
Brendan Forster
04ff544e5c add config for request-info 2017-10-16 14:15:09 +11:00
Brendan Forster
8156a7ac1d close it immediately 2017-10-16 14:06:39 +11:00
Brendan Forster
89e0db5145 tweak message 2017-10-16 12:41:59 +11:00
Brendan Forster
7c26151026 update issue list 2017-10-16 12:07:54 +11:00
Brendan Forster
f12a96568d add some time before stale issue is closed 2017-10-16 12:03:51 +11:00
Brendan Forster
d68ee1f3b9 first pass at the file 2017-10-16 12:00:03 +11:00
Jed Fox
46d7390a9a Add message about the “minimize” tooltip to the issue template 2017-10-02 09:12:46 -04:00
Brendan Forster
d5f1fa1b8c killing off a stray star 2017-08-28 15:31:07 +10:00
Brian Surowiec
887eb2886f Remove double slashes in log path 2017-08-14 22:11:44 -04:00
Don Okuda
d68436d822 Wrap text in HTML comment tags 2017-07-06 09:29:19 -07:00
Stanley Goldman
b4463b9256 Some language fixes 2017-06-26 10:40:02 -04:00
Brendan Forster
d690a6f512 add a mention of the timeline performance to the issue template 2017-06-07 12:52:54 -03:00
Brendan Forster
5cd7699c43 Merge branch 'master' into logs-go-in-log-folder 2017-05-15 18:56:10 +10:00
Brendan Forster
e1c8e425dc use the right directory 2017-05-15 17:13:21 +10:00
Brendan Forster
d4c3ba867b update issue template 2017-05-15 13:30:07 +10:00
Brendan Forster
6094bdc294 and issue template path 2017-05-13 09:20:31 +10:00
Brendan Forster
cd921bc912 80 chars is a fine number of chars 2017-05-03 14:12:40 +10:00
Brendan Forster
a7857b6fd4 refresh issue template 2017-05-03 11:36:05 +10:00
Brendan Forster
752e70f4f6 bold, not italics 2017-04-18 22:41:08 +10:00
Brendan Forster
46890af68c some more cleanup 2017-04-18 21:37:29 +10:00
Brendan Forster
2551da96c6 rework issue template 2017-04-12 17:08:22 +10:00
Brendan Forster
ff983be91d stub a first few pages 2017-03-30 12:19:52 +11:00