Enable no-empty-interface rule

.eslintrc.yml

@@ -78,6 +78,7 @@ rules:
         - constructor
         - method
   '@typescript-eslint/no-extraneous-class': error
+  '@typescript-eslint/no-empty-interface': error
 
   # Babel
   babel/no-invalid-this: error

app/src/crash/crash-app.tsx

@@ -14,6 +14,8 @@ import { LinkButton } from '../ui/lib/link-button'
 import { getVersion } from '../ui/lib/app-proxy'
 import { getOS } from '../lib/get-os'
 
+// This is a weird one, let's leave it as a placeholder
+// eslint-disable-next-line @typescript-eslint/no-empty-interface
 interface ICrashAppProps {}
 
 interface ICrashAppState {

app/src/ui/dialog/error.tsx

@@ -1,8 +1,6 @@
 import * as React from 'react'
 import { Octicon, OcticonSymbol } from '../octicons'
 
-interface IDialogErrorProps {}
-
 /**
  * A component used for displaying short error messages inline
  * in a dialog. These error messages (there can be more than one)
@@ -14,7 +12,7 @@ interface IDialogErrorProps {}
  *
  * Provide `children` to display content inside the error dialog.
  */
-export class DialogError extends React.Component<IDialogErrorProps, {}> {
+export class DialogError extends React.Component {
   public render() {
     return (
       <div className="dialog-error">

app/src/ui/ui-view.tsx

@@ -1,8 +1,6 @@
 import * as React from 'react'
 import * as classNames from 'classnames'
 
-interface IUiViewProps extends React.HTMLProps<HTMLDivElement> {}
-
 /**
  * High order component for housing a View.
  *
@@ -16,7 +14,7 @@ interface IUiViewProps extends React.HTMLProps<HTMLDivElement> {}
  * Examples of what's not a View include the Changes and History tabs
  * as these are contained within the <Repository /> view
  */
-export class UiView extends React.Component<IUiViewProps, {}> {
+export class UiView extends React.Component<React.HTMLProps<HTMLDivElement>> {
   public render() {
     const className = classNames(this.props.className, 'ui-view')
     const props = { ...this.props, className }