development/github-desktop
development/github-desktop
1
0
Fork 0
mirror of https://github.com/desktop/desktop synced 2024-09-13 05:11:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

Avoid double iteration of addedDeletedLines

Browse source
This commit is contained in:
Markus Olsson 2020-10-07 22:15:36 +02:00
parent c49a9985d1
commit f34b6f8f80
1 changed files with 9 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
app/src/ui/diff/side-by-side-diff.tsx
View file

@ -788,13 +788,16 @@ function getModifiedRows(
return []
}
const hunkStartLine = addedDeletedLines[0].diffLineNumber
const addedLines = new Array<ModifiedLine>()
const deletedLines = new Array<ModifiedLine>()
const addedLines = addedDeletedLines.filter(
({ line }) => line.type === DiffLineType.Add
)
const deletedLines = addedDeletedLines.filter(
({ line }) => line.type === DiffLineType.Delete
)
for (const line of addedDeletedLines) {
if (line.line.type === DiffLineType.Add) {
addedLines.push(line)
} else if (line.line.type === DiffLineType.Delete) {
deletedLines.push(line)
}
}
const output = new Array<SimplifiedDiffRow>()