development/github-desktop
development/github-desktop
1
0
Fork 0
mirror of https://github.com/desktop/desktop synced 2024-09-19 08:02:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove redundant onDismissed

Browse source
This commit is contained in:
tidy-dev 2022-11-04 10:44:01 -04:00
parent bbfaa6ea5b
commit e9d1194e98
1 changed files with 5 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
app/src/ui/app-error.tsx
View file

@ -64,12 +64,8 @@ export class AppError extends React.Component<IAppErrorProps, IAppErrorState> {
}
}
private onDismissed = () => {
this.props.onDismissed()
}
private showPreferencesDialog = () => {
this.onDismissed()
this.props.onDismissed()
//This is a hacky solution to resolve multiple dialog windows
//being open at the same time.
@ -80,7 +76,7 @@ export class AppError extends React.Component<IAppErrorProps, IAppErrorState> {
private onRetryAction = (event: React.MouseEvent<HTMLButtonElement>) => {
event.preventDefault()
this.onDismissed()
this.props.onDismissed()
const { error } = this.state
@ -162,7 +158,7 @@ export class AppError extends React.Component<IAppErrorProps, IAppErrorState> {
private onCloseButtonClick = (e: React.MouseEvent<HTMLButtonElement>) => {
e.preventDefault()
this.onDismissed()
this.props.onDismissed()
}
private renderFooter(error: Error) {
@ -225,8 +221,8 @@ export class AppError extends React.Component<IAppErrorProps, IAppErrorState> {
key="error"
title={this.getTitle(error)}
dismissable={false}
onSubmit={this.onDismissed}
onDismissed={this.onDismissed}
onSubmit={this.props.onDismissed}
onDismissed={this.props.onDismissed}
disabled={this.state.disabled}
className={
isRawGitError(this.state.error) ? 'raw-git-error' : undefined