development/github-desktop
development/github-desktop
1
0
Fork 0
mirror of https://github.com/desktop/desktop synced 2024-07-05 00:58:57 +00:00
Code Issues Projects Releases Wiki Activity

Grammarly

Browse Source 
Co-authored-by: Sergio Padrino <sergio.padrino@gmail.com>
This commit is contained in:
tidy-dev 2024-02-16 11:15:34 -05:00 committed by GitHub
parent 81fda4e46d
commit e92ad863bb
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
app/src/ui/diff/side-by-side-diff-row.tsx
View File

@ -544,16 +544,16 @@ export class SideBySideDiffRow extends React.Component<
/* The hunk-handle is a a single element with a calculated height of all the
rows in the selectable group (See `getRowSelectableGroupHeight` in
`side-by-side-diff.txs`). This gives us a single element to be our control
`side-by-side-diff.tsx`). This gives us a single element to be our control
of the check all functionality. It is positioned absolutely over the
hunk-handle-place-holders in each row in order to provide one element that
is interactive.
Other notes: I originally attempted to just use the a single hunk-handle
Other notes: I originally attempted to just use a single hunk-handle
for the first row in a group as the heights of the rows are calculated and
the rows do not clip overflow. However, that messes with the initial
measurement for cache of the first row's height as the cell measurur will
include the hunk handles initially calcualted height (num rows times
measurement for cache of the first row's height as the cell measurer will
include the hunk handles initially calculated height (num rows times
default row height) in it's measurement. (Resulting in the first row in a
group heights = to however many lines in the group x 20) Thus, I decided to
use the place holder element in each row to define the width of the hunk