mirror of
https://github.com/desktop/desktop
synced 2024-09-19 08:02:22 +00:00
Merge pull request #16220 from mdibella-dev/add-pulsar-support
Add support for Pulsar code editor on macOS.
This commit is contained in:
commit
df1951d5b5
|
@ -156,6 +156,10 @@ const editors: IDarwinExternalEditor[] = [
|
|||
name: 'Fleet',
|
||||
bundleIdentifiers: ['Fleet.app'],
|
||||
},
|
||||
{
|
||||
name: 'Pulsar',
|
||||
bundleIdentifiers: ['dev.pulsar-edit.pulsar'],
|
||||
},
|
||||
]
|
||||
|
||||
async function findApplication(
|
||||
|
|
|
@ -85,7 +85,7 @@ wishes to uninstall. These entries are used by GitHub Desktop to identify
|
|||
relevant programs and where they can be located.
|
||||
|
||||
The registry locations for each editor are listed in the `registryKeys`
|
||||
property. Some editors support multiple install locations, but are structurally
|
||||
property. Some editors support multiple install locations, but are structurally
|
||||
the same (for example 64-bit or 32-bit application, or stable and developer
|
||||
channels).
|
||||
|
||||
|
@ -128,7 +128,7 @@ is the key that Desktop needs to read the registry and find the installation for
|
|||
|
||||
As seen in the example above, you can use the following helper functions to
|
||||
enumerate the uninstall keys:
|
||||
- `LocalMachineUninstallKey` for keys in
|
||||
- `LocalMachineUninstallKey` for keys in
|
||||
`HKEY_LOCAL_MACHINE\\SOFTWARE\\Microsoft\\Windows\\CurrentVersion\\Uninstall`
|
||||
- `Wow64LocalMachineUninstallKey` for keys in
|
||||
`HKEY_LOCAL_MACHINE\\SOFTWARE\\WOW6432Node\\Microsoft\\Windows\\CurrentVersion\\Uninstall`
|
||||
|
@ -220,7 +220,7 @@ with the corresponding name exists.
|
|||
},
|
||||
```
|
||||
|
||||
**Note:** Use `jetBrainsToolboxScriptName` field only on the main edition of
|
||||
**Note:** Use `jetBrainsToolboxScriptName` field only on the main edition of
|
||||
the product. When JetBrains Toolbox generates the scripts, it doesn't consider the
|
||||
different editions, so when a new product edition is installed, it generates a
|
||||
shell script with the same name that overrides the existing one. So it's
|
||||
|
@ -233,7 +233,7 @@ impossible to differentiate between the various editions of the same product.
|
|||
4. JetBrains Toolbox will generate a new script with the same name, `pycharm`
|
||||
and will override the script generated for the community version
|
||||
|
||||
The current method supports only the default generated JetBrains Toolbox shell
|
||||
The current method supports only the default generated JetBrains Toolbox shell
|
||||
scripts.
|
||||
|
||||
## macOS
|
||||
|
@ -274,6 +274,7 @@ These editors are currently supported:
|
|||
- [Lite XL](https://lite-xl.com/)
|
||||
- [JetBrains Fleet](https://www.jetbrains.com/fleet/)
|
||||
- [JetBrains DataSpell](https://www.jetbrains.com/dataspell/)
|
||||
- [Pulsar](https://pulsar-edit.dev/)
|
||||
|
||||
These are defined in a list at the top of the file:
|
||||
|
||||
|
@ -306,7 +307,7 @@ The `CFBundleIdentifier` value in the plist is what applications use to
|
|||
uniquely identify themselves, for example `com.github.GitHubClient` is the
|
||||
identifier for GitHub Desktop.
|
||||
|
||||
To find the bundle identifier for an application, using `PhpStorm` as an example,
|
||||
To find the bundle identifier for an application, using `PhpStorm` as an example,
|
||||
run `defaults read /Applications/PhpStorm.app/Contents/Info CFBundleIdentifier`.
|
||||
|
||||
With this bundle identifier, GitHub Desktop can obtain the install location of
|
||||
|
|
Loading…
Reference in a new issue