development/github-desktop
development/github-desktop
1
0
Fork 0
mirror of https://github.com/desktop/desktop synced 2024-11-05 20:49:32 +00:00
Code Issues Projects Releases Packages Wiki Activity

Pull this out into its own function

Browse source
This commit is contained in:
joshaber 2017-10-09 10:08:21 -04:00
parent 4b6efb635e
commit c62af558bb
1 changed files with 29 additions and 22 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

51
app/src/lib/databases/repositories-database.ts
View file

@ -57,28 +57,16 @@ export class RepositoriesDatabase extends Dexie {
owners: '++id, &[endpoint+login]',
})
this.conditionalVersion(schemaVersion, 3, {}, t => {
// We're adding a new index with a uniqueness constraint in the next
// version and its upgrade callback only happens *after* the schema's been
// changed. So we need to prepare for it by removing any old data now
// which will violate it.
const table = t.table<IDatabaseGitHubRepository, number>(
'gitHubRepositories'
)
const seenKeys = new Set<string>()
return table.toCollection().each(repo => {
const key = `${repo.ownerID}+${repo.name}`
if (seenKeys.has(key)) {
// We can be sure `id` isn't null since we just got it from the
// database.
const id = repo.id!
table.delete(id)
} else {
seenKeys.add(key)
}
})
})
// We're adding a new index with a uniqueness constraint in the *next*
// version and its upgrade callback only happens *after* the schema's been
// changed. So we need to prepare for it by removing any old data now
// which will violate it.
this.conditionalVersion(
schemaVersion,
3,
{},
removeDuplicateGitHubRepositories
)
this.conditionalVersion(schemaVersion, 4, {
gitHubRepositories: '++id, name, &[ownerID+name]',
@ -112,3 +100,22 @@ export class RepositoriesDatabase extends Dexie {
}
}
}
function removeDuplicateGitHubRepositories(transaction: Dexie.Transaction) {
const table = transaction.table<IDatabaseGitHubRepository, number>(
'gitHubRepositories'
)
const seenKeys = new Set<string>()
return table.toCollection().each(repo => {
const key = `${repo.ownerID}+${repo.name}`
if (seenKeys.has(key)) {
// We can be sure `id` isn't null since we just got it from the
// database.
const id = repo.id!
table.delete(id)
} else {
seenKeys.add(key)
}
})
}