mirror of
https://github.com/desktop/desktop
synced 2024-10-01 05:43:50 +00:00
Merge pull request #18888 from desktop/track-gcm-usage
Track user credential helper preference
This commit is contained in:
commit
c49e081d67
|
@ -34,6 +34,8 @@ import { getNotificationsEnabled } from '../stores/notifications-store'
|
||||||
import { isInApplicationFolder } from '../../ui/main-process-proxy'
|
import { isInApplicationFolder } from '../../ui/main-process-proxy'
|
||||||
import { getRendererGUID } from '../get-renderer-guid'
|
import { getRendererGUID } from '../get-renderer-guid'
|
||||||
import { ValidNotificationPullRequestReviewState } from '../valid-notification-pull-request-review'
|
import { ValidNotificationPullRequestReviewState } from '../valid-notification-pull-request-review'
|
||||||
|
import { useExternalCredentialHelperKey } from '../trampoline/use-external-credential-helper'
|
||||||
|
import { enableExternalCredentialHelper } from '../feature-flag'
|
||||||
|
|
||||||
type PullRequestReviewStatFieldInfix =
|
type PullRequestReviewStatFieldInfix =
|
||||||
| 'Approved'
|
| 'Approved'
|
||||||
|
@ -398,6 +400,12 @@ interface ICalculatedStats {
|
||||||
|
|
||||||
/** Whether or not the user has their accessibility setting set for viewing diff check marks */
|
/** Whether or not the user has their accessibility setting set for viewing diff check marks */
|
||||||
readonly diffCheckMarksVisible: boolean
|
readonly diffCheckMarksVisible: boolean
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Whether or not the user has enabled the external credential helper or null
|
||||||
|
* if the user has not yet made an active decision
|
||||||
|
**/
|
||||||
|
readonly useExternalCredentialHelper?: boolean | null
|
||||||
}
|
}
|
||||||
|
|
||||||
type DailyStats = ICalculatedStats &
|
type DailyStats = ICalculatedStats &
|
||||||
|
@ -605,6 +613,12 @@ export class StatsStore implements IStatsStore {
|
||||||
launchedFromApplicationsFolder,
|
launchedFromApplicationsFolder,
|
||||||
linkUnderlinesVisible,
|
linkUnderlinesVisible,
|
||||||
diffCheckMarksVisible,
|
diffCheckMarksVisible,
|
||||||
|
...(enableExternalCredentialHelper()
|
||||||
|
? {
|
||||||
|
useExternalCredentialHelper:
|
||||||
|
getBoolean(useExternalCredentialHelperKey) ?? null,
|
||||||
|
}
|
||||||
|
: {}),
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
|
@ -2,7 +2,8 @@ import { enableExternalCredentialHelper } from '../feature-flag'
|
||||||
import { getBoolean, setBoolean } from '../local-storage'
|
import { getBoolean, setBoolean } from '../local-storage'
|
||||||
|
|
||||||
export const useExternalCredentialHelperDefault = false
|
export const useExternalCredentialHelperDefault = false
|
||||||
const useExternalCredentialHelperKey: string = 'useExternalCredentialHelper'
|
export const useExternalCredentialHelperKey: string =
|
||||||
|
'useExternalCredentialHelper'
|
||||||
|
|
||||||
export const useExternalCredentialHelper = () =>
|
export const useExternalCredentialHelper = () =>
|
||||||
enableExternalCredentialHelper() &&
|
enableExternalCredentialHelper() &&
|
||||||
|
|
Loading…
Reference in a new issue