development/github-desktop
development/github-desktop
1
0
Fork 0
mirror of https://github.com/desktop/desktop synced 2024-09-13 21:31:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use flatmap

Browse source 
Co-Authored-By: Sergio Padrino <1083228+sergiou87@users.noreply.github.com>
This commit is contained in:
tidy-dev 2024-01-09 07:03:22 -05:00
parent dd770ad210
commit c0b1505cae
1 changed files with 3 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
app/src/lib/git/log.ts
View file

@ -157,18 +157,9 @@ export async function getCommits(
// Ref is of the format: (HEAD -> master, tag: some-tag-name, tag: some-other-tag,with-a-comma, origin/master, origin/HEAD)
// Refs are comma separated, but some like tags can also contain commas in the name, so we split on the pattern ", " and then
// check each ref for the tag prefix. We used to use the regex /tag: ([^\s,]+)/g)`, but will clip a tag with a comma short.
const refs = commit.refs.split(', ')
const tags = []
for (let i = 0; i < refs.length; i++) {
const ref = refs[i]
if (!ref.startsWith('tag: ')) {
// Other commit refs like HEAD -> main, origin/master, etc.
continue
}
const tag = ref.substring(5)
tags.push(tag)
}
const tags = commit.refs
.split(', ')
.flatMap(ref => (ref.startsWith('tag: ') ? ref.substring(5) : []))
return new Commit(
commit.sha,