From 0c6eb8b6e6b0490833ad66ccd8461b00170ea571 Mon Sep 17 00:00:00 2001 From: Markus Olsson Date: Thu, 16 Jun 2016 14:03:06 +0200 Subject: [PATCH 1/2] Don't have to install node-gyp globally See https://github.com/desktop/desktop/pull/45#issuecomment-226465018 --- docs/getting-started.md | 1 - 1 file changed, 1 deletion(-) diff --git a/docs/getting-started.md b/docs/getting-started.md index e49d35b94b..5f50fb428d 100644 --- a/docs/getting-started.md +++ b/docs/getting-started.md @@ -16,7 +16,6 @@ node-gyp is required to build some of our native npm packages (such as [keytar]( * **MacOS:** Xcode and Xcode Command Line Tools (Xcode -> Preferences -> Downloads) * **Windows:** Visual Studio 2015 or [Visual C++ Build Tools](http://go.microsoft.com/fwlink/?LinkId=691126) * Run `npm config set msvs_version 2015` after installing the build tools -* Run `npm install -g node-gyp` *Windows only*: Let python install into the default suggested path (`c:\Python27`), don't try to move it into Program Files and *let it add python.exe to the path* or else you'll have to configure node-gyp manually with the path. From 5d8cfb0f893676e09ffd3218af40e30b09a78c8d Mon Sep 17 00:00:00 2001 From: Markus Olsson Date: Thu, 16 Jun 2016 14:04:05 +0200 Subject: [PATCH 2/2] Adding python to PATH isn't strictly necessary --- docs/getting-started.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/getting-started.md b/docs/getting-started.md index 5f50fb428d..3a7fbe48b0 100644 --- a/docs/getting-started.md +++ b/docs/getting-started.md @@ -17,7 +17,7 @@ node-gyp is required to build some of our native npm packages (such as [keytar]( * **Windows:** Visual Studio 2015 or [Visual C++ Build Tools](http://go.microsoft.com/fwlink/?LinkId=691126) * Run `npm config set msvs_version 2015` after installing the build tools -*Windows only*: Let python install into the default suggested path (`c:\Python27`), don't try to move it into Program Files and *let it add python.exe to the path* or else you'll have to configure node-gyp manually with the path. +*Windows only*: Let python install into the default suggested path (`c:\Python27`), don't try to move it into Program Files or else you'll have to configure node-gyp manually with the path. ## Building