Merge branch 'development' into docs-running-tests

.github/CONTRIBUTING.md

@@ -67,7 +67,7 @@ to see if the problem has already been reported. If it does exist, add a
 :thumbsup: to the issue to indicate this is also an issue for you, and add a
 comment to the existing issue if there is extra information you can contribute.
 
-#### How Do I Submit A (Good) Bug Report?
+#### How Do I Submit A Bug Report?
 
 Bugs are tracked as [GitHub issues](https://guides.github.com/features/issues/).
 
@@ -102,7 +102,7 @@ to see if the enhancement has already been suggested. If it has, add a
 :thumbsup: to indicate your interest in it, or comment if there is additional
 information you would like to add.
 
-#### How Do I Submit A (Good) Enhancement Suggestion?
+#### How Do I Submit An Enhancement Suggestion?
 
 Enhancement suggestions are tracked as [GitHub issues](https://guides.github.com/features/issues/).
 
@@ -150,4 +150,4 @@ These documents are useful resources for contributors  to learn more about the p
  - [Release Planning](https://github.com/desktop/desktop/blob/development/docs/process/release-planning.md)
  - [Issue Triage](https://github.com/desktop/desktop/blob/development/docs/process/issue-triage.md)
  - [Issue and Pull Request Labels](https://github.com/desktop/desktop/blob/development/docs/process/labels.md)
- - [Pull Request Triage](https://github.com/desktop/desktop/blob/development/docs/process/pull-request-triage.md)
+ - [Pull Requests](https://github.com/desktop/desktop/blob/development/docs/process/pull-requests.md)

.vscode/settings.json

@@ -1,10 +1,11 @@
 {
   "typescript.tsdk": "./node_modules/typescript/lib",
   "search.exclude": {
-    "**/node_modules": true,
+    ".awcache": true,
     "**/dist": true,
+    "**/node_modules": true,
     "**/out": true,
-    ".awcache": true
+    "app/test/fixtures": true
   },
   "files.exclude": {
     "**/.git": true,

app/src/lib/app-state.ts

@@ -155,9 +155,6 @@ export interface IAppState {
   /** The width of the files list in the stash view */
   readonly stashedFilesWidth: number
 
-  /** Whether we should hide the toolbar (and show inverted window controls) */
-  readonly titleBarStyle: 'light' | 'dark'
-
   /**
    * Used to highlight access keys throughout the app when the
    * Alt key is pressed. Only applicable on non-macOS platforms.

app/src/lib/stores/app-store.ts

@@ -597,8 +597,6 @@ export class AppStore extends TypedBaseStore<IAppState> {
       commitSummaryWidth: this.commitSummaryWidth,
       stashedFilesWidth: this.stashedFilesWidth,
       appMenuState: this.appMenu ? this.appMenu.openMenus : [],
-      titleBarStyle:
-        this.showWelcomeFlow || repositories.length === 0 ? 'light' : 'dark',
       highlightAccessKeys: this.highlightAccessKeys,
       isUpdateAvailableBannerVisible: this.isUpdateAvailableBannerVisible,
       currentBanner: this.currentBanner,

app/src/main-process/main.ts

@@ -486,7 +486,7 @@ app.on('ready', () => {
 
   ipcMain.on(
     'open-external',
-    (event: Electron.IpcMessageEvent, { path }: { path: string }) => {
+    async (event: Electron.IpcMessageEvent, { path }: { path: string }) => {
       const pathLowerCase = path.toLowerCase()
       if (
         pathLowerCase.startsWith('http://') ||
@@ -495,7 +495,14 @@ app.on('ready', () => {
         log.info(`opening in browser: ${path}`)
       }
 
-      const result = shell.openExternal(path)
+      let result
+      try {
+        await shell.openExternal(path)
+        result = true
+      } catch (e) {
+        log.error(`Call to openExternal failed: '${e}'`)
+        result = false
+      }
       event.sender.send('open-external-result', { result })
     }
   )

app/src/ui/app.tsx

@@ -1110,11 +1110,6 @@ export class App extends React.Component<IAppProps, IAppState> {
       return null
     }
 
-    // Don't render the menu bar when the blank slate is shown
-    if (this.state.repositories.length < 1) {
-      return null
-    }
-
     const currentFoldout = this.state.currentFoldout
 
     // AppMenuBar requires us to pass a strongly typed AppMenuFoldout state or
@@ -1162,11 +1157,23 @@ export class App extends React.Component<IAppProps, IAppState> {
     }
 
     const showAppIcon = __WIN32__ && !this.state.showWelcomeFlow
+    const inWelcomeFlow = this.state.showWelcomeFlow
+    const inNoRepositoriesView = this.state.repositories.length === 0
+
+    // The light title bar style should only be used while we're in
+    // the welcome flow as well as the no-repositories blank slate
+    // on macOS. The latter case has to do with the application menu
+    // being part of the title bar on Windows. We need to render
+    // the app menu in the no-repositories blank slate on Windows but
+    // the menu doesn't support the light style at the moment so we're
+    // forcing it to use the dark style.
+    const titleBarStyle =
+      inWelcomeFlow || (__DARWIN__ && inNoRepositoriesView) ? 'light' : 'dark'
 
     return (
       <TitleBar
         showAppIcon={showAppIcon}
-        titleBarStyle={this.state.titleBarStyle}
+        titleBarStyle={titleBarStyle}
         windowState={this.state.windowState}
         windowZoomFactor={this.state.windowZoomFactor}
       >

docs/README.md

@@ -28,7 +28,7 @@ Details about how the team is organizing and shipping GitHub Desktop:
     releases
  - **[Issue Triage](process/issue-triage.md)** - how we address issues reported
     by users
- - **[Pull Request Triage](process/pull-request-triage.md)** - how contributions are reviewed
+ - **[Pull Requests](process/pull-requests.md)** - how code contributions are submitted and reviewed
  - **[Releasing Updates](process/releasing-updates.md)** - how we deploy things
 
 ## Technical