development/github-desktop
development/github-desktop
1
0
Fork 0
mirror of https://github.com/desktop/desktop synced 2024-10-30 06:03:10 +00:00
Code Issues Projects Releases Packages Wiki Activity

Add references and context to button order docs

Browse source
This commit is contained in:
Billy Griffin 2019-11-12 08:27:37 -07:00
parent 0bc1281c64
commit a1fec5e738
1 changed files with 8 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
docs/technical/button-order.md
View file

@ -1,15 +1,19 @@
# Platform specific button order
Since this version of Desktop was released, it has been particularly difficult to find a way for our buttons to conform to expectations across platform for Windows and macOS while also conforming to expectations based on whether the action is destructive. We're primarily referencing the macOS Human Interface Guidelines around [buttons](https://developer.apple.com/design/human-interface-guidelines/macos/buttons/push-buttons/) and [dialogs](https://developer.apple.com/design/human-interface-guidelines/macos/windows-and-views/dialogs/), and the Windows UX Guidelines for [buttons](https://docs.microsoft.com/en-us/windows/win32/uxguide/win-dialog-box#commit-buttons).
Windows and macOS have different approaches when it comes to positioning standard action buttons (such as Ok/Cancel) in dialogs.
On Windows the default order is to put the affirmitive action on the left side of dismissal button (i.e Ok, Cancel) whereas macOS does the exact opposite (i.e. Cancel, Ok.). See [OK-Cancel or Cancel-OK? The Trouble With Buttons](https://www.nngroup.com/articles/ok-cancel-or-cancel-ok/) for an overview of these differences.
On Windows, the default order is to put the affirmitive action on the left side of dismissal button (Ok, Cancel) whereas macOS does the exact opposite (Cancel, Ok.). See [OK-Cancel or Cancel-OK? The Trouble With Buttons](https://www.nngroup.com/articles/ok-cancel-or-cancel-ok/) for an overview of these differences.
We believe it's important that GitHub Desktop adheres to these platform-specific conventions since users often rely on muscle memory when reacting to a dialog.
We think it's important for GitHub Desktop to adhere to these platform-specific conventions in the vast majority of cases because users often rely on muscle memory when reacting to a dialog.
The breakdown of how destructive and non-destructive dialogs should work on each platform:
This is how we've interpreted our convention of how destructive and non-destructive dialogs should work on each platform based on these guidelines:
![button conventions](https://user-images.githubusercontent.com/5091167/68219886-f794ff80-ffa3-11e9-9f25-40a9bb2e9a71.png)
For more specific discussion of how our dialogs are implemented, please see the [dialogs documentation](https://github.com/desktop/desktop/blob/development/docs/technical/dialogs.md).
## Dangerous or destructive actions
macOS interface guidelines specifically call out the need for a separate treatment of action buttons when the associated action is dangerous or destructive. An example of such an action would be deleting a branch.
Both Windows and macOS guidelines specifically call out the need for the default button to be the safest option when the action is dangerous or destructive. An example of such an action would be deleting a branch or removing a repository. In these cases, the default and initially selected button should never be the one that performs the destructive action. One exception we've made to this is when someone has explicitly tabbed to the button for a destructive action and then hits `Return` or `Enter`. In this case, we think the expectation of most people is that this will perform the destructive action, and therefore should select it to avoid confusion. We explained our reasoning for that in [this issue](https://github.com/desktop/desktop/issues/4187#issuecomment-552927923).