Merge pull request #6152 from desktop/bump-for-last-node-8

Bump for last node 8

.node-version

@@ -1 +1 @@
-8.11.4
+8.12.0

.nvmrc

@@ -1 +1 @@
-v8.11.4
+v8.12.0

.tool-versions

@@ -1,2 +1,2 @@
 python 2.7
-nodejs 8.11.4
+nodejs 8.12.0

.travis.yml

@@ -38,7 +38,7 @@ branches:
 
 language: node_js
 node_js:
-  - '8.11.4'
+  - '8.12'
 
 cache:
   yarn: true

appveyor.yml

@@ -4,7 +4,7 @@ platform:
   - x64
 
 environment:
-  nodejs_version: '8.11'
+  nodejs_version: '8.12'
 
 cache:
   - .eslintcache

azure-pipelines.yml

@@ -1,3 +1,6 @@
+variables:
+  PYTHON: 'python2.7'
+
 jobs:
   - job: Windows
     pool:
@@ -5,7 +8,7 @@ jobs:
     steps:
       - task: NodeTool@0
         inputs:
-          versionSpec: '8.11.1'
+          versionSpec: '8.12.0'
       - task: geeklearningio.gl-vsts-tasks-yarn.yarn-installer-task.YarnInstaller@2
         inputs:
           versionSpec: '1.5.1'
@@ -28,7 +31,7 @@ jobs:
           sudo apt-get install -y --no-install-recommends libsecret-1-dev xvfb fakeroot dpkg rpm xz-utils xorriso zsync libxss1 libgconf2-4 libgtk-3-0
       - task: NodeTool@0
         inputs:
-          versionSpec: '8.11.1'
+          versionSpec: '8.12.0'
       - task: geeklearningio.gl-vsts-tasks-yarn.yarn-installer-task.YarnInstaller@2
         inputs:
           versionSpec: '1.5.1'
@@ -50,7 +53,7 @@ jobs:
     steps:
       - task: NodeTool@0
         inputs:
-          versionSpec: '8.11.1'
+          versionSpec: '8.12.0'
       - script: |
           yarn install --force
         name: Install
@@ -70,7 +73,7 @@ jobs:
           sudo apt-get install -y --no-install-recommends libsecret-1-dev
       - task: NodeTool@0
         inputs:
-          versionSpec: '8.11.1'
+          versionSpec: '8.12.0'
       - task: geeklearningio.gl-vsts-tasks-yarn.yarn-installer-task.YarnInstaller@2
         inputs:
           versionSpec: '1.5.1'

docs/contributing/setup-macos.md

@@ -2,7 +2,7 @@
 
 You will need to install these tools on your machine:
 
- - Node.js v8.11.4
+ - Node.js v8.12.0
  - Python 2.7
  - Xcode and Xcode Command Line Tools (Xcode -> Preferences -> Downloads)
 
@@ -14,11 +14,11 @@ Let's see if you have the right version of `node` installed. Open a terminal and
 $ node -v
 ```
 
-If you see an error about being unable to find `node`, that probably means you don't have any Node tools installed. You can install Node LTS (the version we need) from the [Node.js website](https://nodejs.org/en/download/) and restart your shell.
+If you see an error about being unable to find `node`, that probably means you don't have any Node tools installed. You can install Node 8 from the [Node.js website](https://nodejs.org/download/release/v8.12.0/) and restart your shell.
 
-If you see the output `v8.11.x` (where `x` is any number), you're good to go.
+If you see the output `v8.12.0`, you're good to go.
 
-If you see the output `v10.x.y` you're ahead of what we currently support. We have an outstanding issue building GitHub Desktop with Node 10, and hopefully can resolve this soon. If you don't care about the version you are running, you can install the version from the [Node.js website](https://nodejs.org/en/download/) over the top of your current install.
+If you see the output `v10.x.y` you're ahead of what we currently support. See [#5876](https://github.com/desktop/desktop/issues/5876) for details about building GitHub Desktop with Node 10, which we can hopefully resolve soon. If you don't care about the version you are running, you can install the version from the [Node.js website](https://nodejs.org/download/release/v8.12.0/) over the top of your current install.
 
 ### I need to use different versions of Node.js in different projects!
 
@@ -46,7 +46,7 @@ $ nvm use
 $ node -v
 ```
 
-If you see `v8.11.4`, you're good to go.
+If you see `v8.12.0`, you're good to go.
 
 #### Configuring `asdf-nodejs`
 

docs/contributing/setup.md

@@ -10,7 +10,7 @@ See [mac-deps-setup.md](./setup-macos.md).
 
 ### Windows
 
- - [Node.js v8.11.4](https://nodejs.org/dist/v8.11.4/)
+ - [Node.js v8.12.0](https://nodejs.org/dist/v8.12.0/)
     - *Make sure you allow the Node.js installer to add node to the PATH.*
  - [Python 2.7](https://www.python.org/downloads/windows/)
     - *Let Python install into the default suggested path (`c:\Python27`), otherwise you'll have
@@ -121,7 +121,7 @@ versions look similar to the below output:
 
 ```shellsession
 $ node -v
-v8.11.4
+v8.12.0
 
 $ yarn -v
 1.9.4