mirror of
https://github.com/desktop/desktop
synced 2024-08-28 12:40:55 +00:00
Add Exe to shim path, cleanup comments, add docs
This commit is contained in:
parent
d3901bc0cd
commit
8d544c9ca9
|
@ -484,26 +484,9 @@ const editors: WindowsExternalEditor[] = [
|
|||
registryKeys: [
|
||||
CurrentUserUninstallKey('0949b555-c22c-56b7-873a-a960bdefa81f')
|
||||
],
|
||||
installLocationRegistryKey: 'DisplayIcon',
|
||||
//executableShimPaths: [['..', 'pulsar', 'resources', 'pulsar.cmd']],
|
||||
executableShimPaths: [['..', 'pulsar', 'Pulsar.exe']],
|
||||
displayNamePrefix: 'Pulsar',
|
||||
publishers: ['Pulsar-Edit'],
|
||||
/**
|
||||
* Alright, so don't commit all this, obviously.
|
||||
* electron-builder sets the 'installLocaitonRegistryKey' as 'Pulsar.exe,0'
|
||||
* If we remove ',0' this works perfectly, but that value is harccoded
|
||||
* in the source for some reason.
|
||||
* So beyond that we could use the 'executableShimPaths' as long as
|
||||
* 'InstallLocation' is set via the registry. Which there is no way to do
|
||||
* from the electron-builder config.
|
||||
* So suppose this means I finally have to make a custom NHS script.
|
||||
* Once that script is done, lets set the 'InstallLocation' properly
|
||||
* then we can go ahead and figure out what the global machine install looks like.
|
||||
* Maybe at that point I could get Daeraxa to be helpful as always and setup
|
||||
* linux, so that we get everything working finally, since an awesome
|
||||
* community member did the same for macOS.
|
||||
* https://discord.com/channels/992103415163396136/992109539346370661/1120902075002408971
|
||||
*/
|
||||
},
|
||||
]
|
||||
|
||||
|
|
|
@ -46,6 +46,7 @@ These editors are currently supported:
|
|||
- [Aptana Studio](http://www.aptana.com/)
|
||||
- [JetBrains Fleet](https://www.jetbrains.com/fleet/)
|
||||
- [JetBrains DataSpell](https://www.jetbrains.com/dataspell/)
|
||||
- [Pulsar](https://pulsar-edit.dev/)
|
||||
|
||||
These are defined in a list at the top of the file:
|
||||
|
||||
|
|
Loading…
Reference in a new issue