development/github-desktop
development/github-desktop
1
0
Fork 0
mirror of https://github.com/desktop/desktop synced 2024-09-14 05:41:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

No need for a type assertion

Browse source
This commit is contained in:
Jose Cortinas 2024-02-20 08:47:11 -06:00
parent b29d20415a
commit 7a1cfb778a
1 changed files with 15 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
app/src/ui/octicons/octicon.tsx
View file

@ -53,7 +53,7 @@ export class Octicon extends React.Component<IOcticonProps, {}> {
height
)
const scaledSymbol = symbol[naturalHeight]!
const scaledSymbol = symbol[naturalHeight]
const naturalWidth = scaledSymbol.w
const width = height * (naturalWidth / naturalHeight)
@ -100,6 +100,12 @@ export class Octicon extends React.Component<IOcticonProps, {}> {
)
}
/**
* Determine if the given symbol is a single variant or a set of variants.
*
* @param symbol The symbol to check.
* @returns True if the symbol is a single variant, false if it's a set.
*/
private isSingleVariant(
symbol: OcticonSymbol
): symbol is OcticonSymbolVariant {
@ -111,6 +117,14 @@ export class Octicon extends React.Component<IOcticonProps, {}> {
)
}
/**
* Find the closest natural height to the given height. Falls back to the
* first height in the list if none are larger or equal than the given height.
*
* @param naturalHeights The list of natural heights to choose from.
* @param height The height to find the closest natural height to.
* @returns The closest natural height to the given height.
*/
private closestNaturalHeight(naturalHeights: Array<number>, height: number) {
return naturalHeights.reduce(
(acc, naturalHeight) => (naturalHeight <= height ? naturalHeight : acc),