development/github-desktop
development/github-desktop
1
0
Fork 0
mirror of https://github.com/desktop/desktop synced 2024-08-25 03:07:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

Loosen detection of web flow committer on GHES

Browse source 
Fixes #13848
This commit is contained in:
Markus Olsson 2022-02-09 10:17:08 +01:00
parent e9b6653a3a
commit 730ef46bbb
1 changed files with 13 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
app/src/lib/web-flow-committer.ts
View file

@ -31,9 +31,19 @@ export function isWebFlowCommitter(
return true
}
if (name === 'GitHub Enterprise') {
const host = new URL(endpoint).host.toLowerCase()
return email.endsWith(`@${host}`)
if (endpoint !== getDotComAPIEndpoint() && name === 'GitHub Enterprise') {
// We can't assume that the email address will match any specific format
// here since the web flow committer email address on GHES is the same as
// the noreply email which can be configured by domain administrators so
// we'll just have to assume that for a GitHub hosted repository (but not
// GitHub.com) a commit author of the name 'GitHub Enterprise' is the web
// flow author.
//
// Hello future contributor: Turns out the web flow committer name is based
// on the "flavor" of GitHub so it's possible that you're here wondering why
// this isn't working and chances are it's because we've updated the
// GHES branding or introduced some new flavor.
return true
}
return false