mirror of
https://github.com/desktop/desktop
synced 2024-08-27 04:00:55 +00:00
🔥 rules that conflict with Prettier
This commit is contained in:
parent
e02b1147aa
commit
4deedeb736
|
@ -28,16 +28,11 @@ rules:
|
|||
|
||||
# Babel
|
||||
babel/no-invalid-this: error
|
||||
babel/semi:
|
||||
- error
|
||||
- never
|
||||
|
||||
# React
|
||||
react/jsx-boolean-value:
|
||||
- error
|
||||
- always
|
||||
react/jsx-curly-spacing: error
|
||||
react/jsx-equals-spacing: error
|
||||
react/jsx-key: error
|
||||
react/jsx-no-bind: error
|
||||
react/no-string-refs: error
|
||||
|
@ -46,29 +41,12 @@ rules:
|
|||
# BUILTIN #
|
||||
###########
|
||||
curly: error
|
||||
## blocked by https://github.com/eslint/typescript-eslint-parser/issues/344
|
||||
# indent:
|
||||
# - error
|
||||
# - 2
|
||||
# - SwitchCase: 1
|
||||
##
|
||||
|
||||
array-bracket-spacing:
|
||||
- warn
|
||||
- never
|
||||
object-curly-spacing:
|
||||
- warn
|
||||
- always
|
||||
no-new-wrappers: error
|
||||
no-redeclare:
|
||||
- error
|
||||
- builtinGlobals: true
|
||||
no-eval: error
|
||||
no-sync: error
|
||||
no-trailing-spaces:
|
||||
- error
|
||||
# why?
|
||||
- ignoreComments: true
|
||||
no-unused-expressions: error
|
||||
no-use-before-define:
|
||||
- error
|
||||
|
@ -76,18 +54,9 @@ rules:
|
|||
variables: false
|
||||
no-var: error
|
||||
prefer-const: error
|
||||
no-extra-semi: error
|
||||
comma-dangle:
|
||||
- error
|
||||
- always-multiline
|
||||
eqeqeq:
|
||||
- error
|
||||
- smart
|
||||
space-before-blocks: error
|
||||
keyword-spacing: error
|
||||
space-infix-ops: error
|
||||
semi-spacing: error
|
||||
comma-spacing: error
|
||||
|
||||
###########
|
||||
# SPECIAL #
|
||||
|
|
|
@ -125,7 +125,7 @@ function sourceMappedStackTrace(error: Error): string | undefined {
|
|||
// in our weak map. In order to get around that we'll eagerly access the
|
||||
// stack, forcing our handler to run which should ensure that the native
|
||||
// frames are stored in our weak map.
|
||||
(error.stack || '').toString()
|
||||
;(error.stack || '').toString()
|
||||
frames = stackFrameMap.get(error)
|
||||
}
|
||||
|
||||
|
|
|
@ -182,7 +182,7 @@ export class Dialog extends React.Component<IDialogProps, IDialogState> {
|
|||
public componentDidMount() {
|
||||
// This cast to any is necessary since React doesn't know about the
|
||||
// dialog element yet.
|
||||
(this.dialogElement as any).showModal()
|
||||
;(this.dialogElement as any).showModal()
|
||||
|
||||
this.setState({ isAppearing: true })
|
||||
this.scheduleDismissGraceTimeout()
|
||||
|
|
|
@ -11,12 +11,7 @@
|
|||
"rules": {
|
||||
"button-group-order": true,
|
||||
"class-name": true,
|
||||
"indent": [
|
||||
true,
|
||||
"spaces"
|
||||
],
|
||||
"jsdoc-format": true,
|
||||
"jsx-no-multiline-js": true,
|
||||
"member-ordering": [
|
||||
true,
|
||||
"static-before-instance",
|
||||
|
|
Loading…
Reference in a new issue