development/github-desktop
development/github-desktop
1
0
Fork 0
mirror of https://github.com/desktop/desktop synced 2024-10-31 05:19:03 +00:00
Code Issues Projects Releases Packages Wiki Activity

Add role="alertdialog" to generic app error dialog

Browse source
This commit is contained in:
Sergio Padrino 2023-10-03 11:32:28 +02:00
parent b0b11e7281
commit 48a65c80fd
1 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
app/src/ui/app-error.tsx
View file

@ -227,10 +227,14 @@ export class AppError extends React.Component<IAppErrorProps, IAppErrorState> {
className={ className={
isRawGitError(this.state.error) ? 'raw-git-error' : undefined isRawGitError(this.state.error) ? 'raw-git-error' : undefined
} }
role="alertdialog"
ariaDescribedBy="app-error-description"
> >
<DialogContent onRef={this.onDialogContentRef}> <DialogContent onRef={this.onDialogContentRef}>
{this.renderErrorMessage(error)} <div id="app-error-description">
{this.renderContentAfterErrorMessage(error)} {this.renderErrorMessage(error)}
{this.renderContentAfterErrorMessage(error)}
</div>
</DialogContent> </DialogContent>
{this.renderFooter(error)} {this.renderFooter(error)}
</Dialog> </Dialog>