development/github-desktop
development/github-desktop
1
0
Fork 0
mirror of https://github.com/desktop/desktop synced 2024-09-18 07:32:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

Track trampoline server/client errors separately

Browse source 
We don't need to close the server when the error comes from the client.
This commit is contained in:
Sergio Padrino 2021-03-11 13:56:27 +01:00
parent 5162e0c641
commit 3f4da2c8b9
1 changed files with 7 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
app/src/lib/trampoline/trampoline-server.ts
View file

@ -66,7 +66,7 @@ export class TrampolineServer {
this.server.listen(0, '127.0.0.1', async () => {
// Replace the error handler
this.server.removeAllListeners('error')
this.server.on('error', this.onError)
this.server.on('error', this.onServerError)
resolve()
})
@ -126,7 +126,7 @@ export class TrampolineServer {
this.onDataReceived(socket, parser, data)
})
socket.on('error', this.onError)
socket.on('error', this.onClientError)
}
private onDataReceived(
@ -179,10 +179,14 @@ export class TrampolineServer {
}
}
private onError = (error: Error) => {
private onServerError = (error: Error) => {
sendNonFatalException('trampolineServer', error)
this.close()
}
private onClientError = (error: Error) => {
sendNonFatalException('trampolineClient', error)
}
}
export const trampolineServer = new TrampolineServer()