development/github-desktop
development/github-desktop
1
0
Fork 0
mirror of https://github.com/desktop/desktop synced 2024-09-17 23:21:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #8220 from vilmibm/8156-openExternal

Browse source 
use openExternal async
This commit is contained in:
Nate Smith 2019-09-10 15:15:19 -05:00 committed by GitHub
parent 46a9980923 1448b6dc4d
commit 284e374294
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
app/src/main-process/main.ts
View file

@ -486,7 +486,7 @@ app.on('ready', () => {
ipcMain.on(
'open-external',
(event: Electron.IpcMessageEvent, { path }: { path: string }) => {
async (event: Electron.IpcMessageEvent, { path }: { path: string }) => {
const pathLowerCase = path.toLowerCase()
if (
pathLowerCase.startsWith('http://') ||
@ -495,7 +495,14 @@ app.on('ready', () => {
log.info(`opening in browser: ${path}`)
}
const result = shell.openExternal(path)
let result
try {
await shell.openExternal(path)
result = true
} catch (e) {
log.error(`Call to openExternal failed: '${e}'`)
result = false
}
event.sender.send('open-external-result', { result })
}
)