development/github-desktop
development/github-desktop
1
0
Fork 0
mirror of https://github.com/desktop/desktop synced 2024-09-13 21:31:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

naming things is hard

Browse source
This commit is contained in:
Brendan Forster 2019-05-21 11:52:16 -03:00
parent 9872cede13
commit 27f67c5e9b
4 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/src/lib/stats/stats-database.ts
View file

@ -138,7 +138,7 @@ export interface IDailyMeasures {
readonly dotcomCommits: number
/** The number of times the user made a commit to a protected GitHub or GitHub Enterprise repository */
readonly commitsMadeToProtectedBranch: number
readonly commitsToProtectedBranch: number
/** The number of times the user dismissed the merge conflicts dialog */
readonly mergeConflictsDialogDismissalCount: number

6
app/src/lib/stats/stats-store.ts
View file

@ -100,7 +100,7 @@ const DefaultDailyMeasures: IDailyMeasures = {
suggestedStepPublishRepository: 0,
suggestedStepPublishBranch: 0,
suggestedStepCreatePullRequest: 0,
commitsMadeToProtectedBranch: 0,
commitsToProtectedBranch: 0,
}
interface IOnboardingStats {
@ -684,9 +684,9 @@ export class StatsStore implements IStatsStore {
}
/** Record that the user made a commit to a protected GitHub or GitHub Enterprise repository */
public recordCommitMadeToProtectedBranch(): Promise<void> {
public recordCommitToProtectedBranch(): Promise<void> {
return this.updateDailyMeasures(m => ({
commitsMadeToProtectedBranch: m.commitsMadeToProtectedBranch + 1,
commitsToProtectedBranch: m.commitsToProtectedBranch + 1,
}))
}

2
app/src/lib/stores/app-store.ts
View file

@ -2388,7 +2388,7 @@ export class AppStore extends TypedBaseStore<IAppState> {
)
if (isProtected) {
this.statsStore.recordCommitMadeToProtectedBranch()
this.statsStore.recordCommitToProtectedBranch()
}
}
}

2
docs/process/metrics.md
View file

@ -34,7 +34,7 @@ These are general metrics about feature usage and specific feature behaviors. Th
| `branchComparisons` | The number of times a branch is compared to an arbitrary branch. | To understand usage patterns around the compare branches feature. |
| `coAuthoredCommits` | The number of commits created with one or more co-authors. | To understand usage patterns of commits made in Desktop. |
| `commits` | The number of commits made. | To understand usage patterns of commits made in Desktop. |
| `commitsMadeToProtectedBranch` | The number of commits made to a protected branch. | To understand whether the app could guide users depending on the repository configuration. |
| `commitsToProtectedBranch` | Flag indicating the user committed to a repository with protected branches set. | To understand whether the app could guide users depending on the repository configuration. |
| `createPullRequestCount` | The number of times the user is taken to the create pull request page on GitHub.com. | To understand how people are creating pull requests via Desktop. |
| `defaultBranchComparisons` | The number of times a branch is compared to the default branch. | To understand usage patterns around the compare branches feature. |
| `divergingBranchBannerDismissal` | The number of times the user dismisses the diverged branch notification. | To understand usage patterns around the notification of diverging from the default branch feature. |