development/github-desktop
development/github-desktop
1
0
Fork 0
mirror of https://github.com/desktop/desktop synced 2024-10-31 05:19:03 +00:00
Code Issues Projects Releases Packages Wiki Activity

Revert "Use Radio not checkbox.."

Browse source 
This reverts commit 2b2596a7bc.
This commit is contained in:
tidy-dev 2023-08-23 17:15:48 -04:00
parent 2b2596a7bc
commit 229de1ec66
2 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/src/ui/app-menu/menu-list-item.tsx
View file

@ -180,7 +180,7 @@ export class MenuListItem extends React.Component<IMenuListItemProps, {}> {
const role = this.props.hasNoRole
? undefined
: type === 'radio'
: type === 'checkbox'
? 'menuitemradio'
: 'menuitem'
const ariaChecked = type === 'checkbox' ? item.checked : undefined

6
app/src/ui/dropdown-select-button.tsx
View file

@ -4,7 +4,7 @@ import { Button } from './lib/button'
import { Octicon } from './octicons'
import * as OcticonSymbol from './octicons/octicons.generated'
import { MenuPane } from './app-menu'
import { IRadioMenuItem, MenuItem } from '../models/app-menu'
import { ICheckboxMenuItem, MenuItem } from '../models/app-menu'
import { ClickSource, SelectionSource } from './lib/list'
export interface IDropdownSelectButtonOption {
@ -272,8 +272,8 @@ export class DropdownSelectButton extends React.Component<
options: ReadonlyArray<IDropdownSelectButtonOption>,
checkedOptionId: string | undefined
): ReadonlyArray<MenuItem> {
const defaultCheckBoxMenuItem: IRadioMenuItem = {
type: 'radio',
const defaultCheckBoxMenuItem: ICheckboxMenuItem = {
type: 'checkbox',
id: '',
label: '',
checked: false,