From 0f19cde5ed6b736ab458f8f6299590239b0277a6 Mon Sep 17 00:00:00 2001 From: saurabh-git-dev Date: Thu, 23 May 2024 21:12:47 +0530 Subject: [PATCH] Changed: getLatestCheckRuns method name method name changed and formatted the code. --- app/src/lib/ci-checks/ci-checks.ts | 12 +++--- app/src/lib/stores/commit-status-store.ts | 22 +++++------ app/src/lib/stores/notifications-store.ts | 46 +++++++++++------------ 3 files changed, 38 insertions(+), 42 deletions(-) diff --git a/app/src/lib/ci-checks/ci-checks.ts b/app/src/lib/ci-checks/ci-checks.ts index 40b23f730b..1efb276b1d 100644 --- a/app/src/lib/ci-checks/ci-checks.ts +++ b/app/src/lib/ci-checks/ci-checks.ts @@ -1,15 +1,15 @@ +import { Account } from '../../models/account' +import { GitHubRepository } from '../../models/github-repository' import { - APICheckStatus, + API, APICheckConclusion, - IAPIWorkflowJobStep, + APICheckStatus, IAPIRefCheckRun, IAPIRefStatusItem, - API, + IAPIWorkflowJobStep, IAPIWorkflowJobs, IAPIWorkflowRun, } from '../api' -import { GitHubRepository } from '../../models/github-repository' -import { Account } from '../../models/account' import { supportsRetrieveActionWorkflowByCheckSuiteId } from '../endpoint-capabilities' import { formatLongPreciseDuration, @@ -286,7 +286,7 @@ export function isSuccess(check: IRefCheck) { * We use the check suite id as a proxy for determining what's * the "latest" of two check runs with the same name. */ -export function getLatestCheckRunsByName( +export function getLatestCheckRunsById( checkRuns: ReadonlyArray ): ReadonlyArray { const latestCheckRunsByName = new Map() diff --git a/app/src/lib/stores/commit-status-store.ts b/app/src/lib/stores/commit-status-store.ts index 6990edd969..506e32f39c 100644 --- a/app/src/lib/stores/commit-status-store.ts +++ b/app/src/lib/stores/commit-status-store.ts @@ -1,24 +1,24 @@ import pLimit from 'p-limit' import QuickLRU from 'quick-lru' +import { Disposable, DisposableLike } from 'event-kit' +import xor from 'lodash/xor' import { Account } from '../../models/account' -import { AccountsStore } from './accounts-store' import { GitHubRepository } from '../../models/github-repository' import { API, getAccountForEndpoint, IAPICheckSuite } from '../api' -import { DisposableLike, Disposable } from 'event-kit' import { + apiCheckRunToRefCheck, + apiStatusToRefCheck, + createCombinedCheckFromChecks, + getCheckRunActionsWorkflowRuns, + getLatestCheckRunsById, + getLatestPRWorkflowRunsLogsForCheckRun, ICombinedRefCheck, IRefCheck, - createCombinedCheckFromChecks, - apiCheckRunToRefCheck, - getLatestCheckRunsByName, - apiStatusToRefCheck, - getLatestPRWorkflowRunsLogsForCheckRun, - getCheckRunActionsWorkflowRuns, manuallySetChecksToPending, } from '../ci-checks/ci-checks' -import xor from 'lodash/xor' import { offsetFromNow } from '../offset-from' +import { AccountsStore } from './accounts-store' interface ICommitStatusCacheEntry { /** @@ -310,9 +310,7 @@ export class CommitStatusStore { } if (checkRuns !== null) { - const latestCheckRunsByName = getLatestCheckRunsByName( - checkRuns.check_runs - ) + const latestCheckRunsByName = getLatestCheckRunsById(checkRuns.check_runs) checks.push(...latestCheckRunsByName.map(apiCheckRunToRefCheck)) } diff --git a/app/src/lib/stores/notifications-store.ts b/app/src/lib/stores/notifications-store.ts index 5d0b04f115..60453ae270 100644 --- a/app/src/lib/stores/notifications-store.ts +++ b/app/src/lib/stores/notifications-store.ts @@ -1,25 +1,34 @@ +import { NotificationCallback } from 'desktop-notifications/dist/notification-callback' +import { Commit, shortenSHA } from '../../models/commit' +import { GitHubRepository } from '../../models/github-repository' +import { PullRequest, getPullRequestCommitRef } from '../../models/pull-request' import { Repository, - isRepositoryWithGitHubRepository, RepositoryWithGitHubRepository, - isRepositoryWithForkedGitHubRepository, getForkContributionTarget, + isRepositoryWithForkedGitHubRepository, + isRepositoryWithGitHubRepository, } from '../../models/repository' import { ForkContributionTarget } from '../../models/workflow-preferences' -import { getPullRequestCommitRef, PullRequest } from '../../models/pull-request' +import { getVerbForPullRequestReview } from '../../ui/notifications/pull-request-review-helpers' import { API, APICheckConclusion, IAPIComment } from '../api' import { - createCombinedCheckFromChecks, - getLatestCheckRunsByName, - apiStatusToRefCheck, - apiCheckRunToRefCheck, IRefCheck, + apiCheckRunToRefCheck, + apiStatusToRefCheck, + createCombinedCheckFromChecks, + getLatestCheckRunsById, } from '../ci-checks/ci-checks' -import { AccountsStore } from './accounts-store' import { getCommit } from '../git' -import { GitHubRepository } from '../../models/github-repository' -import { PullRequestCoordinator } from './pull-request-coordinator' -import { Commit, shortenSHA } from '../../models/commit' +import { getBoolean, setBoolean } from '../local-storage' +import { showNotification } from '../notifications/show-notification' +import { StatsStore } from '../stats' +import { truncateWithEllipsis } from '../truncate-with-ellipsis' +import { + ValidNotificationPullRequestReview, + isValidNotificationPullRequestReview, +} from '../valid-notification-pull-request-review' +import { AccountsStore } from './accounts-store' import { AliveStore, DesktopAliveEvent, @@ -27,16 +36,7 @@ import { IDesktopPullRequestCommentAliveEvent, IDesktopPullRequestReviewSubmitAliveEvent, } from './alive-store' -import { setBoolean, getBoolean } from '../local-storage' -import { showNotification } from '../notifications/show-notification' -import { StatsStore } from '../stats' -import { truncateWithEllipsis } from '../truncate-with-ellipsis' -import { getVerbForPullRequestReview } from '../../ui/notifications/pull-request-review-helpers' -import { - isValidNotificationPullRequestReview, - ValidNotificationPullRequestReview, -} from '../valid-notification-pull-request-review' -import { NotificationCallback } from 'desktop-notifications/dist/notification-callback' +import { PullRequestCoordinator } from './pull-request-coordinator' export type OnChecksFailedCallback = ( repository: RepositoryWithGitHubRepository, @@ -537,9 +537,7 @@ export class NotificationsStore { } if (checkRuns !== null) { - const latestCheckRunsByName = getLatestCheckRunsByName( - checkRuns.check_runs - ) + const latestCheckRunsByName = getLatestCheckRunsById(checkRuns.check_runs) checks.push(...latestCheckRunsByName.map(apiCheckRunToRefCheck)) }