development/github-desktop
development/github-desktop
1
0
Fork 0
mirror of https://github.com/desktop/desktop synced 2024-10-30 06:03:10 +00:00
Code Issues Projects Releases Packages Wiki Activity

Swap whitelist for allowlist and blacklist for denylist

Browse source
This commit is contained in:
Billy Griffin 2020-05-12 11:43:23 -06:00
parent 7fca28ed29
commit 0ced1911c0
2 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
app/src/lib/shell.ts
View file

@ -10,7 +10,7 @@ type IndexLookup = {
/**
* The names of any env vars that we shouldn't copy from the shell environment.
*/
const BlacklistedNames = new Set(['LOCAL_GIT_DIRECTORY'])
const DenylistedNames = new Set(['LOCAL_GIT_DIRECTORY'])
/**
* Inspect whether the current process needs to be patched to get important
@ -152,7 +152,7 @@ async function getEnvironmentFromShell(
*/
function mergeEnvironmentVariables(env: IndexLookup) {
for (const key in env) {
if (BlacklistedNames.has(key)) {
if (DenylistedNames.has(key)) {
continue
}

2
docs/known-issues.md
View file

@ -114,7 +114,7 @@ are unable to find another cygwin DLL.
Enabling Mandatory ASLR affects the MSYS2 core library, which is relied upon by Git for Windows to emulate process forking.
**Not supported:** this is an upstream limitation of MSYS2, and it is recommend that you either disable Mandatory ASLR or whitelist all executables under `<Git>\usr\bin` which depend on MSYS2.
**Not supported:** this is an upstream limitation of MSYS2, and it is recommend that you either disable Mandatory ASLR or allowlist all executables under `<Git>\usr\bin` which depend on MSYS2.
### I get a black screen when launching Desktop