development/gitg
development/gitg
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/gitg synced 2024-08-28 12:30:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix restore scroll when not visible

Browse source
This commit is contained in:
Jesse van den Kieboom 2014-07-11 14:10:00 +02:00
parent 3acfb98cb3
commit 8e16491f95
1 changed files with 26 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

43
gitg/history/gitg-history.vala
View file

@ -240,11 +240,12 @@ namespace GitgHistory
d_selected.clear();
Gtk.TreePath startp, endp;
view.get_visible_range(out startp, out endp);
d_scroll_to = null;
Gtk.TreePath startp, endp;
var isvis = view.get_visible_range(out startp, out endp);
view.get_selection().selected_foreach((model, path, iter) => {
var c = d_commit_list_model.commit_from_iter(iter);
@ -253,25 +254,33 @@ namespace GitgHistory
d_selected.add(c.get_id());
if (d_scroll_to == null &&
startp.compare(path) <= 0 && endp.compare(path) >= 0)
(!isvis || startp.compare(path) <= 0 && endp.compare(path) >= 0))
{
Gdk.Rectangle rect;
Gdk.Rectangle visrect;
if (isvis)
{
Gdk.Rectangle rect;
Gdk.Rectangle visrect;
view.get_cell_area(path, null, out rect);
view.get_visible_rect(out visrect);
view.get_cell_area(path, null, out rect);
view.get_visible_rect(out visrect);
int x, y;
int x, y;
view.convert_tree_to_bin_window_coords(visrect.x,
visrect.y,
out x,
out y);
view.convert_tree_to_bin_window_coords(visrect.x,
visrect.y,
out x,
out y);
// + 2 seems to work correctly here, but this is probably
// something related to a border or padding of the
// treeview (i.e. theme related)
d_scroll_y = (float)(rect.y + rect.height / 2.0 - y + 2) / (float)visrect.height;
}
else
{
d_scroll_y = 0.5f;
}
// + 2 seems to work correctly here, but this is probably
// something related to a border or padding of the
// treeview (i.e. theme related)
d_scroll_y = (float)(rect.y + rect.height / 2.0 - y + 2) / (float)visrect.height;
d_scroll_to = c.get_id();
}
}