mirror of
https://github.com/git/git
synced 2024-08-27 03:29:21 +00:00
832c68b3c2
There are quite a few tests which print an error messages and then explicitly signal failure with `false`, `return 1`, or `exit 1` as the final command in an `if` branch. In these cases, the tests don't bother maintaining the &&-chain between `echo` and the explicit "test failed" indicator. Since such constructs are manually signaling failure, their &&-chain breakage is legitimate and safe -- both for the command immediately preceding `false`, `return`, or `exit`, as well as for all preceding commands in the `if` branch. Therefore, stop flagging &&-chain breakage in these sorts of cases. Signed-off-by: Eric Sunshine <sunshine@sunshineco.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
16 lines
224 B
Plaintext
16 lines
224 B
Plaintext
(
|
|
for i in a b c
|
|
do
|
|
if false
|
|
then
|
|
# LINT: missing "&&" on "echo" okay since "exit 1" signals error explicitly
|
|
echo "err"
|
|
exit 1
|
|
# LINT: missing "&&" on "fi"
|
|
fi
|
|
foo
|
|
# LINT: missing "&&" on "done"
|
|
done
|
|
bar
|
|
)
|