mirror of
https://github.com/git/git
synced 2024-08-28 03:59:25 +00:00
f53156f2ee
Some of the rules for using COPY_ARRAY instead of memcpy with sizeof are intended to reduce the number of sizeof variants to deal with. They can have unintended side effects if only they match, but not the one for the COPY_ARRAY conversion at the end. Avoid these side effects by instead using a self-contained rule for each combination of array and pointer for source and destination which lists all sizeof variants inline. This lets "make contrib/coccinelle/array.cocci.patch" take 15% longer on my machine, but gives peace of mind that no incomplete transformation will be generated. Suggested-by: Junio C Hamano <gitster@pobox.com> Signed-off-by: René Scharfe <l.s.r@web.de> Signed-off-by: Junio C Hamano <gitster@pobox.com>
97 lines
2.1 KiB
Plaintext
97 lines
2.1 KiB
Plaintext
@@
|
|
type T;
|
|
T *dst_ptr;
|
|
T *src_ptr;
|
|
expression n;
|
|
@@
|
|
- memcpy(dst_ptr, src_ptr, (n) * \( sizeof(T)
|
|
- \| sizeof(*(dst_ptr))
|
|
- \| sizeof(*(src_ptr))
|
|
- \| sizeof(dst_ptr[...])
|
|
- \| sizeof(src_ptr[...])
|
|
- \) )
|
|
+ COPY_ARRAY(dst_ptr, src_ptr, n)
|
|
|
|
@@
|
|
type T;
|
|
T *dst_ptr;
|
|
T[] src_arr;
|
|
expression n;
|
|
@@
|
|
- memcpy(dst_ptr, src_arr, (n) * \( sizeof(T)
|
|
- \| sizeof(*(dst_ptr))
|
|
- \| sizeof(*(src_arr))
|
|
- \| sizeof(dst_ptr[...])
|
|
- \| sizeof(src_arr[...])
|
|
- \) )
|
|
+ COPY_ARRAY(dst_ptr, src_arr, n)
|
|
|
|
@@
|
|
type T;
|
|
T[] dst_arr;
|
|
T *src_ptr;
|
|
expression n;
|
|
@@
|
|
- memcpy(dst_arr, src_ptr, (n) * \( sizeof(T)
|
|
- \| sizeof(*(dst_arr))
|
|
- \| sizeof(*(src_ptr))
|
|
- \| sizeof(dst_arr[...])
|
|
- \| sizeof(src_ptr[...])
|
|
- \) )
|
|
+ COPY_ARRAY(dst_arr, src_ptr, n)
|
|
|
|
@@
|
|
type T;
|
|
T[] dst_arr;
|
|
T[] src_arr;
|
|
expression n;
|
|
@@
|
|
- memcpy(dst_arr, src_arr, (n) * \( sizeof(T)
|
|
- \| sizeof(*(dst_arr))
|
|
- \| sizeof(*(src_arr))
|
|
- \| sizeof(dst_arr[...])
|
|
- \| sizeof(src_arr[...])
|
|
- \) )
|
|
+ COPY_ARRAY(dst_arr, src_arr, n)
|
|
|
|
@@
|
|
type T;
|
|
T *dst;
|
|
T *src;
|
|
expression n;
|
|
@@
|
|
(
|
|
- memmove(dst, src, (n) * sizeof(*dst));
|
|
+ MOVE_ARRAY(dst, src, n);
|
|
|
|
|
- memmove(dst, src, (n) * sizeof(*src));
|
|
+ MOVE_ARRAY(dst, src, n);
|
|
|
|
|
- memmove(dst, src, (n) * sizeof(T));
|
|
+ MOVE_ARRAY(dst, src, n);
|
|
)
|
|
|
|
@@
|
|
type T;
|
|
T *ptr;
|
|
expression n;
|
|
@@
|
|
- ptr = xmalloc((n) * sizeof(*ptr));
|
|
+ ALLOC_ARRAY(ptr, n);
|
|
|
|
@@
|
|
type T;
|
|
T *ptr;
|
|
expression n;
|
|
@@
|
|
- ptr = xmalloc((n) * sizeof(T));
|
|
+ ALLOC_ARRAY(ptr, n);
|
|
|
|
@@
|
|
type T;
|
|
T *ptr;
|
|
expression n != 1;
|
|
@@
|
|
- ptr = xcalloc(n, \( sizeof(*ptr) \| sizeof(T) \) )
|
|
+ CALLOC_ARRAY(ptr, n)
|