mirror of
https://github.com/git/git
synced 2024-08-28 12:09:19 +00:00
![Eric Sunshine](/assets/img/avatar_default.png)
During the development of chainlint.pl, numerous new self-tests were created to verify correct functioning beyond the checks already represented by the existing self-tests. The new checks fall into several categories: * behavior of the lexical analyzer for complex cases, such as line splicing, token pasting, entering and exiting string contexts inside and outside of test script bodies; for instance: test_expect_success 'title' ' x=$(echo "something" | sed -e '\''s/\\/\\\\/g'\'' -e '\''s/[[/.*^$]/\\&/g'\'' ' * behavior of the parser for all compound grammatical constructs, such as `if...fi`, `case...esac`, `while...done`, `{...}`, etc., and for other legal shell grammatical constructs not covered by existing chainlint.sed self-tests, as well as complex cases, such as: OUT=$( ((large_git 1>&3) | :) 3>&1 ) && * detection of problems, such as &&-chain breakage, from top-level to any depth since the existing self-tests do not cover any top-level context and only cover subshells one level deep due to limitations of chainlint.sed * address blind spots in chainlint.sed (such as not detecting a broken &&-chain on a one-line for-loop in a subshell[1]) which chainlint.pl correctly detects * real-world cases which tripped up chainlint.pl during its development [1]: https://lore.kernel.org/git/dce35a47012fecc6edc11c68e91dbb485c5bc36f.1661663880.git.gitgitgadget@gmail.com/ Signed-off-by: Eric Sunshine <sunshine@sunshineco.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
28 lines
335 B
Plaintext
28 lines
335 B
Plaintext
(
|
|
# LINT: missing "&&" after first "echo"
|
|
foo &&
|
|
{
|
|
echo a
|
|
echo b
|
|
} &&
|
|
bar &&
|
|
# LINT: missing "&&" at closing "}"
|
|
{
|
|
echo c
|
|
}
|
|
baz
|
|
) &&
|
|
|
|
# LINT: ";" not allowed in place of "&&"
|
|
{
|
|
echo a; echo b
|
|
} &&
|
|
{ echo a; echo b; } &&
|
|
|
|
# LINT: "}" inside string not mistaken as end of block
|
|
{
|
|
echo "${var}9" &&
|
|
echo "done"
|
|
} &&
|
|
finis
|