mirror of
https://github.com/git/git
synced 2024-11-05 18:59:29 +00:00
e8a1c686ae
The test with disabled rerere should make sure that the cherry-picked result does not have the conflict replaced with a recorded resolution. It attempts to do so by ensuring that the file content is _not_ equal to some other file. That by itself is a very dubious check because just about every random result of an incomplete cherry-pick would satisfy the condition. In this case, the intent was to check that the conflicting file does _not_ contain the resolved content. But the check actually uses the wrong reference file, but not the resolved content. Needless to say that the non-equality is satisfied. And, on top of it, it uses a commit that does not even touch the file that is checked. Do check for the expected result, which is content from both sides of the merge and merge conflicts. (The latter we check for just the middle separator for brevity.) As a side-effect, this also removes an incorrect use of test_must_fail. Signed-off-by: Johannes Sixt <j6t@kdbg.org> Signed-off-by: Denton Liu <liu.denton@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
103 lines
3.2 KiB
Bash
Executable file
103 lines
3.2 KiB
Bash
Executable file
#!/bin/sh
|
|
|
|
test_description='cherry-pick should rerere for conflicts'
|
|
|
|
. ./test-lib.sh
|
|
|
|
test_expect_success setup '
|
|
test_commit foo &&
|
|
test_commit foo-master foo &&
|
|
test_commit bar-master bar &&
|
|
|
|
git checkout -b dev foo &&
|
|
test_commit foo-dev foo &&
|
|
test_commit bar-dev bar &&
|
|
git config rerere.enabled true
|
|
'
|
|
|
|
test_expect_success 'conflicting merge' '
|
|
test_must_fail git merge master
|
|
'
|
|
|
|
test_expect_success 'fixup' '
|
|
echo foo-resolved >foo &&
|
|
echo bar-resolved >bar &&
|
|
git commit -am resolved &&
|
|
cp foo foo-expect &&
|
|
cp bar bar-expect &&
|
|
git reset --hard HEAD^
|
|
'
|
|
|
|
test_expect_success 'cherry-pick conflict with --rerere-autoupdate' '
|
|
test_must_fail git cherry-pick --rerere-autoupdate foo..bar-master &&
|
|
test_cmp foo-expect foo &&
|
|
git diff-files --quiet &&
|
|
test_must_fail git cherry-pick --continue &&
|
|
test_cmp bar-expect bar &&
|
|
git diff-files --quiet &&
|
|
git cherry-pick --continue &&
|
|
git reset --hard bar-dev
|
|
'
|
|
|
|
test_expect_success 'cherry-pick conflict repsects rerere.autoUpdate' '
|
|
test_config rerere.autoUpdate true &&
|
|
test_must_fail git cherry-pick foo..bar-master &&
|
|
test_cmp foo-expect foo &&
|
|
git diff-files --quiet &&
|
|
test_must_fail git cherry-pick --continue &&
|
|
test_cmp bar-expect bar &&
|
|
git diff-files --quiet &&
|
|
git cherry-pick --continue &&
|
|
git reset --hard bar-dev
|
|
'
|
|
|
|
test_expect_success 'cherry-pick conflict with --no-rerere-autoupdate' '
|
|
test_config rerere.autoUpdate true &&
|
|
test_must_fail git cherry-pick --no-rerere-autoupdate foo..bar-master &&
|
|
test_cmp foo-expect foo &&
|
|
test_must_fail git diff-files --quiet &&
|
|
git add foo &&
|
|
test_must_fail git cherry-pick --continue &&
|
|
test_cmp bar-expect bar &&
|
|
test_must_fail git diff-files --quiet &&
|
|
git add bar &&
|
|
git cherry-pick --continue &&
|
|
git reset --hard bar-dev
|
|
'
|
|
|
|
test_expect_success 'cherry-pick --continue rejects --rerere-autoupdate' '
|
|
test_must_fail git cherry-pick --rerere-autoupdate foo..bar-master &&
|
|
test_cmp foo-expect foo &&
|
|
git diff-files --quiet &&
|
|
test_must_fail git cherry-pick --continue --rerere-autoupdate >actual 2>&1 &&
|
|
echo "fatal: cherry-pick: --rerere-autoupdate cannot be used with --continue" >expect &&
|
|
test_i18ncmp expect actual &&
|
|
test_must_fail git cherry-pick --continue --no-rerere-autoupdate >actual 2>&1 &&
|
|
echo "fatal: cherry-pick: --no-rerere-autoupdate cannot be used with --continue" >expect &&
|
|
test_i18ncmp expect actual &&
|
|
git cherry-pick --abort
|
|
'
|
|
|
|
test_expect_success 'cherry-pick --rerere-autoupdate more than once' '
|
|
test_must_fail git cherry-pick --rerere-autoupdate --rerere-autoupdate foo..bar-master &&
|
|
test_cmp foo-expect foo &&
|
|
git diff-files --quiet &&
|
|
git cherry-pick --abort &&
|
|
test_must_fail git cherry-pick --rerere-autoupdate --no-rerere-autoupdate --rerere-autoupdate foo..bar-master &&
|
|
test_cmp foo-expect foo &&
|
|
git diff-files --quiet &&
|
|
git cherry-pick --abort &&
|
|
test_must_fail git cherry-pick --rerere-autoupdate --no-rerere-autoupdate foo..bar-master &&
|
|
test_must_fail git diff-files --quiet &&
|
|
git cherry-pick --abort
|
|
'
|
|
|
|
test_expect_success 'cherry-pick conflict without rerere' '
|
|
test_config rerere.enabled false &&
|
|
test_must_fail git cherry-pick foo-master &&
|
|
grep ===== foo &&
|
|
grep foo-dev foo &&
|
|
grep foo-master foo
|
|
'
|
|
|
|
test_done
|