mirror of
https://github.com/git/git
synced 2024-11-05 18:59:29 +00:00
e75d2f7f73
Extend the the release_revisions() function so that it frees the "filter" in the "struct rev_info". This in combination with a preceding change to free "cmdline" means that we can mark another set of tests as passing under "TEST_PASSES_SANITIZE_LEAK=true". The "filter" member was added recently inffaa137f64(revision: put object filter into struct rev_info, 2022-03-09), and this fixes leaks intruded in the subsequent leak7940941de1(pack-objects: use rev.filter when possible, 2022-03-09) and105c6f14ad(bundle: parse filter capability, 2022-03-09). The "builtin/pack-objects.c" leak in7940941de1was effectively with us already, but the variable was referred to by a "static" file-scoped variable. The "bundle.c " leak in105c6f14adwas newly introduced with the new "filter" feature for bundles. The "t5600-clone-fail-cleanup.sh" change here to add "TEST_PASSES_SANITIZE_LEAK=true" is one of the cases where run-command.c in not carrying the abort() exit code upwards would have had that test passing before, but now it *actually* passes[1]. We should fix the lack of 1=1 mapping of SANITIZE=leak testing to actual leaks some other time, but it's an existing edge case, let's just mark the really-passing test as passing for now. 1. https://lore.kernel.org/git/220303.86fsnz5o9w.gmgdl@evledraar.gmail.com/ Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
102 lines
2.1 KiB
Bash
Executable file
102 lines
2.1 KiB
Bash
Executable file
#!/bin/sh
|
|
|
|
test_description='git remote group handling'
|
|
GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main
|
|
export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME
|
|
|
|
TEST_PASSES_SANITIZE_LEAK=true
|
|
. ./test-lib.sh
|
|
|
|
mark() {
|
|
echo "$1" >mark
|
|
}
|
|
|
|
update_repo() {
|
|
(cd $1 &&
|
|
echo content >>file &&
|
|
git add file &&
|
|
git commit -F ../mark)
|
|
}
|
|
|
|
update_repos() {
|
|
update_repo one $1 &&
|
|
update_repo two $1
|
|
}
|
|
|
|
repo_fetched() {
|
|
if test "$(git log -1 --pretty=format:%s $1 --)" = "$(cat mark)"; then
|
|
echo >&2 "repo was fetched: $1"
|
|
return 0
|
|
fi
|
|
echo >&2 "repo was not fetched: $1"
|
|
return 1
|
|
}
|
|
|
|
test_expect_success 'setup' '
|
|
mkdir one && (cd one && git init) &&
|
|
mkdir two && (cd two && git init) &&
|
|
git remote add -m main one one &&
|
|
git remote add -m main two two
|
|
'
|
|
|
|
test_expect_success 'no group updates all' '
|
|
mark update-all &&
|
|
update_repos &&
|
|
git remote update &&
|
|
repo_fetched one &&
|
|
repo_fetched two
|
|
'
|
|
|
|
test_expect_success 'nonexistent group produces error' '
|
|
mark nonexistent &&
|
|
update_repos &&
|
|
test_must_fail git remote update nonexistent &&
|
|
! repo_fetched one &&
|
|
! repo_fetched two
|
|
'
|
|
|
|
test_expect_success 'updating group updates all members (remote update)' '
|
|
mark group-all &&
|
|
update_repos &&
|
|
git config --add remotes.all one &&
|
|
git config --add remotes.all two &&
|
|
git remote update all &&
|
|
repo_fetched one &&
|
|
repo_fetched two
|
|
'
|
|
|
|
test_expect_success 'updating group updates all members (fetch)' '
|
|
mark fetch-group-all &&
|
|
update_repos &&
|
|
git fetch all &&
|
|
repo_fetched one &&
|
|
repo_fetched two
|
|
'
|
|
|
|
test_expect_success 'updating group does not update non-members (remote update)' '
|
|
mark group-some &&
|
|
update_repos &&
|
|
git config --add remotes.some one &&
|
|
git remote update some &&
|
|
repo_fetched one &&
|
|
! repo_fetched two
|
|
'
|
|
|
|
test_expect_success 'updating group does not update non-members (fetch)' '
|
|
mark fetch-group-some &&
|
|
update_repos &&
|
|
git config --add remotes.some one &&
|
|
git remote update some &&
|
|
repo_fetched one &&
|
|
! repo_fetched two
|
|
'
|
|
|
|
test_expect_success 'updating remote name updates that remote' '
|
|
mark remote-name &&
|
|
update_repos &&
|
|
git remote update one &&
|
|
repo_fetched one &&
|
|
! repo_fetched two
|
|
'
|
|
|
|
test_done
|