mirror of
https://github.com/git/git
synced 2024-09-13 13:24:41 +00:00
ee34a2bead
The git-repack command always passes `--honor-pack-keep` to pack-objects. This has traditionally been a good thing, as we do not want to duplicate those objects in a new pack, and we are not going to delete the old pack. However, when bitmaps are in use, it is important for a full repack to include all reachable objects, even if they may be duplicated in a .keep pack. Otherwise, we cannot generate the bitmaps, as the on-disk format requires the set of objects in the pack to be fully closed. Even if the repository does not generally have .keep files, a simultaneous push could cause a race condition in which a .keep file exists at the moment of a repack. The repack may try to include those objects in one of two situations: 1. The pushed .keep pack contains objects that were already in the repository (e.g., blobs due to a revert of an old commit). 2. Receive-pack updates the refs, making the objects reachable, but before it removes the .keep file, the repack runs. In either case, we may prefer to duplicate some objects in the new, full pack, and let the next repack (after the .keep file is cleaned up) take care of removing them. This patch introduces both a command-line and config option to disable the `--honor-pack-keep` option. By default, it is triggered when pack.writeBitmaps (or `--write-bitmap-index` is turned on), but specifying it explicitly can override the behavior (e.g., in cases where you prefer .keep files to bitmaps, but only when they are present). Note that this option just disables the pack-objects behavior. We still leave packs with a .keep in place, as we do not necessarily know that we have duplicated all of their objects. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
185 lines
5.7 KiB
Bash
Executable file
185 lines
5.7 KiB
Bash
Executable file
#!/bin/sh
|
|
|
|
test_description='git repack works correctly'
|
|
|
|
. ./test-lib.sh
|
|
|
|
test_expect_success 'objects in packs marked .keep are not repacked' '
|
|
echo content1 > file1 &&
|
|
echo content2 > file2 &&
|
|
git add . &&
|
|
test_tick &&
|
|
git commit -m initial_commit &&
|
|
# Create two packs
|
|
# The first pack will contain all of the objects except one
|
|
git rev-list --objects --all | grep -v file2 |
|
|
git pack-objects pack > /dev/null &&
|
|
# The second pack will contain the excluded object
|
|
packsha1=$(git rev-list --objects --all | grep file2 |
|
|
git pack-objects pack) &&
|
|
touch -r pack-$packsha1.pack pack-$packsha1.keep &&
|
|
objsha1=$(git verify-pack -v pack-$packsha1.idx | head -n 1 |
|
|
sed -e "s/^\([0-9a-f]\{40\}\).*/\1/") &&
|
|
mv pack-* .git/objects/pack/ &&
|
|
git repack --no-pack-kept-objects -A -d -l &&
|
|
git prune-packed &&
|
|
for p in .git/objects/pack/*.idx; do
|
|
idx=$(basename $p)
|
|
test "pack-$packsha1.idx" = "$idx" && continue
|
|
if git verify-pack -v $p | egrep "^$objsha1"; then
|
|
found_duplicate_object=1
|
|
echo "DUPLICATE OBJECT FOUND"
|
|
break
|
|
fi
|
|
done &&
|
|
test -z "$found_duplicate_object"
|
|
'
|
|
|
|
test_expect_success 'writing bitmaps can duplicate .keep objects' '
|
|
# build on $objsha1, $packsha1, and .keep state from previous
|
|
git repack -Adl &&
|
|
test_when_finished "found_duplicate_object=" &&
|
|
for p in .git/objects/pack/*.idx; do
|
|
idx=$(basename $p)
|
|
test "pack-$packsha1.idx" = "$idx" && continue
|
|
if git verify-pack -v $p | egrep "^$objsha1"; then
|
|
found_duplicate_object=1
|
|
echo "DUPLICATE OBJECT FOUND"
|
|
break
|
|
fi
|
|
done &&
|
|
test "$found_duplicate_object" = 1
|
|
'
|
|
|
|
test_expect_success 'loose objects in alternate ODB are not repacked' '
|
|
mkdir alt_objects &&
|
|
echo `pwd`/alt_objects > .git/objects/info/alternates &&
|
|
echo content3 > file3 &&
|
|
objsha1=$(GIT_OBJECT_DIRECTORY=alt_objects git hash-object -w file3) &&
|
|
git add file3 &&
|
|
test_tick &&
|
|
git commit -m commit_file3 &&
|
|
git repack -a -d -l &&
|
|
git prune-packed &&
|
|
for p in .git/objects/pack/*.idx; do
|
|
if git verify-pack -v $p | egrep "^$objsha1"; then
|
|
found_duplicate_object=1
|
|
echo "DUPLICATE OBJECT FOUND"
|
|
break
|
|
fi
|
|
done &&
|
|
test -z "$found_duplicate_object"
|
|
'
|
|
|
|
test_expect_success 'packed obs in alt ODB are repacked even when local repo is packless' '
|
|
mkdir alt_objects/pack &&
|
|
mv .git/objects/pack/* alt_objects/pack &&
|
|
git repack -a &&
|
|
myidx=$(ls -1 .git/objects/pack/*.idx) &&
|
|
test -f "$myidx" &&
|
|
for p in alt_objects/pack/*.idx; do
|
|
git verify-pack -v $p | sed -n -e "/^[0-9a-f]\{40\}/p"
|
|
done | while read sha1 rest; do
|
|
if ! ( git verify-pack -v $myidx | grep "^$sha1" ); then
|
|
echo "Missing object in local pack: $sha1"
|
|
return 1
|
|
fi
|
|
done
|
|
'
|
|
|
|
test_expect_success 'packed obs in alt ODB are repacked when local repo has packs' '
|
|
rm -f .git/objects/pack/* &&
|
|
echo new_content >> file1 &&
|
|
git add file1 &&
|
|
test_tick &&
|
|
git commit -m more_content &&
|
|
git repack &&
|
|
git repack -a -d &&
|
|
myidx=$(ls -1 .git/objects/pack/*.idx) &&
|
|
test -f "$myidx" &&
|
|
for p in alt_objects/pack/*.idx; do
|
|
git verify-pack -v $p | sed -n -e "/^[0-9a-f]\{40\}/p"
|
|
done | while read sha1 rest; do
|
|
if ! ( git verify-pack -v $myidx | grep "^$sha1" ); then
|
|
echo "Missing object in local pack: $sha1"
|
|
return 1
|
|
fi
|
|
done
|
|
'
|
|
|
|
test_expect_success 'packed obs in alternate ODB kept pack are repacked' '
|
|
# swap the .keep so the commit object is in the pack with .keep
|
|
for p in alt_objects/pack/*.pack
|
|
do
|
|
base_name=$(basename $p .pack) &&
|
|
if test -f alt_objects/pack/$base_name.keep
|
|
then
|
|
rm alt_objects/pack/$base_name.keep
|
|
else
|
|
touch alt_objects/pack/$base_name.keep
|
|
fi
|
|
done &&
|
|
git repack -a -d &&
|
|
myidx=$(ls -1 .git/objects/pack/*.idx) &&
|
|
test -f "$myidx" &&
|
|
for p in alt_objects/pack/*.idx; do
|
|
git verify-pack -v $p | sed -n -e "/^[0-9a-f]\{40\}/p"
|
|
done | while read sha1 rest; do
|
|
if ! ( git verify-pack -v $myidx | grep "^$sha1" ); then
|
|
echo "Missing object in local pack: $sha1"
|
|
return 1
|
|
fi
|
|
done
|
|
'
|
|
|
|
test_expect_success 'packed unreachable obs in alternate ODB are not loosened' '
|
|
rm -f alt_objects/pack/*.keep &&
|
|
mv .git/objects/pack/* alt_objects/pack/ &&
|
|
csha1=$(git rev-parse HEAD^{commit}) &&
|
|
git reset --hard HEAD^ &&
|
|
test_tick &&
|
|
git reflog expire --expire=$test_tick --expire-unreachable=$test_tick --all &&
|
|
# The pack-objects call on the next line is equivalent to
|
|
# git repack -A -d without the call to prune-packed
|
|
git pack-objects --honor-pack-keep --non-empty --all --reflog \
|
|
--unpack-unreachable </dev/null pack &&
|
|
rm -f .git/objects/pack/* &&
|
|
mv pack-* .git/objects/pack/ &&
|
|
test 0 = $(git verify-pack -v -- .git/objects/pack/*.idx |
|
|
egrep "^$csha1 " | sort | uniq | wc -l) &&
|
|
echo > .git/objects/info/alternates &&
|
|
test_must_fail git show $csha1
|
|
'
|
|
|
|
test_expect_success 'local packed unreachable obs that exist in alternate ODB are not loosened' '
|
|
echo `pwd`/alt_objects > .git/objects/info/alternates &&
|
|
echo "$csha1" | git pack-objects --non-empty --all --reflog pack &&
|
|
rm -f .git/objects/pack/* &&
|
|
mv pack-* .git/objects/pack/ &&
|
|
# The pack-objects call on the next line is equivalent to
|
|
# git repack -A -d without the call to prune-packed
|
|
git pack-objects --honor-pack-keep --non-empty --all --reflog \
|
|
--unpack-unreachable </dev/null pack &&
|
|
rm -f .git/objects/pack/* &&
|
|
mv pack-* .git/objects/pack/ &&
|
|
test 0 = $(git verify-pack -v -- .git/objects/pack/*.idx |
|
|
egrep "^$csha1 " | sort | uniq | wc -l) &&
|
|
echo > .git/objects/info/alternates &&
|
|
test_must_fail git show $csha1
|
|
'
|
|
|
|
test_expect_success 'objects made unreachable by grafts only are kept' '
|
|
test_tick &&
|
|
git commit --allow-empty -m "commit 4" &&
|
|
H0=$(git rev-parse HEAD) &&
|
|
H1=$(git rev-parse HEAD^) &&
|
|
H2=$(git rev-parse HEAD^^) &&
|
|
echo "$H0 $H2" > .git/info/grafts &&
|
|
git reflog expire --expire=$test_tick --expire-unreachable=$test_tick --all &&
|
|
git repack -a -d &&
|
|
git cat-file -t $H1
|
|
'
|
|
|
|
test_done
|
|
|