mirror of
https://github.com/git/git
synced 2024-08-27 19:49:21 +00:00
ebe8fa738d
It is possible for the remote summary line to be displayed over the local progress display line, and therefore that local progress gets bumped to the next line. However, if the progress line is long enough, it might not be entirely overwritten by the remote summary line. This creates a messed up display such as: remote: Total 310 (delta 160), reused 178 (delta 112)iB/s Receiving objects: 100% (310/310), 379.98 KiB | 136 KiB/s, done. So we have to clear the screen line before displaying the remote message to make sure the local progress is not visible anymore on the first line. Yet some Git versions on the remote side might be sending updates to the same line and terminate it with \r, and a separate packet with a single \n might be sent later when the progress display is done. This means the screen line must *not* be cleared in that case. Since the sideband code already has to figure out line breaks in the received packet to properly prepend the "remote:" prefix, we can easily determine if the remote line about to be displayed is empty. Only when it is not then a proper suffix is inserted before the \r or \n to clear the end of the screen line. Also some magic constants related to the prefix length have been replaced with a variable, making it similar to the suffix length handling. Since gcc is smart enough to detect that the variable is constant there is no impact on the generated code. Signed-off-by: Nicolas Pitre <nico@cam.org> Signed-off-by: Junio C Hamano <gitster@pobox.com>
117 lines
2.8 KiB
C
117 lines
2.8 KiB
C
#include "pkt-line.h"
|
|
#include "sideband.h"
|
|
|
|
/*
|
|
* Receive multiplexed output stream over git native protocol.
|
|
* in_stream is the input stream from the remote, which carries data
|
|
* in pkt_line format with band designator. Demultiplex it into out
|
|
* and err and return error appropriately. Band #1 carries the
|
|
* primary payload. Things coming over band #2 is not necessarily
|
|
* error; they are usually informative message on the standard error
|
|
* stream, aka "verbose"). A message over band #3 is a signal that
|
|
* the remote died unexpectedly. A flush() concludes the stream.
|
|
*/
|
|
|
|
#define PREFIX "remote:"
|
|
#define SUFFIX "\e[K" /* change to " " if ANSI sequences don't work */
|
|
|
|
int recv_sideband(const char *me, int in_stream, int out, int err)
|
|
{
|
|
unsigned pf = strlen(PREFIX);
|
|
unsigned sf = strlen(SUFFIX);
|
|
char buf[pf + LARGE_PACKET_MAX + sf + 1];
|
|
memcpy(buf, PREFIX, pf);
|
|
while (1) {
|
|
int band, len;
|
|
len = packet_read_line(in_stream, buf + pf, LARGE_PACKET_MAX);
|
|
if (len == 0)
|
|
break;
|
|
if (len < 1) {
|
|
len = sprintf(buf, "%s: protocol error: no band designator\n", me);
|
|
safe_write(err, buf, len);
|
|
return SIDEBAND_PROTOCOL_ERROR;
|
|
}
|
|
band = buf[pf] & 0xff;
|
|
len--;
|
|
switch (band) {
|
|
case 3:
|
|
buf[pf] = ' ';
|
|
buf[pf+1+len] = '\n';
|
|
safe_write(err, buf, pf+1+len+1);
|
|
return SIDEBAND_REMOTE_ERROR;
|
|
case 2:
|
|
buf[pf] = ' ';
|
|
len += pf+1;
|
|
while (1) {
|
|
int brk = pf+1;
|
|
|
|
/* Break the buffer into separate lines. */
|
|
while (brk < len) {
|
|
brk++;
|
|
if (buf[brk-1] == '\n' ||
|
|
buf[brk-1] == '\r')
|
|
break;
|
|
}
|
|
|
|
/*
|
|
* Let's insert a suffix to clear the end
|
|
* of the screen line, but only if current
|
|
* line data actually contains something.
|
|
*/
|
|
if (brk > pf+1 + 1) {
|
|
char save[sf];
|
|
memcpy(save, buf + brk, sf);
|
|
buf[brk + sf - 1] = buf[brk - 1];
|
|
memcpy(buf + brk - 1, SUFFIX, sf);
|
|
safe_write(err, buf, brk + sf);
|
|
memcpy(buf + brk, save, sf);
|
|
} else
|
|
safe_write(err, buf, brk);
|
|
|
|
if (brk < len) {
|
|
memmove(buf + pf+1, buf + brk, len - brk);
|
|
len = len - brk + pf+1;
|
|
} else
|
|
break;
|
|
}
|
|
continue;
|
|
case 1:
|
|
safe_write(out, buf + pf+1, len);
|
|
continue;
|
|
default:
|
|
len = sprintf(buf,
|
|
"%s: protocol error: bad band #%d\n",
|
|
me, band);
|
|
safe_write(err, buf, len);
|
|
return SIDEBAND_PROTOCOL_ERROR;
|
|
}
|
|
}
|
|
return 0;
|
|
}
|
|
|
|
/*
|
|
* fd is connected to the remote side; send the sideband data
|
|
* over multiplexed packet stream.
|
|
*/
|
|
ssize_t send_sideband(int fd, int band, const char *data, ssize_t sz, int packet_max)
|
|
{
|
|
ssize_t ssz = sz;
|
|
const char *p = data;
|
|
|
|
while (sz) {
|
|
unsigned n;
|
|
char hdr[5];
|
|
|
|
n = sz;
|
|
if (packet_max - 5 < n)
|
|
n = packet_max - 5;
|
|
sprintf(hdr, "%04x", n + 5);
|
|
hdr[4] = band;
|
|
safe_write(fd, hdr, 5);
|
|
safe_write(fd, p, n);
|
|
p += n;
|
|
sz -= n;
|
|
}
|
|
return ssz;
|
|
}
|