mirror of
https://github.com/git/git
synced 2024-08-27 11:39:22 +00:00
![Johan Herland](/assets/img/avatar_default.png)
This patch fixes all calls to xread() where the return value is not stored into an ssize_t. The patch should not have any effect whatsoever, other than putting better/more appropriate type names on variables. Signed-off-by: Johan Herland <johan@herland.net> Signed-off-by: Junio C Hamano <junkio@cox.net>
38 lines
689 B
C
38 lines
689 B
C
#include "cache.h"
|
|
|
|
int copy_fd(int ifd, int ofd)
|
|
{
|
|
while (1) {
|
|
char buffer[8192];
|
|
char *buf = buffer;
|
|
ssize_t len = xread(ifd, buffer, sizeof(buffer));
|
|
if (!len)
|
|
break;
|
|
if (len < 0) {
|
|
int read_error;
|
|
read_error = errno;
|
|
close(ifd);
|
|
return error("copy-fd: read returned %s",
|
|
strerror(read_error));
|
|
}
|
|
while (len) {
|
|
int written = xwrite(ofd, buf, len);
|
|
if (written > 0) {
|
|
buf += written;
|
|
len -= written;
|
|
}
|
|
else if (!written) {
|
|
close(ifd);
|
|
return error("copy-fd: write returned 0");
|
|
} else {
|
|
close(ifd);
|
|
return error("copy-fd: write returned %s",
|
|
strerror(errno));
|
|
}
|
|
}
|
|
}
|
|
close(ifd);
|
|
return 0;
|
|
}
|
|
|