mirror of
https://github.com/git/git
synced 2024-07-17 11:07:55 +00:00
12c2ee5fbd
In https://github.com/microsoft/git/issues/623, it was reported that the regularly scheduled maintenance stops if one repo in the middle of the list was found to be missing. This is undesirable, and points out a gap in the design of `git for-each-repo`: We need a mode where that command does not stop on an error, but continues to try running the specified command with the other repositories. Imitating the `--keep-going` option of GNU make, this commit teaches `for-each-repo` the same trick: to continue with the operation on all the remaining repositories in case there was a problem with one repository, still setting the exit code to indicate an error occurred. Helped-by: Eric Sunshine <sunshine@sunshineco.com> Helped-by: Patrick Steinhardt <ps@pks.im> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> Signed-off-by: Junio C Hamano <gitster@pobox.com>
79 lines
2.4 KiB
Bash
Executable file
79 lines
2.4 KiB
Bash
Executable file
#!/bin/sh
|
|
|
|
test_description='git for-each-repo builtin'
|
|
|
|
TEST_PASSES_SANITIZE_LEAK=true
|
|
. ./test-lib.sh
|
|
|
|
test_expect_success 'run based on configured value' '
|
|
git init one &&
|
|
git init two &&
|
|
git init three &&
|
|
git init ~/four &&
|
|
git -C two commit --allow-empty -m "DID NOT RUN" &&
|
|
git config run.key "$TRASH_DIRECTORY/one" &&
|
|
git config --add run.key "$TRASH_DIRECTORY/three" &&
|
|
git config --add run.key "~/four" &&
|
|
git for-each-repo --config=run.key commit --allow-empty -m "ran" &&
|
|
git -C one log -1 --pretty=format:%s >message &&
|
|
grep ran message &&
|
|
git -C two log -1 --pretty=format:%s >message &&
|
|
! grep ran message &&
|
|
git -C three log -1 --pretty=format:%s >message &&
|
|
grep ran message &&
|
|
git -C ~/four log -1 --pretty=format:%s >message &&
|
|
grep ran message &&
|
|
git for-each-repo --config=run.key -- commit --allow-empty -m "ran again" &&
|
|
git -C one log -1 --pretty=format:%s >message &&
|
|
grep again message &&
|
|
git -C two log -1 --pretty=format:%s >message &&
|
|
! grep again message &&
|
|
git -C three log -1 --pretty=format:%s >message &&
|
|
grep again message &&
|
|
git -C ~/four log -1 --pretty=format:%s >message &&
|
|
grep again message
|
|
'
|
|
|
|
test_expect_success 'do nothing on empty config' '
|
|
# the whole thing would fail if for-each-ref iterated even
|
|
# once, because "git help --no-such-option" would fail
|
|
git for-each-repo --config=bogus.config -- help --no-such-option
|
|
'
|
|
|
|
test_expect_success 'error on bad config keys' '
|
|
test_expect_code 129 git for-each-repo --config=a &&
|
|
test_expect_code 129 git for-each-repo --config=a.b. &&
|
|
test_expect_code 129 git for-each-repo --config="'\''.b"
|
|
'
|
|
|
|
test_expect_success 'error on NULL value for config keys' '
|
|
cat >>.git/config <<-\EOF &&
|
|
[empty]
|
|
key
|
|
EOF
|
|
cat >expect <<-\EOF &&
|
|
error: missing value for '\''empty.key'\''
|
|
EOF
|
|
test_expect_code 129 git for-each-repo --config=empty.key 2>actual.raw &&
|
|
grep ^error actual.raw >actual &&
|
|
test_cmp expect actual
|
|
'
|
|
|
|
test_expect_success '--keep-going' '
|
|
git config keep.going non-existing &&
|
|
git config --add keep.going . &&
|
|
|
|
test_must_fail git for-each-repo --config=keep.going \
|
|
-- branch >out 2>err &&
|
|
test_grep "cannot change to .*non-existing" err &&
|
|
test_must_be_empty out &&
|
|
|
|
test_must_fail git for-each-repo --config=keep.going --keep-going \
|
|
-- branch >out 2>err &&
|
|
test_grep "cannot change to .*non-existing" err &&
|
|
git branch >expect &&
|
|
test_cmp expect out
|
|
'
|
|
|
|
test_done
|